)]}'
{"id":"openstack%2Fnova~1021","triplet_id":"openstack%2Fnova~master~I6498fbcf1b0101ff1f8bf75423bd20a38de9d677","project":"openstack/nova","branch":"master","topic":"bug/862839","hashtags":[],"change_id":"I6498fbcf1b0101ff1f8bf75423bd20a38de9d677","subject":"Revert how APIs get IP address info for instances","status":"ABANDONED","created":"2011-10-21 18:19:41.000000000","updated":"2011-10-26 17:15:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0f38117574846e5179df9670d075aeae79f83308","_number":1021,"virtual_id_number":1021,"owner":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-10-24 18:09:36.000000000","updated_by":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"reviewer":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"state":"REVIEWER"},{"updated":"2011-10-26 15:58:56.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2011-10-26 16:36:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8896494e0e4166b322d872060409c66ccf201e2c","author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"date":"2011-10-24 18:09:36.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nAfter talking with Chris, this looks like a good way to improve performance in the short term. The issue being solved here was created by attempts to separate Network/Compute layers and we should look at ways to aggregate/cache both Network and Compute data in the future.","accounts_in_message":[],"_revision_number":1},{"id":"14cdb43242e34b4c7abb27afbd636558af34ccd3","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-10-26 15:58:56.000000000","message":"Patch Set 1: Looks good to me, approved\n\nPasses locally and in smokestack, code looks good, too.","accounts_in_message":[],"_revision_number":1},{"id":"9e1bcf301a3edb48d2d00e75ad54d63eecb34306","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-26 15:59:00.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova-merge/231/ (1/3)","accounts_in_message":[],"_revision_number":1},{"id":"3c613ef8504f5573e76935b818ad6b0aad66538e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-26 15:59:01.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova-pep8/1604/ (2/3)","accounts_in_message":[],"_revision_number":1},{"id":"304220f692c9dbc9f503a93e781c9a5ad1ef5774","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-26 16:35:48.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova/121745/ (3/3)","accounts_in_message":[],"_revision_number":1},{"id":"8b82711a4997bdf89191e0e8dedd44d7a2a7cd5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-26 16:36:23.000000000","message":"Patch Set 1: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/nova-merge/231/ : This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. \nhttps://jenkins.openstack.org/job/nova/121745/ : FAILURE \nhttps://jenkins.openstack.org/job/nova-pep8/1604/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"0d8123733fc36759e597469d7355f2d3532a99f8","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-26 16:53:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"95b3376b6cac72bdf2c6c7dde963b9167479ad31","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-26 16:54:03.000000000","message":"Patch Set 1:\n\nrebased","accounts_in_message":[],"_revision_number":1},{"id":"068888c09196462f0fc0b06565157cbb839c5028","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-26 17:15:49.000000000","message":"Patch Set 2: Abandoned\n\ntest fail","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"30be486bdb703ee9cbab1adad20cd50e2d0fe052","revisions":{"f20d96e0f8c3fd76d30af815fd4c14cf3ad36146":{"kind":"REWORK","_number":1,"created":"2011-10-21 18:19:41.000000000","uploader":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"ref":"refs/changes/21/1021/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/1021/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/1021/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/1021/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/1021/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/1021/1"}}},"commit":{"parents":[{"commit":"71f2b0dfac30537054376d583323f9912078788c","subject":"Adds ext4 and reiserfs to _mount_filesystem().","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/71f2b0dfac30537054376d583323f9912078788c"}]}],"author":{"name":"Chris Behrens","email":"cbehrens@codestud.com","date":"2011-10-21 07:29:54.000000000","tz":-420},"committer":{"name":"Chris Behrens","email":"cbehrens@codestud.com","date":"2011-10-21 18:19:15.000000000","tz":-420},"subject":"Revert how APIs get IP address info for instances","message":"Revert how APIs get IP address info for instances\n\nFixes bug 862839\n\nlisting instances with IPs is extremely inefficient after changes were\nmade to query the network manager for IP information for each instance.\nI tried adding a network manager call that said \u0027give me IP information\nfor \u0027x\u0027 instances\u0027, but that was also too slow.\n\nWe need a solution that caches IP info from the network manager before\nwe can fully untie things.  So, this reverts APIs to use\ninstance[\u0027fixed_ips\u0027] which hasn\u0027t been untied in the DB yet.\n\nChange-Id: I6498fbcf1b0101ff1f8bf75423bd20a38de9d677\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f20d96e0f8c3fd76d30af815fd4c14cf3ad36146"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f20d96e0f8c3fd76d30af815fd4c14cf3ad36146"}]},"branch":"refs/heads/master"},"30be486bdb703ee9cbab1adad20cd50e2d0fe052":{"kind":"REWORK","_number":2,"created":"2011-10-26 16:53:44.000000000","uploader":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"ref":"refs/changes/21/1021/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/1021/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/1021/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/1021/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/1021/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/1021/2"}}},"commit":{"parents":[{"commit":"5e9e3873e5ee3cf87b8aec801705ee24cedcd1aa","subject":"Merge \"Removed callback concept on VM driver methods:\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5e9e3873e5ee3cf87b8aec801705ee24cedcd1aa"}]}],"author":{"name":"Chris Behrens","email":"cbehrens@codestud.com","date":"2011-10-21 07:29:54.000000000","tz":-420},"committer":{"name":"Chris Behrens","email":"cbehrens@codestud.com","date":"2011-10-26 16:53:29.000000000","tz":-420},"subject":"Revert how APIs get IP address info for instances","message":"Revert how APIs get IP address info for instances\n\nFixes bug 862839\n\nlisting instances with IPs is extremely inefficient after changes were\nmade to query the network manager for IP information for each instance.\nI tried adding a network manager call that said \u0027give me IP information\nfor \u0027x\u0027 instances\u0027, but that was also too slow.\n\nWe need a solution that caches IP info from the network manager before\nwe can fully untie things.  So, this reverts APIs to use\ninstance[\u0027fixed_ips\u0027] which hasn\u0027t been untied in the DB yet.\n\nChange-Id: I6498fbcf1b0101ff1f8bf75423bd20a38de9d677\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/30be486bdb703ee9cbab1adad20cd50e2d0fe052"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/30be486bdb703ee9cbab1adad20cd50e2d0fe052"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
