)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"8a61b2c4be15991d08952acf9caa6e5ee26c53ad","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds specific verbiage to the policies file about new"},{"line_number":10,"context_line":"hypervisor features requiring functional testing. We often add or"},{"line_number":11,"context_line":"approve new virt features without requiring functional testing."},{"line_number":12,"context_line":"Specifically for libvirt, this has broken us in the past when we"},{"line_number":13,"context_line":"add a new feature that requires a newer libvirt than we test with,"},{"line_number":14,"context_line":"and we discover that it\u0027s totally broken when we upgrade in the"},{"line_number":15,"context_line":"gate."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_4f07f817","line":12,"updated":"2014-07-15 16:12:59.000000000","message":"\"in the past\" should preferably come with a URL :)\n\ni.e. care to share the specifics? Got a launchpad bug report describing what happened, or a git commit, or .. ?","commit_id":"21fe678868c74f7780250d1a9de3d85d7d8dfe2c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"99133ae5bea0d2fe80ce4ebe7d64f3c67c637152","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds specific verbiage to the policies file about new"},{"line_number":10,"context_line":"hypervisor features requiring functional testing. We often add or"},{"line_number":11,"context_line":"approve new virt features without requiring functional testing."},{"line_number":12,"context_line":"Specifically for libvirt, this has broken us in the past when we"},{"line_number":13,"context_line":"add a new feature that requires a newer libvirt than we test with,"},{"line_number":14,"context_line":"and we discover that it\u0027s totally broken when we upgrade in the"},{"line_number":15,"context_line":"gate."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_0eefb4ea","line":12,"in_reply_to":"baada198_4f07f817","updated":"2014-07-15 21:49:03.000000000","message":"Here you go:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2014-June/038752.html","commit_id":"21fe678868c74f7780250d1a9de3d85d7d8dfe2c"}],"doc/source/devref/policies.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"39f96c2fce6d06e112c614e44aa43237a702920d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"on what is available in current distros that we expect are primary"},{"line_number":43,"context_line":"targets for deployments. This presents a problem for new nova features"},{"line_number":44,"context_line":"available only when running against a bleeding-edge libvirt. When it"},{"line_number":45,"context_line":"comes time to decide on whether to accept a such a feature into nova,"},{"line_number":46,"context_line":"we use the following rule: the required verison of libvirt should"},{"line_number":47,"context_line":"have been released in either ubuntu or Fedora for at least 30 days."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_c693c0f8","line":45,"updated":"2014-07-01 15:32:18.000000000","message":"s/accept a such a feature/accept such a feature/.","commit_id":"fa3d493fdfd402ea5987d99edbeff16158e03807"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"565823ce47a0e69d6caa4f000754fa0719d39988","unresolved":false,"context_lines":[{"line_number":44,"context_line":"available only when running against a bleeding-edge libvirt. When it"},{"line_number":45,"context_line":"comes time to decide on whether to accept a such a feature into nova,"},{"line_number":46,"context_line":"we use the following rule: the required verison of libvirt should"},{"line_number":47,"context_line":"have been released in either ubuntu or Fedora for at least 30 days."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_490d0390","line":47,"updated":"2014-07-01 15:50:26.000000000","message":"What is the rationale for adding such a rule ?\n\nIf a new feature is being added, it should not have negative impact on users who have an older libvirt. They simply won\u0027t be able to use the new feature until they upgrade. Inserting an arbitrary 30 day delay doesn\u0027t help the users who have the older libvirt, and it clearly disadvantages people who do have a new enough libvirt.\n\nIt will also have a negative impact on our ability to get testing of new features in the milestones leading upto a release, because the arbitrary 30 day delay will likely cause features to only get integrated in Nova codebase much later in the dev cycle reducing the amount of time for developers \u0026 users to test it out prior to release. It will also backs up review of changes to later in the release cycle where (we know from previous cycles) the burden of reviews on core team will be much larger.\n\nIOW, I think this would be really counter productive \u0026 actively harmful to our ongoing development \u0026 maintenance of Nova libvirt driver.","commit_id":"fa3d493fdfd402ea5987d99edbeff16158e03807"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"8a61b2c4be15991d08952acf9caa6e5ee26c53ad","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Nova requires new hypervisor features and functions to be functionally"},{"line_number":42,"context_line":"tested. Nova requires all new features to be tested in some way, but"},{"line_number":43,"context_line":"in many cases unit tests are sufficient. However, experience has shown"},{"line_number":44,"context_line":"that virt-related features are often problematic when added without"},{"line_number":45,"context_line":"functional testing, especially when they require features not present"},{"line_number":46,"context_line":"in the current version of the hypervisor (or library) being"},{"line_number":47,"context_line":"used. Thus, we specifically call out hypervisor features as requiring"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_6ab10adf","line":44,"updated":"2014-07-15 16:12:59.000000000","message":"Citation needed here also. Without it, it just sounds like hand-waving","commit_id":"21fe678868c74f7780250d1a9de3d85d7d8dfe2c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"99133ae5bea0d2fe80ce4ebe7d64f3c67c637152","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Nova requires new hypervisor features and functions to be functionally"},{"line_number":42,"context_line":"tested. Nova requires all new features to be tested in some way, but"},{"line_number":43,"context_line":"in many cases unit tests are sufficient. However, experience has shown"},{"line_number":44,"context_line":"that virt-related features are often problematic when added without"},{"line_number":45,"context_line":"functional testing, especially when they require features not present"},{"line_number":46,"context_line":"in the current version of the hypervisor (or library) being"},{"line_number":47,"context_line":"used. Thus, we specifically call out hypervisor features as requiring"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_6ea4b0b9","line":44,"in_reply_to":"baada198_6ab10adf","updated":"2014-07-15 21:49:03.000000000","message":"http://lists.openstack.org/pipermail/openstack-dev/2014-June/038752.html\n\nThere was also some callback stuff in the libvirt driver that was untested and I was seeing obvious NoneType problems in that code last December but since we didn\u0027t test it (and apparently unit tests weren\u0027t hitting it because of how the callback stuff has to be mocked - and wasn\u0027t), it got through.  That has been fixed but it was spot-checked while debugging another libvirt connection drop issue that was hitting the gate frequently at the time which would cause build errors and fail Tempest runs.","commit_id":"21fe678868c74f7780250d1a9de3d85d7d8dfe2c"}]}