)]}'
{"id":"openstack%2Fnova~103923","triplet_id":"openstack%2Fnova~master~Ib8e30d73ef7daa16009beda9bde4599bb5b14605","project":"openstack/nova","branch":"master","topic":"libvirt-feature-policy","hashtags":[],"change_id":"Ib8e30d73ef7daa16009beda9bde4599bb5b14605","subject":"Codify a rule about new hypervisor features","status":"ABANDONED","created":"2014-07-01 15:31:13.000000000","updated":"2014-11-20 15:18:20.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d328ca661c3f47c0ae2b680dcabe37237cc9c29f","_number":103923,"virtual_id_number":103923,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"disliked":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"date":"2014-07-15 14:06:32.000000000","_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2014-07-19 21:34:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"date":"2014-08-12 22:13:26.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"date":"2014-07-15 21:49:03.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"date":"2014-08-12 22:11:47.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":-1,"date":"2014-07-15 15:16:26.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2014-07-15 17:35:35.000000000","_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"disliked":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"all":[{"value":-1,"date":"2014-07-16 14:28:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-07-16 13:44:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":-2,"date":"2014-07-15 16:12:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":-2,"date":"2014-07-15 14:04:23.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":-2,"date":"2014-07-15 14:26:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"date":"2014-07-16 14:38:19.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-07-01 15:31:51.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2014-07-01 17:15:12.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-07-01 21:43:01.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2014-07-14 13:51:40.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2014-07-14 15:37:49.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2014-07-15 14:26:59.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2014-07-15 15:16:26.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-07-15 16:12:59.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2014-07-15 17:35:35.000000000","updated_by":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-07-15 21:49:03.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2014-07-16 13:44:01.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-07-16 14:28:43.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2014-07-16 14:38:19.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2014-07-19 21:34:40.000000000","updated_by":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-08-12 22:11:47.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-08-12 22:13:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f39cb9bf864d6af8c03b34d129219956e0bedcbb","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-01 15:31:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f868f10dc109bb39aef431558427dd591c90d596","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 15:31:16.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"39f96c2fce6d06e112c614e44aa43237a702920d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2014-07-01 15:32:18.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nTypo. Otherwise looks OK.","accounts_in_message":[],"_revision_number":1},{"id":"b4e1e0f97c828898b3638cbf597b9d26550d9310","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2014-07-01 15:38:23.000000000","message":"Patch Set 1:\n\nBuild failed. For rechecking only on the IBM PowerKVM CI, add a review comment with recheck-pkvm\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/103923/1/check-ibm-tempest-dsvm-full/b9cde76 : FAILURE in 6m 06s (non-voting)\n- check-ibm-tempest-dsvm-postgres-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/103923/1/check-ibm-tempest-dsvm-postgres-full/b721e02 : FAILURE in 6m 19s","accounts_in_message":[],"_revision_number":1},{"id":"565823ce47a0e69d6caa4f000754fa0719d39988","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-01 15:50:26.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f65a0dbd1222bbbf1e42b142a3392b7565acc84e","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2014-07-01 16:10:47.000000000","message":"Patch Set 1: Verified-1\n\nDatabase migration testing failed either due to migrations unable to be applied correctly or taking too long.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/1/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/10da5f95e45e4aa98988ee2290209675/131007_devstack_export.log : Return code from test script was non-zero (1)\nNo migrations run in 10m 37s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/1/check/real-db-upgrade_nova_mysql_user_001:th-mysql/33ca21264433481f9e0c646d5c4618cf/user_001.log : Return code from test script was non-zero (1)\nNo migrations run in 13m 09s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/1/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/451b7e623be5478a8a27ae197e807efa/131007_devstack_export.log : SUCCESS in 35m 01s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/1/check/real-db-upgrade_nova_percona_user_001:th-percona/8951422b39994e858460df94b699ab19/user_001.log : SUCCESS in 38m 51s\n- real-db-upgrade_nova_mysql_user_002:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/1/check/real-db-upgrade_nova_mysql_user_002:th-mysql/6a5800c0adb34bd6a44c1aeaafd5de98/user_002.log : Return code from test script was non-zero (1)\nNo migrations run in 11m 36s\n- real-db-upgrade_nova_percona_user_002:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/1/check/real-db-upgrade_nova_percona_user_002:th-percona/74c1ab6d260642a9b6faf809a084a546/user_002.log : SUCCESS in 38m 09s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/Nova/Turbo-Hipster","accounts_in_message":[],"_revision_number":1},{"id":"25d758f60eff2c4d85f52c43ea5ae4fa92054132","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 16:48:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/23/103923/1/check/gate-nova-pep8/ccfa7b3 : SUCCESS in 16m 01s\n- gate-nova-docs http://docs-draft.openstack.org/23/103923/1/check/gate-nova-docs/db171a9/doc/build/html/ : SUCCESS in 18m 19s\n- gate-nova-python26 http://logs.openstack.org/23/103923/1/check/gate-nova-python26/c8ed17f : FAILURE in 11m 43s\n- gate-nova-python27 http://logs.openstack.org/23/103923/1/check/gate-nova-python27/8170efd : FAILURE in 27m 33s\n- check-tempest-dsvm-full http://logs.openstack.org/23/103923/1/check/check-tempest-dsvm-full/4d125c4 : SUCCESS in 1h 02m 04s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/23/103923/1/check/check-tempest-dsvm-postgres-full/a2a8978 : SUCCESS in 46m 30s\n- check-tempest-dsvm-neutron http://logs.openstack.org/23/103923/1/check/check-tempest-dsvm-neutron/bd1e06d : SUCCESS in 54m 19s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/23/103923/1/check/check-tempest-dsvm-neutron-heat-slow/ece735e : SUCCESS in 29m 16s\n- check-grenade-dsvm http://logs.openstack.org/23/103923/1/check/check-grenade-dsvm/15900de : SUCCESS in 39m 02s\n- check-devstack-dsvm-cells http://logs.openstack.org/23/103923/1/check/check-devstack-dsvm-cells/ccfe618 : SUCCESS in 30m 37s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/23/103923/1/check/gate-tempest-dsvm-large-ops/78a234b : SUCCESS in 36m 47s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/23/103923/1/check/gate-tempest-dsvm-neutron-large-ops/baecd24 : SUCCESS in 32m 26s\n- gate-nova-pylint http://logs.openstack.org/23/103923/1/check/gate-nova-pylint/2e440df : SUCCESS in 28m 03s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/23/103923/1/check/check-grenade-dsvm-partial-ncpu/cce7991 : SUCCESS in 48m 09s\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/23/103923/1/check/check-tempest-dsvm-virtual-ironic-nv/dc08173 : SUCCESS in 44m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"872daa653b8d8264dd7212ac9f35480b92fa88fd","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-07-01 16:55:13.000000000","message":"Patch Set 1: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/23/103923/1/14702/results.html\n\nStandard recheck supported; use \"recheck xenserver\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"d934f156ca0f3c84a73ac4ca992aff6448d6386e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-01 17:08:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"92023a75404f6d859f794779763023bc70558654","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 17:08:19.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"cdd8fd5d6050e1fc24eb18952b677761b39629cd","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2014-07-01 17:15:12.000000000","message":"Patch Set 2:\n\nBuild failed. For rechecking only on the IBM PowerKVM CI, add a review comment with recheck-pkvm\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/103923/2/check-ibm-tempest-dsvm-full/117adc2 : FAILURE in 6m 10s (non-voting)\n- check-ibm-tempest-dsvm-postgres-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/103923/2/check-ibm-tempest-dsvm-postgres-full/3f9b7c7 : FAILURE in 4m 34s","accounts_in_message":[],"_revision_number":2},{"id":"bc79fd5228ef5fc1e80b58783740efc8456b3d04","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-07-01 18:13:03.000000000","message":"Patch Set 2: Verified+1\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/23/103923/2/14731/results.html\n\nStandard recheck supported; use \"recheck xenserver\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"47c718f1d7313cb7f8e012bb34b72fe3225201b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 18:29:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/23/103923/2/check/gate-nova-pep8/803a8c2 : SUCCESS in 13m 31s\n- gate-nova-docs http://docs-draft.openstack.org/23/103923/2/check/gate-nova-docs/ab6f69a/doc/build/html/ : SUCCESS in 13m 04s\n- gate-nova-python26 http://logs.openstack.org/23/103923/2/check/gate-nova-python26/75b2f4a : SUCCESS in 16m 01s\n- gate-nova-python27 http://logs.openstack.org/23/103923/2/check/gate-nova-python27/82adfb8 : SUCCESS in 20m 38s\n- check-tempest-dsvm-full http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-full/e6a4480 : SUCCESS in 49m 53s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-postgres-full/b8acc61 : SUCCESS in 48m 40s\n- check-tempest-dsvm-neutron http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-neutron/495f5c2 : SUCCESS in 1h 19m 07s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-neutron-heat-slow/53d9f20 : SUCCESS in 28m 54s\n- check-grenade-dsvm http://logs.openstack.org/23/103923/2/check/check-grenade-dsvm/879f9dc : SUCCESS in 42m 24s\n- check-devstack-dsvm-cells http://logs.openstack.org/23/103923/2/check/check-devstack-dsvm-cells/0ef03d8 : SUCCESS in 15m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/23/103923/2/check/gate-tempest-dsvm-large-ops/522a45e : SUCCESS in 35m 56s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/23/103923/2/check/gate-tempest-dsvm-neutron-large-ops/b205ab4 : SUCCESS in 26m 23s\n- gate-nova-pylint http://logs.openstack.org/23/103923/2/check/gate-nova-pylint/9e636bb : SUCCESS in 22m 56s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/23/103923/2/check/check-grenade-dsvm-partial-ncpu/9f69692 : SUCCESS in 37m 55s\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-virtual-ironic-nv/b638a2c : SUCCESS in 24m 53s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e249ce3ac998d788a4b7a2a53ad66d094c749fca","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2014-07-01 19:06:00.000000000","message":"Patch Set 2: Verified+1\n\nDatabase migration testing successful.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/2/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/e28acd81dd894a06be4303258ea23af1/131007_devstack_export.log : SUCCESS in 11m 21s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/2/check/real-db-upgrade_nova_mysql_user_001:th-mysql/e8303e18411a412b835332bf7bb21952/user_001.log : SUCCESS in 1h 16m 08s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/2/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/d9225aec89e34014a227586fc03934d9/131007_devstack_export.log : SUCCESS in 14m 01s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/2/check/real-db-upgrade_nova_percona_user_001:th-percona/74c9c5faf72149c7a068793f1f26c642/user_001.log : SUCCESS in 19m 28s\n- real-db-upgrade_nova_mysql_user_002:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/2/check/real-db-upgrade_nova_mysql_user_002:th-mysql/86199b1c39484ee0929cd91feed338aa/user_002.log : SUCCESS in 15m 55s\n- real-db-upgrade_nova_percona_user_002:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/2/check/real-db-upgrade_nova_percona_user_002:th-percona/fa1fdc8b201b43ca91e9a93f82d67540/user_002.log : SUCCESS in 17m 43s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/Nova/Turbo-Hipster","accounts_in_message":[],"_revision_number":2},{"id":"05c5013687c47dbb8ffdc0b1112a6efdc35459a2","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-07-01 21:43:01.000000000","message":"Patch Set 1:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-nova-python27: https://bugs.launchpad.net/bugs/1311778\n- gate-nova-python26: unrecognized error\n\nYou have some unrecognized errors.\nFor bug details see: http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":1},{"id":"bf75b9e9d255d026b4ed554cc4373dbfe4786b02","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2014-07-01 21:46:25.000000000","message":"Patch Set 2:\n\nBuild failed. For rechecking only on the Hyper-V CI, add a review comment with recheck hyper-v\n\n- http://64.119.130.115/103923/2/ : Test run failed. in 3h 28m 35s","accounts_in_message":[],"_revision_number":2},{"id":"56ea27cd03b56d72a5a4e6b3c16bd6338871cf5a","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-01 23:38:30.000000000","message":"Patch Set 2: Code-Review-1","accounts_in_message":[],"_revision_number":2},{"id":"30a9275ef3bf8ef9a3f6914ed1970804d990c131","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-07-07 20:43:08.000000000","message":"Patch Set 2: Code-Review+2\n\nI think it\u0027s important that upstream software actually has a burn in period. From our past experiences I feel that the testing in libvirt prior to an upstream release is insufficient for us to add it to our code paths. As we saw when we finally tested code paths here after the upgrade, they weren\u0027t actually sufficiently working to be useful.\n\nI think if the libvirt team would like to bring in bleeding edge features, we need them to be contributing to the infrastructure to support libvirt on the edge. Lacking that we\u0027re basically saying a burn in period in the distros that will shake out some bugs by having actual users is prudent.","accounts_in_message":[],"_revision_number":2},{"id":"b0e1a559e01fdec5679e883e5c3bb2bcf4caa90c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-07 20:43:10.000000000","message":"Patch Set 2: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"23b3b4345bc02ca474242f09b85efaee319db0e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-07 21:38:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/23/103923/2/check/gate-nova-pep8/15e885e : SUCCESS in 11m 42s\n- gate-nova-docs http://docs-draft.openstack.org/23/103923/2/check/gate-nova-docs/8cbbf86/doc/build/html/ : SUCCESS in 11m 31s\n- gate-nova-python26 http://logs.openstack.org/23/103923/2/check/gate-nova-python26/775668c : SUCCESS in 18m 00s\n- gate-nova-python27 http://logs.openstack.org/23/103923/2/check/gate-nova-python27/79dc375 : SUCCESS in 20m 37s\n- check-tempest-dsvm-full http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-full/ae40610 : SUCCESS in 47m 25s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-postgres-full/4ddf6ac : SUCCESS in 50m 27s\n- check-tempest-dsvm-neutron http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-neutron/cda4871 : SUCCESS in 54m 50s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-neutron-heat-slow/3e0684f : SUCCESS in 25m 55s\n- check-grenade-dsvm http://logs.openstack.org/23/103923/2/check/check-grenade-dsvm/ddc0ba6 : SUCCESS in 41m 42s\n- check-devstack-dsvm-cells http://logs.openstack.org/23/103923/2/check/check-devstack-dsvm-cells/10d4573 : SUCCESS in 13m 14s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/23/103923/2/check/gate-tempest-dsvm-large-ops/f010638 : SUCCESS in 22m 30s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/23/103923/2/check/gate-tempest-dsvm-neutron-large-ops/363d9cc : SUCCESS in 18m 34s\n- gate-nova-pylint http://logs.openstack.org/23/103923/2/check/gate-nova-pylint/2dffa2f : SUCCESS in 23m 24s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/23/103923/2/check/check-grenade-dsvm-partial-ncpu/b842b1b : SUCCESS in 35m 05s\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-virtual-ironic-nv/6ad39ae : SUCCESS in 30m 33s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"3301d3823fa8d56581939ad3221b393892e1dd58","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-08 10:00:35.000000000","message":"Patch Set 2: Code-Review-2\n\n\u003e I think it\u0027s important that upstream software actually has a burn in period. \n\nIf you think that then why do we pull in arbitrary external python modules the very instant they appear on pypi. It is unreasonable to set one rule for some external deps and another rule for others. \n\n\u003e As we saw when we finally tested code paths here after the upgrade, they weren\u0027t actually sufficiently working to be useful.\n\nThere is zero evidence so far that the problem with live snapshots was anything todo with libvirt flaws.\n\n\u003e Lacking that we\u0027re basically saying a burn in period in the distros that will shake out some bugs by having actual users is prudent.\n\nNo community distro I see is providing any kind of meaningful testing that is likely to shake out bugs of the type that only appear under the high load environment of the gate. So this is adding delay for no real world gain.","accounts_in_message":[],"_revision_number":2},{"id":"f48203cc5b2b62cb5ac8831b404c78b3822586d4","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-08 13:52:35.000000000","message":"Patch Set 2:\n\nDan, there are two very important differences:\n\n1. We pull *and*test* those versions live. If something breaks, it breaks immediately and we resolve it. We can\u0027t do that for libvirt\n\n2. We don\u0027t allow people to add new features to nova that depend on some unreleased or unavailable (for whatever reason) version of an external python library and just code around the fact that it might or might not be there. If you want a feature that requires a new thing in package foo, you can\u0027t add it to nova until it\u0027s in the requirements.txt file, which is what we test against.","accounts_in_message":[],"_revision_number":2},{"id":"d9b5dbd9bb3101142b57b07181afa3eb5ee0bea1","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-08 14:02:21.000000000","message":"Patch Set 2:\n\n\u003e 1. We pull *and*test* those versions live. If something breaks, it breaks immediately and we resolve it. We can\u0027t do that for libvirt\n\nThere\u0027s no reason why the gate could not run current libvirt + KVM releases instead of restricting itself to whatever old packages exist in Ubuntu LTS, just like it pulls current python packages instead of restricting itself to python versions in LTS.\n\nRegardless of what version the gate runs though, adding an arbitrary \"libvirt version must have been in a distro for 1 month\" will have *no* effect on quality. Taking the recent QEMU guest snapshot filesystem freeze feature as an example - the libvirt release with that feature could be in Fedora rawhide for 6 months and I\u0027d wager not one person will exercise that code in any meaningful way.  The only people likely to exercise that code are going to be the people developing \u0026 testing the current Nova git master. The same is true of all the other new features in libvirt we\u0027re intending to make use of in Juno for NFV. There is just no meaningful testing of this stuff in distros. Adding this arbitrary 1 month delay is merely going to mean people who want to test this in OpenStack have to wait longer for the code to merge, which will *decrease* the amount of testing this Nova feature gets before release, which is exactly the opposite of what we want or need.","accounts_in_message":[],"_revision_number":2},{"id":"f8df9d1fabd1d6f61d7bd9624bd6c8716c04f3c8","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-08 17:14:12.000000000","message":"Patch Set 2:\n\nWell, I think it will have an effect on quality. Also, I\u0027m not using the live snapshot situation as a basis for this. We\u0027re really trying to codify an answer going forward for when people show up. We recently discussed at summit that we\u0027d say \"no\" to any new feature that required a version of libvirt that wasn\u0027t in our tested distros, which means if it isn\u0027t in trusty, it\u0027s two years until we get to add new things.\n\nThis is actually a *loosening* of that idea and I think it\u0027s a pretty reasonable one. If you (or someone) would like to volunteer to create a bleeding-edge-libvirt job in upstream CI and run it for a while non-voting, I think consideration of the resulting stability and required maintenance could be made. Is that something you\u0027re interested in doing?","accounts_in_message":[],"_revision_number":2},{"id":"c0db767e6fcfb63af53d7634ef9bb6878486ae0e","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-08 17:26:31.000000000","message":"Patch Set 2:\n\n\u003e We\u0027re really trying to codify an answer going forward for when people show up.\n\nSimply being in any released libvirt version is more than sufficient IMHO. Inserting any kind of arbitrary delay will have little to no positive impact on quality and will service to discourage contributions and/or encourage forking of Nova.\n\n\u003e We recently discussed at summit that we\u0027d say \"no\" to any new feature that required a version of libvirt that wasn\u0027t in our tested distros, which means if it isn\u0027t in trusty, it\u0027s two years until we get to add new things.\n\nI don\u0027t recall that being a seriously proposed requirement at the last summit. Such a policy would be majorly shooting ourselves in the foot, because the result would be that people simply go off and fork Nova and ignore the community\n\n\u003e  If you (or someone) would like to volunteer to create a bleeding-edge-libvirt job in upstream CI and run it for a while non-voting, I think consideration of the resulting stability and required maintenance could be made. Is that something you\u0027re interested in doing?\n\nI welcome anyone setting up CI jobs to run newer packages than in Ubuntu LTS, but that isn\u0027t something I have any resources to do myself and I don\u0027t see that it should be a dependency here. Distros shipping such newer versions can \u0026 should pick up responsibility for testing them though if they wish to support the new features.","accounts_in_message":[],"_revision_number":2},{"id":"b0b3a278b373a11c8b89bb9df8acbfeac15e2afd","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2014-07-14 13:51:40.000000000","message":"Patch Set 2: Code-Review-2\n\nI have to say I\u0027m with berrange on this one.  I think this is a somewhat arbitrary requirement that I don\u0027t think is a net win.","accounts_in_message":[],"_revision_number":2},{"id":"079215cc336935585f8c42f5c9567aa55825f9b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-14 13:51:42.000000000","message":"Patch Set 2: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"42f083e4d9c0896f5a929fcc986eb86ab4d8fd53","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-14 14:55:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/23/103923/2/check/gate-nova-pep8/12699b5 : SUCCESS in 11m 52s\n- gate-nova-docs http://docs-draft.openstack.org/23/103923/2/check/gate-nova-docs/f5fb470/doc/build/html/ : SUCCESS in 8m 00s\n- gate-nova-python26 http://logs.openstack.org/23/103923/2/check/gate-nova-python26/3bd9569 : SUCCESS in 16m 13s\n- gate-nova-python27 http://logs.openstack.org/23/103923/2/check/gate-nova-python27/ff064fa : SUCCESS in 14m 29s\n- check-tempest-dsvm-full http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-full/a3915ed : SUCCESS in 47m 27s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-postgres-full/e11d9bb : SUCCESS in 37m 52s\n- check-tempest-dsvm-neutron http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-neutron/cc8961b : SUCCESS in 1h 03m 15s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-neutron-heat-slow/69c736e : SUCCESS in 24m 19s\n- check-grenade-dsvm http://logs.openstack.org/23/103923/2/check/check-grenade-dsvm/ea2bb66 : SUCCESS in 35m 13s\n- check-devstack-dsvm-cells http://logs.openstack.org/23/103923/2/check/check-devstack-dsvm-cells/44ec58a : SUCCESS in 17m 34s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/23/103923/2/check/gate-tempest-dsvm-large-ops/c36f93d : SUCCESS in 24m 58s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/23/103923/2/check/gate-tempest-dsvm-neutron-large-ops/e91f479 : SUCCESS in 22m 47s\n- gate-nova-pylint http://logs.openstack.org/23/103923/2/check/gate-nova-pylint/55be52f : SUCCESS in 23m 42s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/23/103923/2/check/check-grenade-dsvm-partial-ncpu/bfaae11 : SUCCESS in 36m 04s\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/23/103923/2/check/check-tempest-dsvm-virtual-ironic-nv/e3038b7 : SUCCESS in 36m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7ef5dd542ef303c0037f8c877f9a3da80735f211","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-14 15:00:48.000000000","message":"Patch Set 2:\n\nSo, if we were going to articulate our position on new features in nova that require a very new libvirt, what would you (Dan and Russell) suggest it be?\n\nWe\u0027ve had at least a couple of people ask to add a feature that required an unreleased libvirt, a just-released-but-not-in-a-distro libvirt, etc.\n\nMy first reaction was that we should not add things we cannot test. That currently means \"it must be supported in trusty\u0027s libvirt\" which is *far* more restrictive than what we\u0027ve proposed here.\n\nSo, are you arguing against having a policy at all? If not, what should the policy be?","accounts_in_message":[],"_revision_number":2},{"id":"b18a2714770e25d61dc643e63f8f923135ef2ef7","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-14 15:25:27.000000000","message":"Patch Set 2:\n\nI would suggest that Nova require that the libvirt feature is available in an upstream libvirt release. ie we do not depend on libvirt features that are still subject to change in libvirt itself, as we need libvirt\u0027s API stability guarantee which only takes effect from the point at which libvirt publishes a release.\n\nI think there are questions to be raised around our testing of libvirt, but I think that is a discussion that should be separate from a policy about what code we\u0027re prepared to accept.\n\nie we decide what code we want to accept, and then we should work to ensure that our test systems are capable of validating code accepted under that policy.","accounts_in_message":[],"_revision_number":2},{"id":"7e3940f6318e6a0119f1dca1eef6586e381c15f1","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-14 15:37:47.000000000","message":"Patch Set 2:\n\nThat\u0027s fine, although accepting a policy that is not achievable isn\u0027t reasonable either, IMHO. Right now, I don\u0027t think we have a way (or plan, or volunteers) to test nova against raw libvirt releases. Thus, I don\u0027t think it\u0027s reasonable for us to adopt a test-based policy we don\u0027t even have a plan for meeting.\n\nThe goal of choosing a libvirt that has baked in a distro a bit is that we assume (hope) that some level of distro verification and initial user bug-reporting has happened by the time we go to depend on it. I don\u0027t think that is in any way unreasonable. If we think that it\u0027s too nebulous or arbitrary, then I\u0027d say we should adopt a very concrete and achievable policy of \"if we can\u0027t test it, we can\u0027t add it,\" which means \"in trusty\".","accounts_in_message":[],"_revision_number":2},{"id":"a53c8a778b2811cdc0fec4c503020d2f74eb0cbd","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2014-07-14 15:37:49.000000000","message":"Patch Set 2:\n\nI am with Sean and Dan on this one.\n\nI think we need to codify an answer for this question as it comes up fairly often.\n\nWhile I understand the concern about slowing down velocity without adding a meaningful amount of burn in on new libvirt features. I don\u0027t think the status quo is a good one. I think there are a few other possible answers to this issue.\n\n* Make gate use a significantly newer version of libvirt (not sure what the -infra ramifications of this are), but this could hopefully allow for better upstream libvirt feedback while making it easier for us to get bug fixes.\n\n* Add some sort of latest libvirt(released or unreleased?) + latest devstack test outside of the gate","accounts_in_message":[],"_revision_number":2},{"id":"f2f4ec105c741be98fbcc3b1ff1e1501a1de52af","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-14 15:54:43.000000000","message":"Patch Set 2:\n\nThe kind of new features we\u0027re depending on in Nova (looking at specs proposed for Juno) are not the kind of features that users in any distro are liable to test themselves, outside of the context of Nova (or perhaps oVirt) applications. eg Users in a distro aren\u0027t likely to seriously test the NUMA/Hugepages stuff in libvirt until it is part of Nova and that Nova release is in their distro, which creates a chicken+egg problem wrt your proposal. In addition I have not seen any evidence of significant libvirt testing by the distro maintainers themselves either, except for the enterprise distros and we if we wait for enterprise distros to pick up a new libvirt we\u0027d be talking 1 year+ of delay. Finally if just having it in a distro is your benchmark, then this is satisfied by Fedora rawhide inclusion, but there\u0027s basically no user testing of that. So if you instead set the benchmark to be a released distro, then saying this is a 1 month delay is rather misleading, because distros only release once every 6 months, so you\u0027d really be talking about a 7 month delay on using new features. For all these reasons, tieing Nova acceptance to distro inclusion of libvirt is a fundamentally flawed idea that does not achieve what it purports to achieve \u0026 is detrimental to Nova.\n\nI think the key problem here is that our testing is inadequate and we need to address that aspect of it rather than crippling our development process.","accounts_in_message":[],"_revision_number":2},{"id":"1e1fc51bf1d7396ba6a687c341d45f90799032fc","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2014-07-14 19:32:52.000000000","message":"Patch Set 2:\n\nIn principle I agree with Dan Smith here, but the actual wording is tricky, i.e. the 30 day rule or whatever.\n\nStepping back I\u0027m thinking the same things as Joe, but maybe less specific.\n\nMy basic worry is that we have a section of the nova spec that talks about testing and someone writes a spec and they say \"sure yeah we\u0027ll provide some testing of something somewhere somehow\" but is anyone tracking/enforcing that?  Because we have to approve the spec to work the blueprint and code but how many bp changes are we holding from merge because the testing isn\u0027t going yet?  Or are we going to scan through approved/merged juno code in K and if it\u0027s not tested as the spec said, are we going to revert?\n\nSpecific examples in my mind are things like cinder v2 support, keystone v3 support and there was some NFV-related spec that was approved last week that had something to do about new vif plugging which required new things in libvirt and new things in neutron.  The guy pushing the spec said they were going to stand up some 3rd party CI that tested latest libvirt but he was saying \"we\u0027re going to need some help in figuring out what tempest is and what tests to run\" so it made me wonder if anyone is going to be tracking that and holding their hand through the CI setup.\n\nSo yeah we have a fine line between not wanting to hamper feature development but we also just can\u0027t accept things that aren\u0027t tested, and we can\u0027t just punt and assume that we can do everything in community infra, we don\u0027t have infinite resources there.\n\nSo the answer to me is new features have to be tested, period.  3rd party CI is fine, but we also have to do our best to make sure that new things don\u0027t merge until that testing is up and running and we can verify it\u0027s working before we\u0027re married to it.","accounts_in_message":[],"_revision_number":2},{"id":"3fa16df0e1e0083f1859c18d16e3aaa6f6adc942","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-14 20:10:42.000000000","message":"Patch Set 2:\n\nSo, it sounds to me like the popular opinion here is that we require new libvirt features to be tested before merging, regardless of how long they\u0027ve been available. That is *more* strict than just trying to define a window for things to mellow, so I\u0027m totally fine with that.\n\nIf everyone here is cool with it, I\u0027ll revise this to say that as our policy for accepting new features and then we\u0027ll just NAK new untested things until such a platform is built for that. Presumably that would be a devstack/tempest job that runs the latest version of libvirt and all the normal tempest tests.\n\nIs that cool with everyone?","accounts_in_message":[],"_revision_number":2},{"id":"1a99765e0a00664f31125dc742c89ea4cab50e61","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2014-07-14 20:47:49.000000000","message":"Patch Set 2:\n\nSounds reasonable to me.","accounts_in_message":[],"_revision_number":2},{"id":"2d43025e7aef8de1d7731893fda7c5996e0926cc","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-15 08:26:07.000000000","message":"Patch Set 2:\n\nI\u0027m really not cool with that until we have an upstream CI system that exists which is able to run with latest libvirt + KVM, because if we apply this policy today, then you can kiss goodbye to pretty much every important feature for Juno which IMHO would be a major disaster for the project.","accounts_in_message":[],"_revision_number":2},{"id":"c20eae213d3f30783687b7b46335d1083fcdfc46","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-15 08:27:31.000000000","message":"Patch Set 2:\n\nIn addition if you are going to set a policy that every new feature must have full test coverage in tempest then this should be applied project wide, not solely for the libvirt driver..","accounts_in_message":[],"_revision_number":2},{"id":"10051fefd8b4b6695f8b8fa0216fbd75835a5a0d","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2014-07-15 10:02:06.000000000","message":"Patch Set 2:\n\nI like the idea of saying: All new features *must* have test coverage (libvirt or otherwise), and saying we won\u0027t merge until the CI system shows up (if third party) and votes on the proposed patch.\n\nAnd we should just grandfather in all current specs, and only apply this to new specs (for K?).","accounts_in_message":[],"_revision_number":2},{"id":"0c87120cb206e4c46dab8dd4823b5825f7578b42","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-15 14:04:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c3d666744b8e816faf6353552548a0f575320564","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-15 14:04:27.000000000","message":"Patch Set 3:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"83b4fc1c4ab16625d9bb66470c7b7c46b2e3cd7e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-15 14:06:32.000000000","message":"Patch Set 3:\n\nChanged the rule to apply to all hypervisors, and updated it to just say that new hypervisor features must be *functionally* tested.\n\nI don\u0027t think anyone is ever going to do the work unless we make the rule. That\u0027s how it worked getting the first round of third-party CI systems running against the existing hypervisors, and raising the bar isn\u0027t going to be any different, IMHO. Hopefully \"stuff should be tested\" is a requirement bar we can all agree upon...hopefully :)","accounts_in_message":[],"_revision_number":3},{"id":"b3c7dde6ee07d0461c442f6610c4aaf150c2efbb","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-15 14:22:57.000000000","message":"Patch Set 3: Code-Review-1\n\nWhile I\u0027m in favour of having as much automated testing as possible, I\u0027m really against the idea of outright rejecting useful contributions in this way.\n\nThere are a great many people willing \u0026 able to submit features to Nova. There very few people / organizations who have the resources to actually setup the kind of CI system that would be needed here. So we are in effect going to be punishing our entire contributor base for a problem that only a small minority of the contributors have any ability to fix.\n\nIMHO it is a pretty major disincentive to contribute to OpenStack when your perfectly reasonable \u0026 desirable change is rejected due to inadequacies in an area of the project you have no influence of control over. If I were a first time contributor trying add support for some new hypervisor feature and this were the response, I\u0027d walk away from Nova and never come back. You might ultimately get improved CI systems, but the collateral damage being inflicted on otherwise willing contributors is really not good IMHO.\n\nI feel this proposal is saying that testing is the #1 priority that trumps all other factors. While I agree that testing is important, I don\u0027t think it should trump everything else. I think there needs to be some pragmatism involved here.","accounts_in_message":[],"_revision_number":3},{"id":"b0013afe4aacfe98f226bbcbd73c7626ec9696fd","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2014-07-15 14:24:33.000000000","message":"Patch Set 3: Verified-1\n\nDatabase migration testing failed either due to migrations unable to be applied correctly or taking too long.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/b6a9172eba1c40f2b8ab350f2c4dcf9b/131007_devstack_export.log : SUCCESS in 10m 16s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_mysql_user_001:th-mysql/00cebbe2796340e58230126d7c4b5e29/user_001.log : SUCCESS in 18m 10s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/b4516d7507324854bd279cfa8d9d7ef1/131007_devstack_export.log : SUCCESS in 11m 34s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_percona_user_001:th-percona/53041baac63943f58e0e1f6214eaa9b1/user_001.log : WARNING - Migration 215-\u003e216 read too many rows (964702) in 19m 12s\n- real-db-upgrade_nova_mysql_user_002:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_mysql_user_002:th-mysql/57fcc2e7654e430c8bf05eeb304ecfeb/user_002.log : SUCCESS in 17m 05s\n- real-db-upgrade_nova_percona_user_002:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_percona_user_002:th-percona/c7aa713e3036453382d4509967c37130/user_002.log : SUCCESS in 14m 29s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/Nova/Turbo-Hipster","accounts_in_message":[],"_revision_number":3},{"id":"3d41515e410e6f9efc85b4f2de250830a12085c7","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-15 14:26:59.000000000","message":"Patch Set 3: Code-Review-2","accounts_in_message":[],"_revision_number":3},{"id":"b809b89de50b46ab51e1da38b7a488e521e9a8fc","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2014-07-15 14:37:56.000000000","message":"Patch Set 3:\n\nTesting everything is one of our fundamental tenets:\n\nhttps://wiki.openstack.org/wiki/BasicDesignTenets\n\nI definitely think that requiring submissions to come with tests is entirely reasonable. We often let things slide because they\u0027re hard or urgent, and that has never turned out well, AFAICT.","accounts_in_message":[],"_revision_number":3},{"id":"c6dcfd1ac594cfe3897ac31ea6a9a64bec01738c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-15 14:59:18.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/23/103923/3/check/gate-nova-pep8/00f0220 : SUCCESS in 11m 59s\n- gate-nova-docs http://docs-draft.openstack.org/23/103923/3/check/gate-nova-docs/c96b8fd/doc/build/html/ : SUCCESS in 7m 25s\n- gate-nova-python26 http://logs.openstack.org/23/103923/3/check/gate-nova-python26/79b7ed1 : SUCCESS in 23m 18s\n- gate-nova-python27 http://logs.openstack.org/23/103923/3/check/gate-nova-python27/4056392 : SUCCESS in 20m 15s\n- check-tempest-dsvm-full http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-full/cc32b2e : SUCCESS in 54m 16s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-postgres-full/27e15a4 : SUCCESS in 34m 05s\n- check-tempest-dsvm-neutron http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-neutron/cec4dc8 : SUCCESS in 50m 44s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-neutron-heat-slow/7e35533 : SUCCESS in 18m 34s\n- check-grenade-dsvm http://logs.openstack.org/23/103923/3/check/check-grenade-dsvm/61d54e2 : SUCCESS in 36m 55s\n- check-devstack-dsvm-cells http://logs.openstack.org/23/103923/3/check/check-devstack-dsvm-cells/cfa6c76 : SUCCESS in 19m 23s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/23/103923/3/check/gate-tempest-dsvm-large-ops/4197944 : SUCCESS in 25m 21s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/23/103923/3/check/gate-tempest-dsvm-neutron-large-ops/93a795a : SUCCESS in 22m 53s\n- gate-nova-pylint http://logs.openstack.org/23/103923/3/check/gate-nova-pylint/956d96a : SUCCESS in 21m 51s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/23/103923/3/check/check-grenade-dsvm-partial-ncpu/9ab439f : SUCCESS in 39m 52s\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-virtual-ironic-nv/d594981 : FAILURE in 14m 50s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"8c6c033c5396a1690ab74e34bc00f2f55dc25bf9","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-07-15 15:16:26.000000000","message":"Patch Set 3: Verified-1\n\nFailed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/23/103923/3/16994/results.html\n\nStandard recheck supported; use \"recheck xenserver\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":3},{"id":"8a61b2c4be15991d08952acf9caa6e5ee26c53ad","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2014-07-15 16:12:59.000000000","message":"Patch Set 3: Code-Review-2\n\n(2 comments)\n\nWow, this really is something which could have used a mailing list thread ... anyway ...\n\nThe concrete situation we appear to be guarding against is this:\n\n1) A feature is added which requires a version of libvirt newer than what\u0027s available in the gate; that code path is now untested by CI\n\n2) At some point later, libvirt on our gate nodes are updated and that code path automatically gets enabled; there\u0027s a good chance it doesn\u0027t work and will wedge the gate\n\nA concrete idea tailored to address that ...\n\nWe add a new config option:\n\n  [libvirt]\n  version_cap \u003d 1.2.2\n\nthe has_min_version() function would return False if the version is greater than that cap, even if that version of the library is available\n\nThe default right now would be 1.2.2 - the version we have on gate nodes\n\nFeatures which require a newer libvirt than that only be available if the operator manually increased the cap themselves. We could have the help string explain that the default version cap corresponds to the version tested upstream. Downstream distros may choose to increase the default cap themselves if they test with newer libvirt.\n\nWhen gate nodes are updated to newer libvirt, the code paths for the features requiring newer libvirt remain untested. At some point after the libvirt update, we can propose a change to increase the cap. This change can obviously only be merged if the untested code paths do not cause any regressions.","accounts_in_message":[],"_revision_number":3},{"id":"1e713a63810fe161e2552024c74e6f831a5c3427","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2014-07-15 16:31:06.000000000","message":"Patch Set 3:\n\nOn the broader question, I\u0027m very concerned about our tendency to go down this route. I don\u0027t think I\u0027ll do the topic justice here, but see also http://lists.openstack.org/pipermail/openstack-tc/2014-July/000739.html\n\nCompared to other open source projects, we have done an awesome job in OpenStack of having good functional test coverage. Arguably, given the complexity of the system, we couldn\u0027t have got this far without it. I can take zero credit for any of it.\n\nHowever, not everything is tested now, nor is the tests we have foolproof. When you consider the number of configuration options we have, the supported distros, the ranges of library versions we claim to support, etc., etc. I don\u0027t think we can ever get to an \"everything is tested\" point.\n\nIn the absence of that, I think we should aim to be more clear what *is* tested. The config option I suggest does that, which is a big part of its merit IMHO.\n\nWe\u0027ve had some success with the \"be nasty enough to driver contributors and they\u0027ll do what we want\" approach so far, but IMHO that was an exceptional approach for an exceptional situation - drivers that were completely broken, and driver developers who didn\u0027t contribute to the core project or, worse, didn\u0027t maintain their drivers adequately.\n\nNot every contributor can be bullied like this. And even where it succeeds, I don\u0027t much love the perception it gives the project.\n\nIn this case, the effect I could imagine us having would be that rather than us successfully bullying someone into setting up \"latest libvirt CI\", we drive development of features requiring newer libvirt into a separate tree.\n\nThere would even be a perfectly defensible rationale for doing this - \"we\u0027re building features that can\u0027t go upstream until a newer libvirt shows up there\". If these are NFV features, there\u0027d likely be a bunch of downstreams that ship it. And then when the newer libvirt shows up, all the features requiring it get proposed together as fully-baked patch sets? No thank you.\n\nThe desire to have the best possible test coverage is great. The desire to document our policies around this stuff is great. But let\u0027s not forget that we\u0027re talking about contributors that need to be nurtured and contributions that should be valued.","accounts_in_message":[],"_revision_number":3},{"id":"3c93e870989723393de4c548b7a2fc0b8d75c44b","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-15 16:46:49.000000000","message":"Patch Set 3:\n\nThe idea of a config file setting for a libvirt version cap is quite appealing. Even if we had testing of the new features, I could see that setting being genuinely useful to cloud administrators to deal with unexpected bugs that might sneak through our testing and affect deployers.","accounts_in_message":[],"_revision_number":3},{"id":"3c8f7cac49fbe3b74ba7d0c7ce66a965c1e3d25a","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2014-07-15 17:35:35.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- http://64.119.130.115/103923/3/ : Looks good to me in 2h 28m 39s","accounts_in_message":[],"_revision_number":3},{"id":"7df4f15deee3e61bfa18a5472149ca0b9eb46081","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-15 17:37:31.000000000","message":"Patch Set 3:\n\nHere is a proposed change for discussion that implements Mark\u0027s idea \n\nhttps://review.openstack.org/107119","accounts_in_message":[],"_revision_number":3},{"id":"99133ae5bea0d2fe80ce4ebe7d64f3c67c637152","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2014-07-15 21:49:03.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nI\u0027m relatively OK with config options or somehow putting something into the code that if you enable it and it\u0027s busted, your shit is going to fail b/c we don\u0027t test it, like a buyer-beware mentality, and we have to explicitly turn it on to test it in the gate, rather than just moving to newer versions of libvirt that all of a sudden start running new code paths which blow up (like the snapshot issue).\n\nThe thing that worries me a bit here is whether or not we\u0027re going to set a precedent and hold to that, i.e. are we making exceptions here for this new NFV stuff because we really really want to see that get in, and are we going to have the same level of acceptance for other new features even if they can\u0027t be immediately tested upstream, and there is no one stepping up to do 3rd party CI?  Because this is a very fine line and while we don\u0027t want to turn people away from the project per-se, we also don\u0027t want to make things exclusive in a different way by saying it\u0027s OK to not follow the rules, i.e. the basic tenant of testing, if we really want your shiny thing?","accounts_in_message":[],"_revision_number":3},{"id":"053297013c7acaf71a328054b9612e2dd7350d61","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2014-07-15 23:14:30.000000000","message":"Patch Set 3:\n\nI don\u0027t think the message here is that it is OK to \"ignore the rules\". If it is practical to test something with the CI system, this can \u0026 should remains our goal. There can none the less be valid reasons why it may not be possible or practical to test a particular feature at a given time, that are not under the control of the contributors. IOW, recognising that testing is not a black \u0026 white matter where you can set an unconditional rule that CI testing is mandated for all contributions or they will be turned out.","accounts_in_message":[],"_revision_number":3},{"id":"e56b7773dc01a04629f338235f610ab1b4ec733d","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-07-16 13:44:01.000000000","message":"Patch Set 3: Code-Review+2\n\nI\u0027m mostly concerned here of what feels like a double standard being applied for libvirt. The reason that docker was removed was because of lack of CI. The reason that powervm was removed was because it wouldn\u0027t get CI. A contributing factor to ironic slow merge is CI.\n\nSo I feel like if the feeling is that it\u0027s not fair to developers to have to meet this bar, we need to apply that fact across the board and rachette down what we require of hypervisors. \n\nAnyway, this seems to be deadlocked here, so I feel we should take this to the mailing list, I\u0027ll start the thread.","accounts_in_message":[],"_revision_number":3},{"id":"c3de636054f739615cc11d068b2d7e29de02bfc0","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2014-07-16 14:28:43.000000000","message":"Patch Set 3: Code-Review-1\n\nI am almost +2 on this, but it seems too black and white in its current form, prephaps we need more pragmatism here.\n\nMaybe we state these as goals/ideals:\n* we aspire for all code to be functionally tested\n* we should be able to communicate to our users what feature we know are well tested, and should be expected to work\n\nWe do need to encourage responsible contributions to the project, but its not currently feasible to test everything.\n\nI feel we should make sure we hold current code to the same standards, so we should really do better at auditing what is tested, and what is not tested.\n\nOn the other side of things, I don\u0027t want to see 100 third party CI systems either. Maybe we need some alternative ways to test more esoteric combinations, where a specific patch can be tested on demand, and every commit is tested after merge, with a group of people responsible for keeping it green. If its not green enough over a release, it doesn\u0027t get marked as supported, etc.","accounts_in_message":[],"_revision_number":3},{"id":"adb90573d965d515fa532a463bbacb08bca333e4","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2014-07-16 15:09:28.000000000","message":"Patch Set 3:\n\nThanks for starting the thread - http://lists.openstack.org/pipermail/openstack-dev/2014-July/040421.html\n\nA much better forum for this than here or IRC IMO","accounts_in_message":[],"_revision_number":3},{"id":"0dfd75d981eb4df56964cb72764be44c0b61c5e5","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2014-07-19 21:34:40.000000000","message":"Patch Set 3: Verified+1\n\nDatabase migration testing successful.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/69bf18170a324f35b2726d7466d355b9/131007_devstack_export.log : SUCCESS in 11m 41s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_mysql_user_001:th-mysql/b9b8d5ec670148ac8ade8ae55827ed05/user_001.log : SUCCESS in 20m 13s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/54e49ab05e1c409b94bd9ebd3bd9d653/131007_devstack_export.log : SUCCESS in 10m 11s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_percona_user_001:th-percona/fb42b3ac0c384e7fac09b097a1c4a0fe/user_001.log : SUCCESS in 17m 09s\n- real-db-upgrade_nova_mysql_user_002:th-mysql http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_mysql_user_002:th-mysql/6b14e429075948c2abdf3012e87eb188/user_002.log : SUCCESS in 16m 31s\n- real-db-upgrade_nova_percona_user_002:th-percona http://www.rcbops.com/turbo_hipster/results/23/103923/3/check/real-db-upgrade_nova_percona_user_002:th-percona/9ac0b9ff86e9433fb08931e726ca426a/user_002.log : SUCCESS in 13m 50s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/Nova/Turbo-Hipster","accounts_in_message":[],"_revision_number":3},{"id":"6aafa771dc3e02609efc6fa1263aeb7b9c7763ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-19 21:34:42.000000000","message":"Patch Set 3: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"271b17ea19842e69885877c8abb465b2e2fe009d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-19 22:29:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/23/103923/3/check/gate-nova-pep8/76b0f3d : SUCCESS in 12m 29s\n- gate-nova-docs http://docs-draft.openstack.org/23/103923/3/check/gate-nova-docs/927828e/doc/build/html/ : SUCCESS in 11m 49s\n- gate-nova-python26 http://logs.openstack.org/23/103923/3/check/gate-nova-python26/c78e607 : SUCCESS in 22m 54s\n- gate-nova-python27 http://logs.openstack.org/23/103923/3/check/gate-nova-python27/beaff85 : SUCCESS in 19m 08s\n- check-tempest-dsvm-full http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-full/e4cdf5d : SUCCESS in 50m 51s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-postgres-full/c7991f3 : SUCCESS in 47m 22s\n- check-tempest-dsvm-neutron http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-neutron/ab2a262 : SUCCESS in 54m 56s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-neutron-heat-slow/ecb19f0 : SUCCESS in 23m 51s\n- check-grenade-dsvm http://logs.openstack.org/23/103923/3/check/check-grenade-dsvm/0f37c2d : SUCCESS in 41m 07s\n- check-devstack-dsvm-cells http://logs.openstack.org/23/103923/3/check/check-devstack-dsvm-cells/2ebb172 : SUCCESS in 19m 20s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/23/103923/3/check/gate-tempest-dsvm-large-ops/d228c54 : SUCCESS in 18m 31s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/23/103923/3/check/gate-tempest-dsvm-neutron-large-ops/a5a6ca3 : SUCCESS in 17m 24s\n- gate-nova-pylint http://logs.openstack.org/23/103923/3/check/gate-nova-pylint/3cc7e45 : SUCCESS in 23m 17s (non-voting)\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/23/103923/3/check/check-grenade-dsvm-partial-ncpu/45a3fdd : SUCCESS in 34m 15s\n- check-tempest-dsvm-virtual-ironic-nv http://logs.openstack.org/23/103923/3/check/check-tempest-dsvm-virtual-ironic-nv/8b4c887 : SUCCESS in 39m 23s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"fdc9886bf50060deba66cdbeebf5813e8e880a5e","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2014-08-12 22:11:47.000000000","message":"Patch Set 3:\n\nrecheck-vmware","accounts_in_message":[],"_revision_number":3},{"id":"79123fb34bc5d2690b527f8f2ae0336dab3c5788","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-12 22:13:26.000000000","message":"Patch Set 3: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"c869055a8f2e5621385d1b64ae3eabfe3e956a84","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2014-09-24 00:04:34.000000000","message":"Patch Set 3:\n\nWe can probably abandon this now right?","accounts_in_message":[],"_revision_number":3},{"id":"63b3c2a679456d1b476d69668c9667529cf06129","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-11-20 15:18:20.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.","accounts_in_message":[],"_revision_number":3},{"id":"23cb962aabbdb87e96b376f3eeedbc5442ba658d","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-11-20 15:18:20.000000000","message":"Patch Set 3:\n\nThis review is \u003e 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"21fe678868c74f7780250d1a9de3d85d7d8dfe2c","revisions":{"fa3d493fdfd402ea5987d99edbeff16158e03807":{"kind":"REWORK","_number":1,"created":"2014-07-01 15:31:13.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/23/103923/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/23/103923/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/23/103923/1"}}},"commit":{"parents":[{"commit":"0a80b65a188a9dea854777c6aaf867c4ba55c91f","subject":"Merge \"Fake driver: remove unused method get_disk_available_least\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a80b65a188a9dea854777c6aaf867c4ba55c91f"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2014-07-01 15:30:06.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2014-07-01 15:30:06.000000000","tz":-420},"subject":"Codify a rule about new libvirt versions","message":"Codify a rule about new libvirt versions\n\nWe are occasionally asked to bring a new feature into nova that\nrequires a bleeding-edge version of libvirt. This adds a policy\nto help provide a rule of thumb for the future.\n\nChange-Id: Ib8e30d73ef7daa16009beda9bde4599bb5b14605\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fa3d493fdfd402ea5987d99edbeff16158e03807"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fa3d493fdfd402ea5987d99edbeff16158e03807"}]},"branch":"refs/heads/master"},"ff97a98d57228432773251da8b80d7cf72ce47fe":{"kind":"REWORK","_number":2,"created":"2014-07-01 17:08:15.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/23/103923/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/23/103923/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/23/103923/2"}}},"commit":{"parents":[{"commit":"0a80b65a188a9dea854777c6aaf867c4ba55c91f","subject":"Merge \"Fake driver: remove unused method get_disk_available_least\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a80b65a188a9dea854777c6aaf867c4ba55c91f"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2014-07-01 15:30:06.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2014-07-01 17:08:30.000000000","tz":-420},"subject":"Codify a rule about new libvirt versions","message":"Codify a rule about new libvirt versions\n\nWe are occasionally asked to bring a new feature into nova that\nrequires a bleeding-edge version of libvirt. This adds a policy\nto help provide a rule of thumb for the future.\n\nChange-Id: Ib8e30d73ef7daa16009beda9bde4599bb5b14605\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ff97a98d57228432773251da8b80d7cf72ce47fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ff97a98d57228432773251da8b80d7cf72ce47fe"}]},"branch":"refs/heads/master"},"21fe678868c74f7780250d1a9de3d85d7d8dfe2c":{"kind":"REWORK","_number":3,"created":"2014-07-15 14:04:23.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/23/103923/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/23/103923/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/23/103923/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/23/103923/3"}}},"commit":{"parents":[{"commit":"0a80b65a188a9dea854777c6aaf867c4ba55c91f","subject":"Merge \"Fake driver: remove unused method get_disk_available_least\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a80b65a188a9dea854777c6aaf867c4ba55c91f"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2014-07-01 15:30:06.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2014-07-15 14:01:09.000000000","tz":-420},"subject":"Codify a rule about new hypervisor features","message":"Codify a rule about new hypervisor features\n\nThis adds specific verbiage to the policies file about new\nhypervisor features requiring functional testing. We often add or\napprove new virt features without requiring functional testing.\nSpecifically for libvirt, this has broken us in the past when we\nadd a new feature that requires a newer libvirt than we test with,\nand we discover that it\u0027s totally broken when we upgrade in the\ngate.\n\nChange-Id: Ib8e30d73ef7daa16009beda9bde4599bb5b14605\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/21fe678868c74f7780250d1a9de3d85d7d8dfe2c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/21fe678868c74f7780250d1a9de3d85d7d8dfe2c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}