)]}'
{"nova/virt/vmwareapi/ds_util.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"31c33606e56851bd48b233e7e10b8d31dd07d2db","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    search_spec.matchPattern \u003d [file_name]"},{"line_number":372,"context_line":"    return search_spec"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def file_exists(session, ds_browser, ds_path, file_name):"},{"line_number":376,"context_line":"    \"\"\"Check if the file exists on the datastore.\"\"\""},{"line_number":377,"context_line":"    client_factory \u003d session._get_vim().client.factory"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3b0631cf","line":374,"updated":"2014-07-02 11:40:03.000000000","message":"I think we need to fix this function to accept DatastorePath in order to complete the refactoring of ds_util.py. This could be done as part of this patch or in another patch based on this one. However, I think it should be done before the rest of the changes for spawn() refactor.","commit_id":"4d8ad425ab8fe89f1620787e2bcef2fc281d3a2a"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"20ca6a7f590635143c508af047147414791adc76","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    search_spec.matchPattern \u003d [file_name]"},{"line_number":372,"context_line":"    return search_spec"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def file_exists(session, ds_browser, ds_path, file_name):"},{"line_number":376,"context_line":"    \"\"\"Check if the file exists on the datastore.\"\"\""},{"line_number":377,"context_line":"    client_factory \u003d session._get_vim().client.factory"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1fd86b52","line":374,"in_reply_to":"baada198_3b0631cf","updated":"2014-07-02 16:37:56.000000000","message":"Good point, will do.","commit_id":"4d8ad425ab8fe89f1620787e2bcef2fc281d3a2a"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"b13fed72a014df578c3a3931c8eea3b5727c3be8","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    return search_spec"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def file_exists(session, ds_browser, ds_path, file_name):"},{"line_number":376,"context_line":"    \"\"\"Check if the file exists on the datastore.\"\"\""},{"line_number":377,"context_line":"    client_factory \u003d session._get_vim().client.factory"},{"line_number":378,"context_line":"    search_spec \u003d search_datastore_spec(client_factory, file_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_39b7abf6","line":375,"updated":"2014-07-07 06:48:29.000000000","message":"I\u0027d prefer this function to accept only ds_path instead of ds_path+file_name. It\u0027s both confusing and inconsistent right now. But it is something that can be addressed in a separate patch.","commit_id":"f9bc4ab0aa420389ed44977942415b901fe5291f"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"31c33606e56851bd48b233e7e10b8d31dd07d2db","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                error_util.FileNotFoundException):"},{"line_number":148,"context_line":"            LOG.debug(\"Unable to delete %(ds)s. There may be more than \""},{"line_number":149,"context_line":"                      \"one process or thread trying to delete the file\","},{"line_number":150,"context_line":"                      {\u0027ds\u0027: str(datastore_path)},"},{"line_number":151,"context_line":"                      exc_info\u003dTrue)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _get_vmdk_path(self, ds_name, folder, name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1b5ecd12","line":150,"updated":"2014-07-02 11:40:03.000000000","message":"hm, is it necessary to use str() here? you don\u0027t use it in another places like imagecache.py:75","commit_id":"4d8ad425ab8fe89f1620787e2bcef2fc281d3a2a"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"20ca6a7f590635143c508af047147414791adc76","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                error_util.FileNotFoundException):"},{"line_number":148,"context_line":"            LOG.debug(\"Unable to delete %(ds)s. There may be more than \""},{"line_number":149,"context_line":"                      \"one process or thread trying to delete the file\","},{"line_number":150,"context_line":"                      {\u0027ds\u0027: str(datastore_path)},"},{"line_number":151,"context_line":"                      exc_info\u003dTrue)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _get_vmdk_path(self, ds_name, folder, name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_7ffa47be","line":150,"in_reply_to":"baada198_1b5ecd12","updated":"2014-07-02 16:37:56.000000000","message":"Nope, I missed taking out that one.","commit_id":"4d8ad425ab8fe89f1620787e2bcef2fc281d3a2a"}]}