)]}'
{"nova/tests/test_iscsi.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"549b4aa58646857c4ee0a79251c771f6f8793981","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        TargetAdminTestCase.setUp(self)"},{"line_number":85,"context_line":"        self.flags(iscsi_helper\u003d\u0027tgtadm\u0027)"},{"line_number":86,"context_line":"        self.script_template \u003d \"\\n\".join(["},{"line_number":87,"context_line":"        \"tgtadm --op show --lld\u003discsi --mode\u003dtarget --tid\u003d%(tid)s\"])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_script_params(self):"},{"line_number":90,"context_line":"        params \u003d super(TgtAdmTestCase, self).get_script_params()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F%2BLA%3D","line":87,"updated":"2012-07-27 17:21:05.000000000","message":"you will probably need to add more expected things here as well once you make the other changes.","commit_id":"29550ed211397ec9e47b9288e5164ad56718829b"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"06176f24f4b6c6e70f23f30670002bcd51f222c9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        TargetAdminTestCase.setUp(self)"},{"line_number":85,"context_line":"        self.flags(iscsi_helper\u003d\u0027tgtadm\u0027)"},{"line_number":86,"context_line":"        self.script_template \u003d \"\\n\".join(["},{"line_number":87,"context_line":"        \"tgtadm --op show --lld\u003discsi --mode\u003dtarget --tid\u003d%(tid)s\"])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def get_script_params(self):"},{"line_number":90,"context_line":"        params \u003d super(TgtAdmTestCase, self).get_script_params()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F%2BFo%3D","line":87,"in_reply_to":"AAAALH%2F%2F%2BLA%3D","updated":"2012-07-27 19:28:48.000000000","message":"Done","commit_id":"29550ed211397ec9e47b9288e5164ad56718829b"}],"nova/volume/iscsi.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"549b4aa58646857c4ee0a79251c771f6f8793981","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                f.write(volume_conf)"},{"line_number":118,"context_line":"                f.close()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            utils.execute(\u0027tgt-admin\u0027, \u0027--conf %s\u0027 % volume_path,"},{"line_number":121,"context_line":"                \u0027--update %s\u0027 % vol_id, run_as_root\u003dTrue,"},{"line_number":122,"context_line":"                check_exit_code\u003d[0, 1])"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F%2BLI%3D","line":120,"updated":"2012-07-27 17:21:05.000000000","message":"i think you need to change this to self._execute so it is mocked in the test.","commit_id":"29550ed211397ec9e47b9288e5164ad56718829b"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"06176f24f4b6c6e70f23f30670002bcd51f222c9","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                f.write(volume_conf)"},{"line_number":118,"context_line":"                f.close()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            utils.execute(\u0027tgt-admin\u0027, \u0027--conf %s\u0027 % volume_path,"},{"line_number":121,"context_line":"                \u0027--update %s\u0027 % vol_id, run_as_root\u003dTrue,"},{"line_number":122,"context_line":"                check_exit_code\u003d[0, 1])"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F%2BFw%3D","line":120,"in_reply_to":"AAAALH%2F%2F%2BLI%3D","updated":"2012-07-27 19:28:48.000000000","message":"Done","commit_id":"29550ed211397ec9e47b9288e5164ad56718829b"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"549b4aa58646857c4ee0a79251c771f6f8793981","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            volume_path \u003d os.path.abspath(\u0027%s/%s\u0027"},{"line_number":133,"context_line":"                            % (FLAGS.volumes_dir, vol_id))"},{"line_number":134,"context_line":"            if os.path.isfile(volume_path):"},{"line_number":135,"context_line":"                utils.execute(\u0027tgt-admin\u0027, \u0027--conf %s\u0027 % volume_path,"},{"line_number":136,"context_line":"                    \u0027--delete %s\u0027 % vol_id, run_as_root\u003dTrue,"},{"line_number":137,"context_line":"                    check_exit_code\u003d[0, 1])"},{"line_number":138,"context_line":"                os.unlink(volume_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F%2BLE%3D","line":135,"updated":"2012-07-27 17:21:05.000000000","message":"ditto","commit_id":"29550ed211397ec9e47b9288e5164ad56718829b"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"06176f24f4b6c6e70f23f30670002bcd51f222c9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            volume_path \u003d os.path.abspath(\u0027%s/%s\u0027"},{"line_number":133,"context_line":"                            % (FLAGS.volumes_dir, vol_id))"},{"line_number":134,"context_line":"            if os.path.isfile(volume_path):"},{"line_number":135,"context_line":"                utils.execute(\u0027tgt-admin\u0027, \u0027--conf %s\u0027 % volume_path,"},{"line_number":136,"context_line":"                    \u0027--delete %s\u0027 % vol_id, run_as_root\u003dTrue,"},{"line_number":137,"context_line":"                    check_exit_code\u003d[0, 1])"},{"line_number":138,"context_line":"                os.unlink(volume_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F%2BFs%3D","line":135,"in_reply_to":"AAAALH%2F%2F%2BLE%3D","updated":"2012-07-27 19:28:48.000000000","message":"Done","commit_id":"29550ed211397ec9e47b9288e5164ad56718829b"}]}