)]}'
{"nova/tests/test_virt_drivers.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"591811245fa320da176b7f7ab975668559f9a5ce","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        super(FakeConnectionTestCase, self).setUp()"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"class LibvirtConnTestCase(_VirtDriverTestCase):"},{"line_number":502,"context_line":"    def setUp(self):"},{"line_number":503,"context_line":"        # Put fakelibvirt in place"},{"line_number":504,"context_line":"        if \u0027libvirt\u0027 in sys.modules:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2F6g%3D","line":501,"updated":"2011-11-09 03:51:11.000000000","message":"This is now causing libxml2 to be required. Should pip-requires be updated or a check for import ability of it.\n\n\nERROR: test_agent_update (nova.tests.test_virt_drivers.LibvirtConnTestCase)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n  File \"/home/jkoelker/openstack/nova/nova/tests/test_virt_drivers.py\", line 523, in setUp\n    super(LibvirtConnTestCase, self).setUp()\n  File \"/home/jkoelker/openstack/nova/nova/tests/test_virt_drivers.py\", line 60, in setUp\n    self.connection \u003d self.driver_module.get_connection(\u0027\u0027)\n  File \"/home/jkoelker/openstack/nova/nova/virt/libvirt/connection.py\", line 163, in get_connection\n    libxml2 \u003d __import__(\u0027libxml2\u0027)\nImportError: No module named libxml2","commit_id":"0c4466fb4573c51b25abdb961ef19761e5d894d9"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"591811245fa320da176b7f7ab975668559f9a5ce","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#    All Rights Reserved."},{"line_number":6,"context_line":"#    Copyright (c) 2010 Citrix Systems, Inc."},{"line_number":7,"context_line":"#    Copyright (c) 2011 Piston Cloud Computing, Inc"},{"line_number":8,"context_line":"#    Copyright (c) 2011 OpenStack LLC"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":11,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2F6k%3D","line":8,"updated":"2011-11-09 03:51:11.000000000","message":"Since this is a new file isn\u0027t just the OpenStack line needed?","commit_id":"0c4466fb4573c51b25abdb961ef19761e5d894d9"},{"author":{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},"change_message_id":"74f3869ab39c6cebd2018dfab542437c8d86af26","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#    All Rights Reserved."},{"line_number":6,"context_line":"#    Copyright (c) 2010 Citrix Systems, Inc."},{"line_number":7,"context_line":"#    Copyright (c) 2011 Piston Cloud Computing, Inc"},{"line_number":8,"context_line":"#    Copyright (c) 2011 OpenStack LLC"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":11,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2F3c%3D","line":8,"in_reply_to":"AAAACn%2F%2F%2F6k%3D","updated":"2011-11-10 09:51:26.000000000","message":"No.\n\nIt\u0027s based off of code where the above copyrights apply, so they need to be kept.","commit_id":"0c4466fb4573c51b25abdb961ef19761e5d894d9"},{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"591811245fa320da176b7f7ab975668559f9a5ce","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    :param path: File to read"},{"line_number":175,"context_line":"    \"\"\""},{"line_number":176,"context_line":"    with open(path, \u0027r+\u0027) as fp:"},{"line_number":177,"context_line":"        return fp.read()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"def file_open(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2F6s%3D","line":177,"updated":"2011-11-09 03:51:11.000000000","message":"I would suggest adding in a note that these are stub points so people don\u0027t initially WTF (like I did) when they see these ;).","commit_id":"0c4466fb4573c51b25abdb961ef19761e5d894d9"},{"author":{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},"change_message_id":"74f3869ab39c6cebd2018dfab542437c8d86af26","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    :param path: File to read"},{"line_number":175,"context_line":"    \"\"\""},{"line_number":176,"context_line":"    with open(path, \u0027r+\u0027) as fp:"},{"line_number":177,"context_line":"        return fp.read()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"def file_open(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F%2F3Y%3D","line":177,"in_reply_to":"AAAACn%2F%2F%2F6s%3D","updated":"2011-11-10 09:51:26.000000000","message":"Fair point. I\u0027ll elaborate on their purpose in the docstring.","commit_id":"0c4466fb4573c51b25abdb961ef19761e5d894d9"}]}