)]}'
{"nova/virt/firewall.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"7feba82c2181ada525ed690d594fa317ad9a2d65","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        ipv4_rules, ipv6_rules \u003d self.instance_rules(instance, network_info)"},{"line_number":181,"context_line":"        self.add_filters_for_instance(instance, network_info, ipv4_rules,"},{"line_number":182,"context_line":"                                      ipv6_rules)"},{"line_number":183,"context_line":"        LOG.debug(\u0027Filters added to instance: %s\u0027 % instance[\u0027id\u0027],"},{"line_number":184,"context_line":"                  instance\u003dinstance)"},{"line_number":185,"context_line":"        self.refresh_provider_fw_rules()"},{"line_number":186,"context_line":"        LOG.debug(\u0027Provider Firewall Rules refreshed: %s\u0027 % instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1cd3f504","line":183,"updated":"2014-07-03 12:15:59.000000000","message":"Why you use %s here? I think it\u0027s better to use:\n\n LOG.debug(\u0027Filters added to instance: %s\u0027, instance[\u0027id\u0027], instance\u003dinstance)","commit_id":"f909e0e8f03bf833c24a31340d38544a7f976542"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"7feba82c2181ada525ed690d594fa317ad9a2d65","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                  instance\u003dinstance)"},{"line_number":185,"context_line":"        self.refresh_provider_fw_rules()"},{"line_number":186,"context_line":"        LOG.debug(\u0027Provider Firewall Rules refreshed: %s\u0027 % instance[\u0027id\u0027],"},{"line_number":187,"context_line":"                  instance\u003dinstance)"},{"line_number":188,"context_line":"        # Ensure that DHCP request rule is updated if necessary"},{"line_number":189,"context_line":"        if (self.dhcp_create and not self.dhcp_created):"},{"line_number":190,"context_line":"            self.iptables.ipv4[\u0027filter\u0027].add_rule("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9c062585","line":187,"updated":"2014-07-03 12:15:59.000000000","message":"same","commit_id":"f909e0e8f03bf833c24a31340d38544a7f976542"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"7feba82c2181ada525ed690d594fa317ad9a2d65","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        ipv4_rules +\u003d [\u0027-j $sg-fallback\u0027]"},{"line_number":419,"context_line":"        ipv6_rules +\u003d [\u0027-j $sg-fallback\u0027]"},{"line_number":420,"context_line":"        LOG.debug(\u0027Security Groups %s translated to ipv4: %r, ipv6: %r\u0027 % ("},{"line_number":421,"context_line":"            security_groups, ipv4_rules, ipv6_rules), instance\u003dinstance)"},{"line_number":422,"context_line":"        return ipv4_rules, ipv6_rules"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def instance_filter_exists(self, instance, network_info):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_fc01e16a","line":421,"updated":"2014-07-03 12:15:59.000000000","message":"same","commit_id":"f909e0e8f03bf833c24a31340d38544a7f976542"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a99e169f8815a4704830da345840545941b60415","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        LOG.debug(\u0027Filters added to instance: %s\u0027 % instance[\u0027id\u0027],"},{"line_number":184,"context_line":"                  instance\u003dinstance)"},{"line_number":185,"context_line":"        self.refresh_provider_fw_rules()"},{"line_number":186,"context_line":"        LOG.debug(\u0027Provider Firewall Rules refreshed: %s\u0027 % instance[\u0027id\u0027],"},{"line_number":187,"context_line":"                  instance\u003dinstance)"},{"line_number":188,"context_line":"        # Ensure that DHCP request rule is updated if necessary"},{"line_number":189,"context_line":"        if (self.dhcp_create and not self.dhcp_created):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_7b857758","line":186,"updated":"2014-07-07 17:04:41.000000000","message":"Sorry to nit-pick, but please use a comma instead of a percent...","commit_id":"1a400748a054614412cdec00374d996f675b9081"}]}
