)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"a7e2deb90ed1f80fac5015d5d3bf244d5dfff472","unresolved":false,"context_lines":[{"line_number":3747,"context_line":"            except libvirt.libvirtError as e:"},{"line_number":3748,"context_line":"                LOG.warn(_LW(\"couldn\u0027t obtain the XML from domain:\""},{"line_number":3749,"context_line":"                             \" %(uuid)s, exception: %(ex)s\") %"},{"line_number":3750,"context_line":"                         {\"uuid\": dom.UUIDString(), \"ex\": e})"},{"line_number":3751,"context_line":"            except Exception:"},{"line_number":3752,"context_line":"                continue"},{"line_number":3753,"context_line":"            ret \u003d doc.findall(\u0027./devices/disk\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8bc8a123","line":3750,"updated":"2014-07-11 08:09:17.000000000","message":"Slight worry - will a libvirt error now make us think a block device is unused?\n\nYou also lost the continue here","commit_id":"0ea985b25192d846bf17ce8b55918496e9e64107"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0180d1a6c042326db333e31e617ab03fe3780cb0","unresolved":false,"context_lines":[{"line_number":3747,"context_line":"            except libvirt.libvirtError as e:"},{"line_number":3748,"context_line":"                LOG.warn(_LW(\"couldn\u0027t obtain the XML from domain:\""},{"line_number":3749,"context_line":"                             \" %(uuid)s, exception: %(ex)s\") %"},{"line_number":3750,"context_line":"                         {\"uuid\": dom.UUIDString(), \"ex\": e})"},{"line_number":3751,"context_line":"            except Exception:"},{"line_number":3752,"context_line":"                continue"},{"line_number":3753,"context_line":"            ret \u003d doc.findall(\u0027./devices/disk\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7df6a190","line":3750,"in_reply_to":"baada198_8bc8a123","updated":"2014-07-11 15:11:07.000000000","message":"I added the catch of libvirt error to deal with the case where the guest shuts down between time we list domains and time we query the XML. Even if we didn\u0027t catch it, we already have the generic \u0027except Exception\u0027 on the following line that would catch \u0026 ignore it","commit_id":"0ea985b25192d846bf17ce8b55918496e9e64107"}]}