)]}'
{"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9e7d596b3547b4024517aebfddd1cf0712c62a0c","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                                  self.fake_image_uuid,"},{"line_number":684,"context_line":"                                  \u0027%s.iso\u0027 % self.fake_image_uuid),"},{"line_number":685,"context_line":"            ds_util.DatastorePath(self.ds, \u0027fake-config-drive\u0027)]"},{"line_number":686,"context_line":"        self.iso_index \u003d 0"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        def fake_create_config_drive(instance, injected_files, password,"},{"line_number":689,"context_line":"                                     data_store_name, folder, uuid, cookies):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_b74189a8","line":686,"updated":"2014-08-06 16:37:55.000000000","message":"Should this be converted as well?","commit_id":"d79bcf06187b878da0f3236333077b99fb7123d1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"37794f489b91f766c8b6a604c9f0a2ff369f9e6a","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                                  self.fake_image_uuid,"},{"line_number":684,"context_line":"                                  \u0027%s.iso\u0027 % self.fake_image_uuid),"},{"line_number":685,"context_line":"            ds_util.DatastorePath(self.ds, \u0027fake-config-drive\u0027)]"},{"line_number":686,"context_line":"        self.iso_index \u003d 0"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        def fake_create_config_drive(instance, injected_files, password,"},{"line_number":689,"context_line":"                                     data_store_name, folder, uuid, cookies):"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_f9ee7eb5","line":686,"in_reply_to":"baada198_b74189a8","updated":"2014-08-07 09:23:30.000000000","message":"Not in this case, because iso_index is modified by fake_attach_cdrom below, and closed variables are immutable in python:\n\n\u003e\u003e\u003e def foo(i):\n...   def bar():\n...     return i\n...   return bar\n... \n\u003e\u003e\u003e x \u003d foo(1)\n\u003e\u003e\u003e x()\n1\n\u003e\u003e\u003e def foo(i):\n...   def bar():\n...     i +\u003d 1\n...     return i\n...   return bar\n... \n\u003e\u003e\u003e x \u003d foo(1)\n\u003e\u003e\u003e x()\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"\u003cstdin\u003e\", line 3, in bar\nUnboundLocalError: local variable \u0027i\u0027 referenced before assignment\n\nWeird, huh? Not even a proper error message. Anyway, while the variable itself it immutable, whatever it points to isn\u0027t:\n\n\u003e\u003e\u003e def foo(i):\n...   j \u003d [i]\n...   def bar():\n...     j[0] +\u003d 1\n...     return j[0]\n...   return bar\n... \n\u003e\u003e\u003e x \u003d foo(1)\n\u003e\u003e\u003e x()\n2\n\u003e\u003e\u003e x()\n3\n\nNasty.","commit_id":"d79bcf06187b878da0f3236333077b99fb7123d1"}]}