)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"8d25f74817aea6fc7b88782f7433646a5dc721bd","unresolved":false,"context_lines":[{"line_number":2427,"context_line":"        # NOTE(vish): The mapping is passed in so the driver can disconnect"},{"line_number":2428,"context_line":"        #             from remote volumes if necessary"},{"line_number":2429,"context_line":"        block_device_info \u003d self._get_instance_volume_block_device_info("},{"line_number":2430,"context_line":"                            context, instance[\u0027id\u0027])"},{"line_number":2431,"context_line":"        self.driver.destroy(instance, self._legacy_nw_info(network_info),"},{"line_number":2432,"context_line":"                            block_device_info)"},{"line_number":2433,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2F8jQ%3D","line":2430,"updated":"2012-07-31 00:08:18.000000000","message":"Ummm, this method takes a uuid (according to its signature, and tracking it all the way back to the db api). I know this code originally passed an instance id, but that\u0027s a bug as best as I can see.\n\nDo you want to fix that here, or do you want me to fix it in a separate review?","commit_id":"227ee0d8c89249c08fb2090391c412d737971f59"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"08a49574937d7aad8bf4daccbdb5f0ec836f7412","unresolved":false,"context_lines":[{"line_number":2427,"context_line":"        # NOTE(vish): The mapping is passed in so the driver can disconnect"},{"line_number":2428,"context_line":"        #             from remote volumes if necessary"},{"line_number":2429,"context_line":"        block_device_info \u003d self._get_instance_volume_block_device_info("},{"line_number":2430,"context_line":"                            context, instance[\u0027id\u0027])"},{"line_number":2431,"context_line":"        self.driver.destroy(instance, self._legacy_nw_info(network_info),"},{"line_number":2432,"context_line":"                            block_device_info)"},{"line_number":2433,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2F8jA%3D","line":2430,"in_reply_to":"AAAALH%2F%2F8jQ%3D","updated":"2012-07-31 00:10:48.000000000","message":"Nice catch.  Let\u0027s fix it separately if you don\u0027t mind.  If there\u0027s a chance it might receive either a UUID or an ID, and in both cases it specifies it as \"instance_id\", we can make the code determine if it\u0027s a UUID or not and act accordingly using utils.is_uuid_like() or whatever it is.","commit_id":"227ee0d8c89249c08fb2090391c412d737971f59"}]}