)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a97b74dff2219f35ebe1cc50eaaa42ce4d5f7a65","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shuangtai \u003cshuangtai.tian@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-16 11:25:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise exception when resize to zero disk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When old flavor\u0027s root_gb is not equal 0 and new flavor\u0027s root_gb is 0,"},{"line_number":10,"context_line":"the resize() in nova.compute.api will raise CannotResizeDisk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_9855e6c3","line":7,"updated":"2014-07-22 04:12:07.000000000","message":"When I saw this title at first time, I was a little confused because this patch does not add any raised exceptions.\nBasically, it is better that the title describes what this patch does. In this case, \"Catch an exception when resize to zero disk\" or something.","commit_id":"78b4a2090b9094bfeb27819edcacf4c7afac67bc"}],"nova/compute/api.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"3e75a284bfdd69f17a15a376fba7ae11f1aea054","unresolved":false,"context_lines":[{"line_number":2391,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":2392,"context_line":""},{"line_number":2393,"context_line":"        if not new_instance_type:"},{"line_number":2394,"context_line":"            raise exception.FlavorNotFound(flavor_id\u003dflavor_id)"},{"line_number":2395,"context_line":""},{"line_number":2396,"context_line":"        current_instance_type_name \u003d current_instance_type[\u0027name\u0027]"},{"line_number":2397,"context_line":"        new_instance_type_name \u003d new_instance_type[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_bdfffc64","line":2394,"updated":"2014-07-15 09:46:50.000000000","message":"Could you please add an api test for this exception too?","commit_id":"107ba381cea490adbeeb991e53b2f4f35ececadc"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"e25457ed0aa9015f7dee837a9deebb14bb695546","unresolved":false,"context_lines":[{"line_number":2391,"context_line":"                raise exception.CannotResizeDisk(reason\u003dreason)"},{"line_number":2392,"context_line":""},{"line_number":2393,"context_line":"        if not new_instance_type:"},{"line_number":2394,"context_line":"            raise exception.FlavorNotFound(flavor_id\u003dflavor_id)"},{"line_number":2395,"context_line":""},{"line_number":2396,"context_line":"        current_instance_type_name \u003d current_instance_type[\u0027name\u0027]"},{"line_number":2397,"context_line":"        new_instance_type_name \u003d new_instance_type[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_dff63dd8","line":2394,"in_reply_to":"baada198_bdfffc64","updated":"2014-07-16 05:56:10.000000000","message":"Done, thanks","commit_id":"107ba381cea490adbeeb991e53b2f4f35ececadc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a97b74dff2219f35ebe1cc50eaaa42ce4d5f7a65","unresolved":false,"context_lines":[{"line_number":2407,"context_line":"                  instance\u003dinstance)"},{"line_number":2408,"context_line":""},{"line_number":2409,"context_line":"        if not new_instance_type:"},{"line_number":2410,"context_line":"            raise exception.FlavorNotFound(flavor_id\u003dflavor_id)"},{"line_number":2411,"context_line":""},{"line_number":2412,"context_line":"        same_instance_type \u003d (current_instance_type[\u0027id\u0027] \u003d\u003d"},{"line_number":2413,"context_line":"                              new_instance_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_985406ff","side":"PARENT","line":2410,"updated":"2014-07-22 04:12:07.000000000","message":"nice catch :-)","commit_id":"bf3fa0686e4fdfd13cc96502db4e263d701aba94"}],"nova/tests/api/openstack/compute/plugins/v3/test_migrate_server.py":[{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"42feef92193f6a8b73ec0826093965fe6dbef061","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    @mock.patch(\u0027nova.api.openstack.common.get_instance\u0027)"},{"line_number":75,"context_line":"    def test_resize_raises_cannot_resize_disk(self, moc_resize, get_instance):"},{"line_number":76,"context_line":"        get_instance.return_value \u003d None"},{"line_number":77,"context_line":"        body \u003d dict(resize\u003ddict(flavor_ref\u003d\"http://localhost/3\"))"},{"line_number":78,"context_line":"        FAKE_UUID \u003d fakes.FAKE_UUID"},{"line_number":79,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/servers/%s/action\u0027 % FAKE_UUID)"},{"line_number":80,"context_line":"        self.assertRaises(webob.exc.HTTPConflict,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a8b9fc2f","line":77,"updated":"2014-07-10 20:32:29.000000000","message":"So if I have this right... body is really supposed to be \u0027{\"migrate\": null}\u0027, but because you call _migrate directly which doesn\u0027t check this the test is passing.\n\nIt seems like we should correct this regardless of whether the test is passing or not.","commit_id":"3f05df5593105d0c88bda3e12359b6e9ceae2bbd"},{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"4d4dccf53ebb680390ef5ea94064f1c0fd3e27e0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    @mock.patch(\u0027nova.api.openstack.common.get_instance\u0027)"},{"line_number":75,"context_line":"    def test_resize_raises_cannot_resize_disk(self, moc_resize, get_instance):"},{"line_number":76,"context_line":"        get_instance.return_value \u003d None"},{"line_number":77,"context_line":"        body \u003d dict(resize\u003ddict(flavor_ref\u003d\"http://localhost/3\"))"},{"line_number":78,"context_line":"        FAKE_UUID \u003d fakes.FAKE_UUID"},{"line_number":79,"context_line":"        req \u003d fakes.HTTPRequestV3.blank(\u0027/servers/%s/action\u0027 % FAKE_UUID)"},{"line_number":80,"context_line":"        self.assertRaises(webob.exc.HTTPConflict,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d585dd59","line":77,"in_reply_to":"baada198_a8b9fc2f","updated":"2014-07-11 01:04:47.000000000","message":"@Christopher,  you are right, I only want to let the resize raise error. I think again, I found it\u0027s not necessary, when migrate, the new flavor is the equal old flavor. So, the \nerror would not happen.\n\nthanks!","commit_id":"3f05df5593105d0c88bda3e12359b6e9ceae2bbd"}]}