)]}'
{"nova/virt/netutils.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"f1eb59747c204d2ca06ee5b337bcd9fd39cc5081","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    :param template: Path to the interfaces template file."},{"line_number":71,"context_line":"    :param virt_type: If we\u0027re using Libvirt, then the `virt_type` can be"},{"line_number":72,"context_line":"        relevant since LXC requires working around /proc/sys/net not being"},{"line_number":73,"context_line":"        writable"},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":"    if not (network_info and template):"},{"line_number":76,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c50a36d1","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":16},"updated":"2014-07-14 16:25:08.000000000","message":"Should we call this libvirt_virt_type instead to be explicit?\n\nAlso, While we are using this for LXC now I\u0027m not sure the param description here needs to explicitly state that. Perhaps just state that the virt_type is a pass through parameter that is exposed to the template should custom decisions need to be made. What you are saying here applies more specifically to the interfaces template... and not so much this function right?","commit_id":"94246a725f8c769b6f0afd8e932065063686be8c"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"1e00f16e0913d8f6250154b55363888fd767b03b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    :param template: Path to the interfaces template file."},{"line_number":71,"context_line":"    :param virt_type: If we\u0027re using Libvirt, then the `virt_type` can be"},{"line_number":72,"context_line":"        relevant since LXC requires working around /proc/sys/net not being"},{"line_number":73,"context_line":"        writable"},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":"    if not (network_info and template):"},{"line_number":76,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d6e66aaf","line":73,"in_reply_to":"baada198_c50a36d1","updated":"2014-07-14 18:06:07.000000000","message":"You\u0027re right that `virt_type` is specific to Libvirt, but, for the sake of consistency I\u0027d hate to change the name.\n\nIt\u0027d make the code less greppable if it\u0027s referred to as `libvirt_virt_type` in places and `virt_type` in others. There\u0027s no naming collision right now, so I sort of feel like consistency would be worth it.\n\nThat\u0027s why I made the param documentation in the docstring mention Libvirt+LXC, to clear up any confusion with other virt-driver users that this param was, at least right now, only usable for Libvirt.\n\nI\u0027ll tweak the doc string a bit to be less specific to the particular use-case that introduced the param, and more a general statement as to what it does.","commit_id":"94246a725f8c769b6f0afd8e932065063686be8c"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"eb3637de7b27220a0e76f35480c2e4bc5f671bb8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        even if an IPv6 subnet is present in network_info."},{"line_number":70,"context_line":"    :param template: Path to the interfaces template file."},{"line_number":71,"context_line":"    :param virt_type: The Libvirt `virt_type`, will be `None` for other"},{"line_number":72,"context_line":"        hypervisors.."},{"line_number":73,"context_line":"    \"\"\""},{"line_number":74,"context_line":"    if not (network_info and template):"},{"line_number":75,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_9eff8f65","line":72,"updated":"2014-07-15 10:41:28.000000000","message":"This method is interesting to me. Its only called by the libvirt hypervisor driver and the metadata server -- everyone else does this in a different way.\n\nRegardless, I feel like we should either pass values here which are meaningful in other hypervisors, or make it more clear that the meaning is for libvirt... So perhaps prepending \"libvirt_\" to the values passed here would be sufficient.","commit_id":"8b2ceecf81b292b92e3f906f6d5f76b6c5b791e5"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"ed143ee46c3ad115019e631c8dfe5244653a4fdc","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        even if an IPv6 subnet is present in network_info."},{"line_number":70,"context_line":"    :param template: Path to the interfaces template file."},{"line_number":71,"context_line":"    :param virt_type: The Libvirt `virt_type`, will be `None` for other"},{"line_number":72,"context_line":"        hypervisors.."},{"line_number":73,"context_line":"    \"\"\""},{"line_number":74,"context_line":"    if not (network_info and template):"},{"line_number":75,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_19970eed","line":72,"in_reply_to":"baada198_9eff8f65","updated":"2014-07-15 14:41:03.000000000","message":"Dependent patch https://review.openstack.org/#/c/106409/ refactors XenAPI to use the same method.\n\nSo Dan Prince brought up the same point about prefixing with `libvirt_`.\n\nI know I\u0027m now arguing two-against-one, but I still prefer `virt_type` here as it\u0027s consistent/greppable--and if there is any confusion, the docstring reminds you that it\u0027s just libvirt.\n\nI totally agree that it feels a little wrong though, the practical grepability benefit is a win though.\n\nAll that said, if you feel or Dan feel particularly strongly about this, I\u0027ll make the fixup.","commit_id":"8b2ceecf81b292b92e3f906f6d5f76b6c5b791e5"}]}