)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ffe8b86022bc7500576f3316b447a517b4ef6210","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Find our local list of acceptable hosts by repeatedly"},{"line_number":247,"context_line":"        # filtering and weighing our options. Each time we choose a"},{"line_number":248,"context_line":"        # host, we virtually consume resources on it so subsequent"},{"line_number":249,"context_line":"        # selections can adjust accordingly."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        # Note: remember, we are using an iterator here. So only"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3370aaa3","side":"PARENT","line":248,"updated":"2014-07-14 09:50:44.000000000","message":"You might improve the comment by changing \"host\" above to \"HostState object\"","commit_id":"97b667d651b6ed543c6a11955b05fb5e2c5d0b49"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"598d4db85aa427fbf6d64c54ea84ad29be91fd7d","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            selected_hosts.append(chosen_host)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            # Now consume the resources so the filter/weights"},{"line_number":285,"context_line":"            # will change for the next instance."},{"line_number":286,"context_line":"            chosen_host.obj.consume_from_instance(instance_properties)"},{"line_number":287,"context_line":"            if update_group_hosts is True:"},{"line_number":288,"context_line":"                filter_properties[\u0027group_hosts\u0027].add(chosen_host.obj.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_07ee07ed","line":285,"updated":"2014-07-14 08:39:32.000000000","message":"here, we did consume the resource and do some update\nI didn\u0027t see why we need remove that comments ...","commit_id":"a1d9e17af9335a1bb12d196e2eb9a7aa95172ce6"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"a25d5bd943e51daf1ede16918ec22ba00b859715","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            selected_hosts.append(chosen_host)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            # Now consume the resources so the filter/weights"},{"line_number":285,"context_line":"            # will change for the next instance."},{"line_number":286,"context_line":"            chosen_host.obj.consume_from_instance(instance_properties)"},{"line_number":287,"context_line":"            if update_group_hosts is True:"},{"line_number":288,"context_line":"                filter_properties[\u0027group_hosts\u0027].add(chosen_host.obj.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_706a181b","line":285,"in_reply_to":"baada198_07ee07ed","updated":"2014-07-14 09:43:34.000000000","message":"Yep agreed, this is a clever (albeit racy and hacky) way to have as accurate idea of compute resources as we can when scheduling more than one instance in the same request.\n\nWe do not need to remove the comment","commit_id":"a1d9e17af9335a1bb12d196e2eb9a7aa95172ce6"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"532260f9df32a6781098419a844025b1286a40ec","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            selected_hosts.append(chosen_host)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            # Now consume the resources so the filter/weights"},{"line_number":285,"context_line":"            # will change for the next instance."},{"line_number":286,"context_line":"            chosen_host.obj.consume_from_instance(instance_properties)"},{"line_number":287,"context_line":"            if update_group_hosts is True:"},{"line_number":288,"context_line":"                filter_properties[\u0027group_hosts\u0027].add(chosen_host.obj.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_5fccfe35","line":285,"in_reply_to":"baada198_706a181b","updated":"2014-08-18 01:52:22.000000000","message":"The comment is misleading - it dates from when we *did* perform the claim in the scheduler. We update *this* schedulers *in-memory* tracker. I can tweak the comment more if you like.","commit_id":"a1d9e17af9335a1bb12d196e2eb9a7aa95172ce6"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"c7559a01caa9a10097e121d92370d001ffbce9a9","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Find our local list of acceptable hosts by repeatedly"},{"line_number":247,"context_line":"        # filtering and weighing our options. Each time we choose a"},{"line_number":248,"context_line":"        # host, we virtually consume resources on it so subsequent"},{"line_number":249,"context_line":"        # selections can adjust accordingly."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        # Note: remember, we are using an iterator here. So only"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_3b4c1b9e","side":"PARENT","line":248,"updated":"2014-08-21 09:29:29.000000000","message":"To be honest I still think this comment is fine - if I were to change anything here, it would be the word \u0027virtually\u0027 into something that makes it more clear that we are doing it in our local view of the data like \"we consume resources stored in the HostManager instance\" (so that it holds true even if we change how it\u0027s stored later).","commit_id":"97b667d651b6ed543c6a11955b05fb5e2c5d0b49"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d8abf555a5f4c6974048d6f3dec9b5c1b13d4c50","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        # Find our local list of acceptable hosts by repeatedly"},{"line_number":247,"context_line":"        # filtering and weighing our options. Each time we choose a"},{"line_number":248,"context_line":"        # host, we virtually consume resources on it so subsequent"},{"line_number":249,"context_line":"        # selections can adjust accordingly."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        # Note: remember, we are using an iterator here. So only"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_ce20789c","side":"PARENT","line":248,"in_reply_to":"1abeadc6_3b4c1b9e","updated":"2015-01-08 19:20:58.000000000","message":"I also think that the comment is fine-ish. We do select the host with the purpose of consuming its resources later on, so....\n\nIf there is a think to made clearer, it would be something like this:\n\n    # Find our local list of acceptable hosts by repeatedly\n    # filtering and weighing our options. We select hosts with the\n    # purpose of consuming their resources later on, which\n    # means subsequent selections must adjust accordingly.\n\nBut that\u0027s my opinion. :)","commit_id":"97b667d651b6ed543c6a11955b05fb5e2c5d0b49"}]}