)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"a346368001535b4db6ab4b192b1e33a00b7d13f1","unresolved":false,"context_lines":[{"line_number":2267,"context_line":"                                \u0027 to %(exc)s\u0027, {\u0027volume_id\u0027: bdm.volume_id,"},{"line_number":2268,"context_line":"                                                \u0027exc\u0027: unicode(exc)})"},{"line_number":2269,"context_line":"        if exc_info is not None and raise_exc:"},{"line_number":2270,"context_line":"            raise exc_info[0], exc_info[1], exc_info[2]"},{"line_number":2271,"context_line":""},{"line_number":2272,"context_line":"    @hooks.add_hook(\"delete_instance\")"},{"line_number":2273,"context_line":"    def _delete_instance(self, context, instance, bdms, quotas):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b37804c5","line":2270,"updated":"2014-07-15 13:27:01.000000000","message":"maybe use six.reraise instead for python3 compat?","commit_id":"507a2bb90ec7facd4dd1b12c75d8775461c3bce7"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6645a5151f01669364841ce98bc48a1682b9dc17","unresolved":false,"context_lines":[{"line_number":2267,"context_line":"                                \u0027 to %(exc)s\u0027, {\u0027volume_id\u0027: bdm.volume_id,"},{"line_number":2268,"context_line":"                                                \u0027exc\u0027: unicode(exc)})"},{"line_number":2269,"context_line":"        if exc_info is not None and raise_exc:"},{"line_number":2270,"context_line":"            raise exc_info[0], exc_info[1], exc_info[2]"},{"line_number":2271,"context_line":""},{"line_number":2272,"context_line":"    @hooks.add_hook(\"delete_instance\")"},{"line_number":2273,"context_line":"    def _delete_instance(self, context, instance, bdms, quotas):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3fe74848","line":2270,"in_reply_to":"baada198_b37804c5","updated":"2014-07-15 19:02:16.000000000","message":"Woops, didn\u0027t see this.  I can update this.","commit_id":"507a2bb90ec7facd4dd1b12c75d8775461c3bce7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a31048e5e12214be25b200ee99e28a19ce9a667a","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"            self._notify_about_instance_usage(context, instance,"},{"line_number":2254,"context_line":"                                              \"shutdown.end\")"},{"line_number":2255,"context_line":""},{"line_number":2256,"context_line":"    def _cleanup_volumes(self, context, instance_uuid, bdms, raise_exc\u003dFalse):"},{"line_number":2257,"context_line":"        exc_info \u003d None"},{"line_number":2258,"context_line":""},{"line_number":2259,"context_line":"        for bdm in bdms:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_592a4d30","line":2256,"updated":"2014-07-16 03:52:38.000000000","message":"I feel the cases of  \u0027raise_exc\u003dTrue\u0027 are common, because enough NOTE has been already described for the opposite \u0027raise_exc\u003dFalse\u0027 case at line2299.\n\nSo how about setting True as the default and removing raise_exc from line 1428 and 2139?","commit_id":"74f6302b28dc4e935567806ae843ada8e50b5dd3"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"dddf93383b2f92a981456b40edb0ee4231ad5f63","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"            self._notify_about_instance_usage(context, instance,"},{"line_number":2254,"context_line":"                                              \"shutdown.end\")"},{"line_number":2255,"context_line":""},{"line_number":2256,"context_line":"    def _cleanup_volumes(self, context, instance_uuid, bdms, raise_exc\u003dFalse):"},{"line_number":2257,"context_line":"        exc_info \u003d None"},{"line_number":2258,"context_line":""},{"line_number":2259,"context_line":"        for bdm in bdms:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_3e072a1f","line":2256,"in_reply_to":"baada198_592a4d30","updated":"2014-07-16 13:15:39.000000000","message":"That works for me.","commit_id":"74f6302b28dc4e935567806ae843ada8e50b5dd3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a31048e5e12214be25b200ee99e28a19ce9a667a","unresolved":false,"context_lines":[{"line_number":2265,"context_line":"                except Exception as exc:"},{"line_number":2266,"context_line":"                    exc_info \u003d sys.exc_info()"},{"line_number":2267,"context_line":"                    LOG.warn(_LW(\u0027Failed to delete volume: %(volume_id)s due \u0027"},{"line_number":2268,"context_line":"                                 \u0027 to %(exc)s\u0027), {\u0027volume_id\u0027: bdm.volume_id,"},{"line_number":2269,"context_line":"                                                  \u0027exc\u0027: unicode(exc)})"},{"line_number":2270,"context_line":"        if exc_info is not None and raise_exc:"},{"line_number":2271,"context_line":"            six.reraise(exc_info[0], exc_info[1], exc_info[2])"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_5935eda6","line":2268,"updated":"2014-07-16 03:52:38.000000000","message":"There are 2 spaces between \u0027due\u0027 and \u0027to\u0027.\nbetter to remove one.","commit_id":"74f6302b28dc4e935567806ae843ada8e50b5dd3"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"dddf93383b2f92a981456b40edb0ee4231ad5f63","unresolved":false,"context_lines":[{"line_number":2265,"context_line":"                except Exception as exc:"},{"line_number":2266,"context_line":"                    exc_info \u003d sys.exc_info()"},{"line_number":2267,"context_line":"                    LOG.warn(_LW(\u0027Failed to delete volume: %(volume_id)s due \u0027"},{"line_number":2268,"context_line":"                                 \u0027 to %(exc)s\u0027), {\u0027volume_id\u0027: bdm.volume_id,"},{"line_number":2269,"context_line":"                                                  \u0027exc\u0027: unicode(exc)})"},{"line_number":2270,"context_line":"        if exc_info is not None and raise_exc:"},{"line_number":2271,"context_line":"            six.reraise(exc_info[0], exc_info[1], exc_info[2])"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_b1028b07","line":2268,"in_reply_to":"baada198_5935eda6","updated":"2014-07-16 13:15:39.000000000","message":"Good catch.","commit_id":"74f6302b28dc4e935567806ae843ada8e50b5dd3"}]}