)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2b3164a1e8c8bfde5b2351cfade936566f261463","unresolved":false,"context_lines":[{"line_number":15,"context_line":"The fix here recognises that since \u0027_list_instance_domains_fast\u0027"},{"line_number":16,"context_line":"and \u0027_list_instance_domains_slow\u0027 both have explicit test cases,"},{"line_number":17,"context_line":"there is no point in mocking out the low level \u0027listAllDomains\u0027"},{"line_number":18,"context_line":"method all all the other test cases. Instead we can mock out"},{"line_number":19,"context_line":"the much higher level \u0027_list_instance_domains\u0027 which means we"},{"line_number":20,"context_line":"avoid any interaction with libvirt in these test cases. The"},{"line_number":21,"context_line":"opportunity is taken to convert the tests in question to use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baada198_683acf35","line":18,"updated":"2014-07-16 11:35:17.000000000","message":"\u0027in all\u0027 instead of \u0027all all\u0027?","commit_id":"5f6935f8ff67b91f673157b30497a1650416e2ee"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2b3164a1e8c8bfde5b2351cfade936566f261463","unresolved":false,"context_lines":[{"line_number":21,"context_line":"opportunity is taken to convert the tests in question to use"},{"line_number":22,"context_line":"\u0027mock\u0027 instead of \u0027mox\u0027 since it also simplifies the code."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Finally in the test for \u0027_list_instance_domains_fasta\u0027 simply"},{"line_number":25,"context_line":"skip the test if libvirt is too old to have the required"},{"line_number":26,"context_line":"constants defined."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baada198_c85e7b79","line":24,"updated":"2014-07-16 11:35:17.000000000","message":"fast not fasta","commit_id":"5f6935f8ff67b91f673157b30497a1650416e2ee"}],"nova/tests/virt/libvirt/test_driver.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"854a0b5c9c1cf8d8e89253f57cfc15e6ad5297a2","unresolved":false,"context_lines":[{"line_number":2689,"context_line":""},{"line_number":2690,"context_line":"    def test_list_instance_domains_fast(self):"},{"line_number":2691,"context_line":"        if not hasattr(libvirt.virConnect, \u0027listAllDomains\u0027):"},{"line_number":2692,"context_line":"            return"},{"line_number":2693,"context_line":""},{"line_number":2694,"context_line":"        vm1 \u003d FakeVirtDomain(id\u003d3, name\u003d\"instance00000001\")"},{"line_number":2695,"context_line":"        vm2 \u003d FakeVirtDomain(id\u003d17, name\u003d\"instance00000002\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6a1baeca","line":2692,"updated":"2014-07-16 08:25:50.000000000","message":"This is a bit perplexing - you mock out listAllDomains() so why does libvirt need to have it\n\nThis is really about the VIR_CONNECT_LIST_DOMAINS constants, right?\n\nIf so, we should be explicit about that by checking for their availability\n\nAlso use self.skipTest()\n\nAnd maybe rather than skipping, we just mock out those constants too?","commit_id":"7f3c884106535daf64d7a95066b69d7f972b01f5"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"a6c3b270bcc6feecc1f58ad0cb6d2e7f3e62a431","unresolved":false,"context_lines":[{"line_number":2839,"context_line":"        self.assertEqual(doms[1].name(), vm2.name())"},{"line_number":2840,"context_line":"        mock_list.assert_called_with(True)"},{"line_number":2841,"context_line":""},{"line_number":2842,"context_line":"        mock_list.return_value \u003d [vm0, vm1, vm2, vm3, vm4]"},{"line_number":2843,"context_line":"        doms \u003d drvr._list_instance_domains(only_running\u003dFalse)"},{"line_number":2844,"context_line":"        self.assertEqual(len(doms), 4)"},{"line_number":2845,"context_line":"        self.assertEqual(doms[0].name(), vm1.name())"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_018eb0d0","line":2842,"updated":"2014-07-15 17:40:52.000000000","message":"It\u0027s interesting to note that since we\u0027re mocking _fast, the return values really only represent some theoretical for \"only_running\" now.\n\nYou could have the same return for all three tests.","commit_id":"7f3c884106535daf64d7a95066b69d7f972b01f5"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"a6c3b270bcc6feecc1f58ad0cb6d2e7f3e62a431","unresolved":false,"context_lines":[{"line_number":6820,"context_line":"        def fake_get_info():"},{"line_number":6821,"context_line":"            return [\u0027x86_64\u0027, 15814L, 8, 1208, 1, 1, 4, 2]"},{"line_number":6822,"context_line":""},{"line_number":6823,"context_line":"        self.mox.StubOutWithMock(libvirt_driver.LibvirtDriver, \u0027_conn\u0027)"},{"line_number":6824,"context_line":"        libvirt_driver.LibvirtDriver._conn.getInfo \u003d fake_get_info"},{"line_number":6825,"context_line":""},{"line_number":6826,"context_line":"        real_open \u003d __builtin__.open"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4c29bf88","line":6823,"updated":"2014-07-15 17:40:52.000000000","message":"People have -1\u0027ed me in the past for mixing mox and mock (though I think that was for a new test).  Are we allowing this now?","commit_id":"7f3c884106535daf64d7a95066b69d7f972b01f5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"472385fb5451047edea5eb1be7e079f25f6a24e6","unresolved":false,"context_lines":[{"line_number":6820,"context_line":"        def fake_get_info():"},{"line_number":6821,"context_line":"            return [\u0027x86_64\u0027, 15814L, 8, 1208, 1, 1, 4, 2]"},{"line_number":6822,"context_line":""},{"line_number":6823,"context_line":"        self.mox.StubOutWithMock(libvirt_driver.LibvirtDriver, \u0027_conn\u0027)"},{"line_number":6824,"context_line":"        libvirt_driver.LibvirtDriver._conn.getInfo \u003d fake_get_info"},{"line_number":6825,"context_line":""},{"line_number":6826,"context_line":"        real_open \u003d __builtin__.open"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4dd60ff3","line":6823,"in_reply_to":"baada198_4c29bf88","updated":"2014-07-16 00:30:29.000000000","message":"It\u0027s not preferrable, but sometimes happens when an existing test is using setUp with mox - although I prefer to not mix, so would rather see mox used here so it\u0027s consistent.","commit_id":"7f3c884106535daf64d7a95066b69d7f972b01f5"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"af8a05334511edf319427df34eab0ce7b1b79803","unresolved":false,"context_lines":[{"line_number":2703,"context_line":""},{"line_number":2704,"context_line":"        # Ensure props exist to cope with old libvirt versions"},{"line_number":2705,"context_line":"        libvirt.VIR_CONNECT_LIST_DOMAINS_ACTIVE \u003d 1"},{"line_number":2706,"context_line":"        libvirt.VIR_CONNECT_LIST_DOMAINS_INACTIVE \u003d 2"},{"line_number":2707,"context_line":"        self.mox.StubOutWithMock(libvirt_driver.LibvirtDriver, \u0027_conn\u0027)"},{"line_number":2708,"context_line":"        libvirt_driver.LibvirtDriver._conn.listAllDomains \u003d fake_list_all"},{"line_number":2709,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d41b787e","line":2706,"updated":"2014-07-16 10:10:48.000000000","message":"I don\u0027t like that this doesn\u0027t get unset after the test runs\n\nYou could end up with another test accidentally relying on this test being run first","commit_id":"8ed7cef1155ccb56917a052731356a74c5a57016"}]}