)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"92d2fad867da6d05837fb5061aa80822fc91b6d9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"A number of operations in the VMwareVCDriver class first validate"},{"line_number":10,"context_line":"that instances node is the cluster that is mapped to the compute"},{"line_number":11,"context_line":"node. This is problematic when the compute nodes have different"},{"line_number":12,"context_line":"configurations, for example, each compute node is mapped to a cluster."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this case many operations that are just performing instance operations"},{"line_number":15,"context_line":"will fail. This patch ensure that all instance operations that do not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9df570_5e3166eb","line":12,"updated":"2014-09-22 10:02:29.000000000","message":"I guess you mean \"each compute node is mapped to a different cluster\"?","commit_id":"ead9832c3178a4a9d493f31bf836ba07d8fb5a39"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9d2846a47c448a6eda958c1f432db80a7693141f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"A number of operations in the VMwareVCDriver class first validate"},{"line_number":10,"context_line":"that instances node is the cluster that is mapped to the compute"},{"line_number":11,"context_line":"node. This is problematic when the compute nodes have different"},{"line_number":12,"context_line":"configurations, for example, each compute node is mapped to a cluster."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this case many operations that are just performing instance operations"},{"line_number":15,"context_line":"will fail. This patch ensure that all instance operations that do not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baa201ad_d53a5133","line":12,"in_reply_to":"da9df570_5e3166eb","updated":"2014-10-02 06:37:16.000000000","message":"Done","commit_id":"ead9832c3178a4a9d493f31bf836ba07d8fb5a39"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"731efc5b25914e5425815be8f16ec683f3506a75","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"},{"line_number":488,"context_line":"                      disk_bus\u003dNone, device_type\u003dNone, encryption\u003dNone):"},{"line_number":489,"context_line":"        \"\"\"Attach volume storage to VM instance.\"\"\""},{"line_number":490,"context_line":"        _volumeops \u003d self._get_volumeops_for_compute_node(instance[\u0027node\u0027])"},{"line_number":491,"context_line":"        return _volumeops.attach_volume(connection_info,"},{"line_number":492,"context_line":"                                             instance,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_fcd4be48","line":489,"updated":"2014-11-20 01:41:40.000000000","message":"Why don\u0027t we use self._volumeops here like get_volume_connector()?","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e56bc1b6689739c664731d86bd2baf26c6567d1a","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"},{"line_number":488,"context_line":"                      disk_bus\u003dNone, device_type\u003dNone, encryption\u003dNone):"},{"line_number":489,"context_line":"        \"\"\"Attach volume storage to VM instance.\"\"\""},{"line_number":490,"context_line":"        _volumeops \u003d self._get_volumeops_for_compute_node(instance[\u0027node\u0027])"},{"line_number":491,"context_line":"        return _volumeops.attach_volume(connection_info,"},{"line_number":492,"context_line":"                                             instance,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_47d469e8","line":489,"in_reply_to":"5a890539_c742190e","updated":"2014-11-26 07:47:52.000000000","message":"Thanks for your explanation, I got it. current patch is good for me.","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e177b8eb73170c2f84e724fd32812243cc92de77","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"},{"line_number":488,"context_line":"                      disk_bus\u003dNone, device_type\u003dNone, encryption\u003dNone):"},{"line_number":489,"context_line":"        \"\"\"Attach volume storage to VM instance.\"\"\""},{"line_number":490,"context_line":"        _volumeops \u003d self._get_volumeops_for_compute_node(instance[\u0027node\u0027])"},{"line_number":491,"context_line":"        return _volumeops.attach_volume(connection_info,"},{"line_number":492,"context_line":"                                             instance,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_c742190e","line":489,"in_reply_to":"5a890539_fcd4be48","updated":"2014-11-26 07:40:14.000000000","message":"Each cluster may be connected to a different datastore. When the the driver boots the \u0027node\u0027 will contain the relevant cluster and volume datastructures. In this case we need to make sure that the volume used for the volume attachment is actually the one that is defined for the cluster in question. We need to make sure that the VM is able to connect to its volume. Hence we need to take this data structure from the instance[\u0027node\u0027]\nSo we are unable to drop this code here.","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"731efc5b25914e5425815be8f16ec683f3506a75","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    def detach_volume(self, connection_info, instance, mountpoint,"},{"line_number":496,"context_line":"                      encryption\u003dNone):"},{"line_number":497,"context_line":"        \"\"\"Detach volume storage to VM instance.\"\"\""},{"line_number":498,"context_line":"        _volumeops \u003d self._get_volumeops_for_compute_node(instance[\u0027node\u0027])"},{"line_number":499,"context_line":"        return _volumeops.detach_volume(connection_info,"},{"line_number":500,"context_line":"                                             instance,"},{"line_number":501,"context_line":"                                             mountpoint)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_1cca6aa1","line":498,"updated":"2014-11-20 01:41:40.000000000","message":"ditto","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e177b8eb73170c2f84e724fd32812243cc92de77","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    def detach_volume(self, connection_info, instance, mountpoint,"},{"line_number":496,"context_line":"                      encryption\u003dNone):"},{"line_number":497,"context_line":"        \"\"\"Detach volume storage to VM instance.\"\"\""},{"line_number":498,"context_line":"        _volumeops \u003d self._get_volumeops_for_compute_node(instance[\u0027node\u0027])"},{"line_number":499,"context_line":"        return _volumeops.detach_volume(connection_info,"},{"line_number":500,"context_line":"                                             instance,"},{"line_number":501,"context_line":"                                             mountpoint)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_e74c7544","line":498,"in_reply_to":"5a890539_1cca6aa1","updated":"2014-11-26 07:40:14.000000000","message":"ditto","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"731efc5b25914e5425815be8f16ec683f3506a75","unresolved":false,"context_lines":[{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    def attach_interface(self, instance, image_meta, vif):"},{"line_number":640,"context_line":"        \"\"\"Attach an interface to the instance.\"\"\""},{"line_number":641,"context_line":"        _vmops \u003d self._get_vmops_for_compute_node(instance.node)"},{"line_number":642,"context_line":"        _vmops.attach_interface(instance, image_meta, vif)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def detach_interface(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_bcba3608","line":641,"updated":"2014-11-20 01:41:40.000000000","message":"ditto","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e177b8eb73170c2f84e724fd32812243cc92de77","unresolved":false,"context_lines":[{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    def attach_interface(self, instance, image_meta, vif):"},{"line_number":640,"context_line":"        \"\"\"Attach an interface to the instance.\"\"\""},{"line_number":641,"context_line":"        _vmops \u003d self._get_vmops_for_compute_node(instance.node)"},{"line_number":642,"context_line":"        _vmops.attach_interface(instance, image_meta, vif)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def detach_interface(self, instance, vif):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_27011daf","line":641,"in_reply_to":"5a890539_bcba3608","updated":"2014-11-26 07:40:14.000000000","message":"good catch :)\nmy search was done on instance[\u0027node\u0027]","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"731efc5b25914e5425815be8f16ec683f3506a75","unresolved":false,"context_lines":[{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def detach_interface(self, instance, vif):"},{"line_number":645,"context_line":"        \"\"\"Detach an interface from the instance.\"\"\""},{"line_number":646,"context_line":"        _vmops \u003d self._get_vmops_for_compute_node(instance.node)"},{"line_number":647,"context_line":"        _vmops.detach_interface(instance, vif)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_dc3622b4","line":646,"updated":"2014-11-20 01:41:40.000000000","message":"ditto","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e177b8eb73170c2f84e724fd32812243cc92de77","unresolved":false,"context_lines":[{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def detach_interface(self, instance, vif):"},{"line_number":645,"context_line":"        \"\"\"Detach an interface from the instance.\"\"\""},{"line_number":646,"context_line":"        _vmops \u003d self._get_vmops_for_compute_node(instance.node)"},{"line_number":647,"context_line":"        _vmops.detach_interface(instance, vif)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_8731f1a3","line":646,"in_reply_to":"5a890539_dc3622b4","updated":"2014-11-26 07:40:14.000000000","message":"Done","commit_id":"ecc0f103595e93e92a2bf2b746dc403a0bb1ba8b"}]}