)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"79261e06e12e1a503b6ffe836e995669d66a21d3","unresolved":false,"context_lines":[{"line_number":837,"context_line":"        if not instance_uuid:"},{"line_number":838,"context_line":"            instance_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        @utils.synchronized(instance_uuid)"},{"line_number":841,"context_line":"        def do_run_instance():"},{"line_number":842,"context_line":"            self._run_instance(context, request_spec,"},{"line_number":843,"context_line":"                    filter_properties, requested_networks, injected_files,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F44Q%3D","line":840,"updated":"2012-08-04 04:52:11.000000000","message":"Couldn\u0027t you just change this to instance[\u0027uuid\u0027]? I\u0027d much rather that. You\u0027d need to change this to looking up the instance if only instance_uuid was passed, but given we want to get away from passing instance_uuid at all that sounds like a reasonable plan.","commit_id":"b90994f458eea2f438fcea0095e5384b6e55185b"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"4665211f0cba7be2a56d0fa03d8e618a8ff1d716","unresolved":false,"context_lines":[{"line_number":837,"context_line":"        if not instance_uuid:"},{"line_number":838,"context_line":"            instance_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        @utils.synchronized(instance_uuid)"},{"line_number":841,"context_line":"        def do_run_instance():"},{"line_number":842,"context_line":"            self._run_instance(context, request_spec,"},{"line_number":843,"context_line":"                    filter_properties, requested_networks, injected_files,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F4fc%3D","line":840,"in_reply_to":"AAAALH%2F%2F44Q%3D","updated":"2012-08-05 16:47:12.000000000","message":"Point taken.  In this particular case, the function is just a wrapper, so I did it this way to avoid addding any \"real\" code here.\n\nThe only reason intance_uuid is accepted as an argument is for backwards compatibility.  It will usually be None.","commit_id":"b90994f458eea2f438fcea0095e5384b6e55185b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"79261e06e12e1a503b6ffe836e995669d66a21d3","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        def do_run_instance():"},{"line_number":842,"context_line":"            self._run_instance(context, request_spec,"},{"line_number":843,"context_line":"                    filter_properties, requested_networks, injected_files,"},{"line_number":844,"context_line":"                    admin_password, is_first_time, instance, instance_uuid)"},{"line_number":845,"context_line":"        do_run_instance()"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    def _shutdown_instance(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F44M%3D","line":844,"updated":"2012-08-04 04:52:11.000000000","message":"Ditto.","commit_id":"b90994f458eea2f438fcea0095e5384b6e55185b"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"4665211f0cba7be2a56d0fa03d8e618a8ff1d716","unresolved":false,"context_lines":[{"line_number":917,"context_line":"    def terminate_instance(self, context, instance\u003dNone, instance_uuid\u003dNone):"},{"line_number":918,"context_line":"        \"\"\"Terminate an instance on this host.\"\"\""},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        if not instance_uuid:"},{"line_number":921,"context_line":"            instance_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        @utils.synchronized(instance_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2F4fY%3D","line":920,"updated":"2012-08-05 16:47:12.000000000","message":"I can change this one.  The instance_get_by_uuid() is done in here anyway.","commit_id":"b90994f458eea2f438fcea0095e5384b6e55185b"}]}