)]}'
{"nova/virt/disk.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"445338a82a1b303ca72d8e4266a77b7a14052808","unresolved":false,"context_lines":[{"line_number":76,"context_line":"_MKFS_COMMAND \u003d {}"},{"line_number":77,"context_line":"_DEFAULT_MKFS_COMMAND \u003d None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"if os.path.exists(\"/sys/module/nbd/parameters\"):"},{"line_number":80,"context_line":"    max_nbd \u003d open(\"nbds_max\").read()"},{"line_number":81,"context_line":"    LOG.info(_(\u0027Max nbd device is %s\u0027 % max_nbd))"},{"line_number":82,"context_line":"    FLAGS.max_nbd_devices \u003d max_nbd"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F564%3D","line":79,"updated":"2011-10-28 15:54:50.000000000","message":"Would it make sense to check for os.path.exists(\"/sys/module/nbd/parameters/nbds_max\")?","commit_id":"cb3d0f7f88e81020a895f1c86f6497c4e867424b"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"445338a82a1b303ca72d8e4266a77b7a14052808","unresolved":false,"context_lines":[{"line_number":77,"context_line":"_DEFAULT_MKFS_COMMAND \u003d None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"if os.path.exists(\"/sys/module/nbd/parameters\"):"},{"line_number":80,"context_line":"    max_nbd \u003d open(\"nbds_max\").read()"},{"line_number":81,"context_line":"    LOG.info(_(\u0027Max nbd device is %s\u0027 % max_nbd))"},{"line_number":82,"context_line":"    FLAGS.max_nbd_devices \u003d max_nbd"},{"line_number":83,"context_line":"else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F56w%3D","line":80,"updated":"2011-10-28 15:54:50.000000000","message":"Does this need to be the absolute path? open(\"/sys/module/nbd/parameters/nbds_max\").read()?","commit_id":"cb3d0f7f88e81020a895f1c86f6497c4e867424b"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"445338a82a1b303ca72d8e4266a77b7a14052808","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"if os.path.exists(\"/sys/module/nbd/parameters\"):"},{"line_number":80,"context_line":"    max_nbd \u003d open(\"nbds_max\").read()"},{"line_number":81,"context_line":"    LOG.info(_(\u0027Max nbd device is %s\u0027 % max_nbd))"},{"line_number":82,"context_line":"    FLAGS.max_nbd_devices \u003d max_nbd"},{"line_number":83,"context_line":"else:"},{"line_number":84,"context_line":"    LOG.info(_(\u0027Max nbd device is %s\u0027 % FLAGS.max_nbd_devices))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F56s%3D","line":81,"updated":"2011-10-28 15:54:50.000000000","message":"If you remove this line and get rid of the \u0027else\u0027 statement below, you could just have a single LOG statement instead of two.","commit_id":"cb3d0f7f88e81020a895f1c86f6497c4e867424b"}]}