)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e68b1fbdea479ec83ead3d1bf882bd24bf37a614","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This is part of blueprint vmware-ephemeral-disk-support"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":"  - Indicate that epehemeral disks are now supported by the driver"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Icb1796e58126a1e03613946b0f5a917d6eb4708e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"baa201ad_595bf32d","line":19,"updated":"2014-10-14 06:31:29.000000000","message":"typo: ephemeral","commit_id":"f9c51e0161fb4361675a625a67d8881526f0c54f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"41f847b9a3d8f05761f075f48fc36f8f602661e9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This is part of blueprint vmware-ephemeral-disk-support"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":"  - Indicate that epehemeral disks are now supported by the driver"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Icb1796e58126a1e03613946b0f5a917d6eb4708e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9aa7fdbe_1b7e1eaf","line":19,"in_reply_to":"baa201ad_595bf32d","updated":"2014-10-19 12:02:36.000000000","message":"Done","commit_id":"f9c51e0161fb4361675a625a67d8881526f0c54f"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"dbea6ddfa5ae509df03d456db6cc4081e7e44ada","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"},{"line_number":668,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":669,"context_line":"                                     \u0027ephemeral_1.vmdk\u0027)"},{"line_number":670,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def test_ephemeral_disk_attach_from_bdii_with_no_ephs(self):"},{"line_number":673,"context_line":"        bdi \u003d {\u0027ephemerals\u0027: []}"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a890539_f4b640db","line":670,"updated":"2014-12-02 21:21:16.000000000","message":"get_file() returns True?","commit_id":"a6024b72639da0cece62f88c23b814600afbe525"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3b150971b7a0b4f892569cdf25836bdccf245a15","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"},{"line_number":668,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":669,"context_line":"                                     \u0027ephemeral_1.vmdk\u0027)"},{"line_number":670,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def test_ephemeral_disk_attach_from_bdii_with_no_ephs(self):"},{"line_number":673,"context_line":"        bdi \u003d {\u0027ephemerals\u0027: []}"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a890539_6226e5bb","line":670,"in_reply_to":"5a890539_f4b640db","updated":"2014-12-03 18:00:23.000000000","message":"Yes, this method returns if the specified file is found. In the fake driver we keep a list of the configured files for the VM\u0027s.","commit_id":"a6024b72639da0cece62f88c23b814600afbe525"}],"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"e68b1fbdea479ec83ead3d1bf882bd24bf37a614","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        self._create_vm(ephemeral\u003d50)"},{"line_number":620,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":621,"context_line":"                                     \u0027ephemeral_disk.vmdk\u0027)"},{"line_number":622,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def test_cdrom_attach_with_config_drive(self):"},{"line_number":625,"context_line":"        self.flags(force_config_drive\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baa201ad_990e3b31","line":622,"updated":"2014-10-14 06:31:29.000000000","message":"unrelated to this patch: \"get_file\" is bad name for this, it should be renamed to \"file_exists\"","commit_id":"f9c51e0161fb4361675a625a67d8881526f0c54f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"30fe9bb5b8d03917707eb3804487b19bcd5fc929","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        self._create_vm(ephemeral\u003d50)"},{"line_number":647,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":648,"context_line":"                                     \u0027ephemeral_disk.vmdk\u0027)"},{"line_number":649,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def test_cdrom_attach_with_config_drive(self):"},{"line_number":652,"context_line":"        self.flags(force_config_drive\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_dc22f050","line":649,"updated":"2014-10-28 10:02:29.000000000","message":"Nice.\n\nHow hard would it be to add a test of ephemerals passed by bdm here, too?","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"39cf9553df99144c57a4488f6e3c0b9c2f0bc6f4","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                self.ds \u003d \u0027ds1\u0027"},{"line_number":225,"context_line":"            else:"},{"line_number":226,"context_line":"                self.ds \u003d \u0027ds2\u0027"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        self.vim \u003d vmwareapi_fake.FakeVim()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # NOTE(vish): none of the network plugging code is actually"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_8257ffc9","side":"PARENT","line":227,"updated":"2014-10-29 12:05:50.000000000","message":"nit: Not related.","commit_id":"e797c7a54aff312b2c3c1395dac52c306d3ac55d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fddc3f8ea6bc0f594516ef8733d32de47ad8b86","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                self.ds \u003d \u0027ds1\u0027"},{"line_number":225,"context_line":"            else:"},{"line_number":226,"context_line":"                self.ds \u003d \u0027ds2\u0027"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        self.vim \u003d vmwareapi_fake.FakeVim()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # NOTE(vish): none of the network plugging code is actually"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_dd900651","side":"PARENT","line":227,"in_reply_to":"9aa7fdbe_8257ffc9","updated":"2014-10-29 12:32:03.000000000","message":"Done","commit_id":"e797c7a54aff312b2c3c1395dac52c306d3ac55d"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"39cf9553df99144c57a4488f6e3c0b9c2f0bc6f4","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    def test_ephemeral_disk_attach_from_bdi(self):"},{"line_number":654,"context_line":"        ephemerals \u003d [{\u0027device_type\u0027: \u0027disk\u0027,"},{"line_number":655,"context_line":"                       \u0027disk_bus\u0027: \u0027lsiLogic\u0027,"},{"line_number":656,"context_line":"                       \u0027size\u0027: 50}]"},{"line_number":657,"context_line":"        bdi \u003d {\u0027ephemerals\u0027: ephemerals}"},{"line_number":658,"context_line":"        self._create_vm(bdi\u003dbdi)"},{"line_number":659,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_a2afa393","line":656,"updated":"2014-10-29 12:05:50.000000000","message":"Worth creating 2?","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fddc3f8ea6bc0f594516ef8733d32de47ad8b86","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    def test_ephemeral_disk_attach_from_bdi(self):"},{"line_number":654,"context_line":"        ephemerals \u003d [{\u0027device_type\u0027: \u0027disk\u0027,"},{"line_number":655,"context_line":"                       \u0027disk_bus\u0027: \u0027lsiLogic\u0027,"},{"line_number":656,"context_line":"                       \u0027size\u0027: 50}]"},{"line_number":657,"context_line":"        bdi \u003d {\u0027ephemerals\u0027: ephemerals}"},{"line_number":658,"context_line":"        self._create_vm(bdi\u003dbdi)"},{"line_number":659,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_5d8c1636","line":656,"in_reply_to":"9aa7fdbe_a2afa393","updated":"2014-10-29 12:32:03.000000000","message":"Done","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"39cf9553df99144c57a4488f6e3c0b9c2f0bc6f4","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                       \u0027disk_bus\u0027: \u0027lsiLogic\u0027,"},{"line_number":656,"context_line":"                       \u0027size\u0027: 50}]"},{"line_number":657,"context_line":"        bdi \u003d {\u0027ephemerals\u0027: ephemerals}"},{"line_number":658,"context_line":"        self._create_vm(bdi\u003dbdi)"},{"line_number":659,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":660,"context_line":"                                     \u0027ephemeral_0_50.vmdk\u0027)"},{"line_number":661,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_c2f66790","line":658,"updated":"2014-10-29 12:05:50.000000000","message":"I think you should pass in ephemeral here too, because this will be the normal situation. It should only create the ephemerals passed in via bdis.\n\nIf you added 2 ephemerals to bdi with size 25 and passed in ephemerals\u003d50, which is a valid config, you could test that ephemeral_{0,1}_25.vmdk exist, and that ephemeral_0_50.vmdk does not exist.","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fddc3f8ea6bc0f594516ef8733d32de47ad8b86","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                       \u0027disk_bus\u0027: \u0027lsiLogic\u0027,"},{"line_number":656,"context_line":"                       \u0027size\u0027: 50}]"},{"line_number":657,"context_line":"        bdi \u003d {\u0027ephemerals\u0027: ephemerals}"},{"line_number":658,"context_line":"        self._create_vm(bdi\u003dbdi)"},{"line_number":659,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":660,"context_line":"                                     \u0027ephemeral_0_50.vmdk\u0027)"},{"line_number":661,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_fd74ea37","line":658,"in_reply_to":"9aa7fdbe_c2f66790","updated":"2014-10-29 12:32:03.000000000","message":"Done","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"d12f9565103e5cbd27799f852d2f21a1e0bdedd7","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        bdi \u003d {\u0027ephemerals\u0027: ephemerals}"},{"line_number":662,"context_line":"        self._create_vm(bdi\u003dbdi, ephemeral\u003d50)"},{"line_number":663,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":664,"context_line":"                                     \u0027ephemeral_0_25.vmdk\u0027)"},{"line_number":665,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":666,"context_line":"                                     \u0027ephemeral_1_25.vmdk\u0027)"},{"line_number":667,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"}],"source_content_type":"text/x-python","patch_set":19,"id":"9aa7fdbe_7de71aad","line":664,"updated":"2014-10-29 12:42:00.000000000","message":"You missed an extra assert here :)","commit_id":"78cd03893d023ccf2f8de6c8159b6ad0499379a4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a66aeb81f82f9f005a0ae5f8ab1c243383f4c1c5","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        bdi \u003d {\u0027ephemerals\u0027: ephemerals}"},{"line_number":662,"context_line":"        self._create_vm(bdi\u003dbdi, ephemeral\u003d50)"},{"line_number":663,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":664,"context_line":"                                     \u0027ephemeral_0_25.vmdk\u0027)"},{"line_number":665,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":666,"context_line":"                                     \u0027ephemeral_1_25.vmdk\u0027)"},{"line_number":667,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"}],"source_content_type":"text/x-python","patch_set":19,"id":"9aa7fdbe_c1a904e1","line":664,"in_reply_to":"9aa7fdbe_7de71aad","updated":"2014-10-29 12:51:41.000000000","message":"Done","commit_id":"78cd03893d023ccf2f8de6c8159b6ad0499379a4"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"d12f9565103e5cbd27799f852d2f21a1e0bdedd7","unresolved":false,"context_lines":[{"line_number":664,"context_line":"                                     \u0027ephemeral_0_25.vmdk\u0027)"},{"line_number":665,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":666,"context_line":"                                     \u0027ephemeral_1_25.vmdk\u0027)"},{"line_number":667,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def test_cdrom_attach_with_config_drive(self):"},{"line_number":670,"context_line":"        self.flags(force_config_drive\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9aa7fdbe_5d99761e","line":667,"updated":"2014-10-29 12:42:00.000000000","message":"I think it\u0027s worth also testing the negative for ephemeral_0_50. Ideally we\u0027d do a set test as I do in the image fetching test cleanup patches (i.e. assert that these files exist and no others), but that\u0027s probably not straightforward without those patches (don\u0027t worry about it).","commit_id":"78cd03893d023ccf2f8de6c8159b6ad0499379a4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a66aeb81f82f9f005a0ae5f8ab1c243383f4c1c5","unresolved":false,"context_lines":[{"line_number":664,"context_line":"                                     \u0027ephemeral_0_25.vmdk\u0027)"},{"line_number":665,"context_line":"        path \u003d ds_util.DatastorePath(self.ds, self.uuid,"},{"line_number":666,"context_line":"                                     \u0027ephemeral_1_25.vmdk\u0027)"},{"line_number":667,"context_line":"        self.assertTrue(vmwareapi_fake.get_file(str(path)))"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def test_cdrom_attach_with_config_drive(self):"},{"line_number":670,"context_line":"        self.flags(force_config_drive\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9aa7fdbe_a1f24004","line":667,"in_reply_to":"9aa7fdbe_5d99761e","updated":"2014-10-29 12:51:41.000000000","message":"Done","commit_id":"78cd03893d023ccf2f8de6c8159b6ad0499379a4"}],"nova/tests/virt/vmwareapi/test_vmops.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"30fe9bb5b8d03917707eb3804487b19bcd5fc929","unresolved":false,"context_lines":[{"line_number":754,"context_line":"                            \u0027ExtendVirtualDisk_Task\u0027,"},{"line_number":755,"context_line":"        ]"},{"line_number":756,"context_line":"        if extras:"},{"line_number":757,"context_line":"            expected_methods.extend(extras)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        recorded_methods \u003d [c[1][1] for c in mock_call_method.mock_calls]"},{"line_number":760,"context_line":"        self.assertEqual(expected_methods, recorded_methods)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_5cbd20d7","line":757,"updated":"2014-10-28 10:02:29.000000000","message":"Eurgh. These tests are just a box-ticking exercise. We should work out what, if anything, they\u0027re actually usefully testing and rewrite it. The rest we should throw away.\n\nAnother day, though.","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a27938e541bb1795f6396585bd6cebb935fcb5da","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                self._volumeops.attach_root_volume(connection_info, instance,"},{"line_number":504,"context_line":"                                                   self._default_root_device,"},{"line_number":505,"context_line":"                                                   vi.datastore.ref)"},{"line_number":506,"context_line":"        else:"},{"line_number":507,"context_line":"            self._imagecache.enlist_image("},{"line_number":508,"context_line":"                    image_info.image_id, vi.datastore, vi.dc_info.ref)"},{"line_number":509,"context_line":"            self._fetch_image_if_missing(context, vi)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa201ad_992f343e","line":506,"updated":"2014-10-13 13:33:17.000000000","message":"surely when you boot from a volume, you still need config drive, and you still need an ephemeral disk?","commit_id":"6f41a0dfc2c227e67eab064e99ea04976ba084aa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e2a7a52458af4b7fa8e2005b5041857dd359c789","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                self._volumeops.attach_root_volume(connection_info, instance,"},{"line_number":504,"context_line":"                                                   self._default_root_device,"},{"line_number":505,"context_line":"                                                   vi.datastore.ref)"},{"line_number":506,"context_line":"        else:"},{"line_number":507,"context_line":"            self._imagecache.enlist_image("},{"line_number":508,"context_line":"                    image_info.image_id, vi.datastore, vi.dc_info.ref)"},{"line_number":509,"context_line":"            self._fetch_image_if_missing(context, vi)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa201ad_992e54f9","line":506,"in_reply_to":"baa201ad_992f343e","updated":"2014-10-13 13:43:59.000000000","message":"opened a bug - will post a patch","commit_id":"6f41a0dfc2c227e67eab064e99ea04976ba084aa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a27938e541bb1795f6396585bd6cebb935fcb5da","unresolved":false,"context_lines":[{"line_number":516,"context_line":"                self._use_disk_image_as_full_clone(vm_ref, vi)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"            if instance.ephemeral_gb:"},{"line_number":519,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"            if configdrive.required_by(instance):"},{"line_number":522,"context_line":"                self._configure_config_drive("}],"source_content_type":"text/x-python","patch_set":9,"id":"baa201ad_f91f6007","line":519,"updated":"2014-10-13 13:33:17.000000000","message":"Just wondering if this affects where config drive is getting mounted, and if that matters.\n\nI suspect doing this first is the best way forward though, so maybe ignore that.","commit_id":"6f41a0dfc2c227e67eab064e99ea04976ba084aa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e2a7a52458af4b7fa8e2005b5041857dd359c789","unresolved":false,"context_lines":[{"line_number":516,"context_line":"                self._use_disk_image_as_full_clone(vm_ref, vi)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"            if instance.ephemeral_gb:"},{"line_number":519,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"            if configdrive.required_by(instance):"},{"line_number":522,"context_line":"                self._configure_config_drive("}],"source_content_type":"text/x-python","patch_set":9,"id":"baa201ad_b90cf895","line":519,"in_reply_to":"baa201ad_f91f6007","updated":"2014-10-13 13:43:59.000000000","message":"the config drive is an iso. we take care of the device id\u0027s internally.","commit_id":"6f41a0dfc2c227e67eab064e99ea04976ba084aa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5036a1799e0542202d2aa6503ad2c6b7155052bc","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                block_device_info)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        if instance.ephemeral_gb:"},{"line_number":484,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        # NOTE(mdbooth): the logic here is that we ignore the image if there"},{"line_number":487,"context_line":"        # are block device mappings. This behaviour is incorrect, and a bug in"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa201ad_f97680d7","line":484,"updated":"2014-10-13 13:52:37.000000000","message":"I would hate for this to mean the ephemeral disk gets the root disk position, I would attach it after the root disks anyways, it \"feels better\" that way.","commit_id":"ab07a0bb4a0a52579415967ea735289862d04179"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"49ba44bf1cbeeaeb6594dbce8ec3e403f6d11ec6","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                block_device_info)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        if instance.ephemeral_gb:"},{"line_number":484,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        # NOTE(mdbooth): the logic here is that we ignore the image if there"},{"line_number":487,"context_line":"        # are block device mappings. This behaviour is incorrect, and a bug in"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa201ad_3acab71a","line":484,"in_reply_to":"baa201ad_f97680d7","updated":"2014-10-13 14:51:28.000000000","message":"Good point, I think this should go after the _use_disk_image_* where we attach the primary disk.","commit_id":"ab07a0bb4a0a52579415967ea735289862d04179"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"78327e06e96d832b4112faee4c4cceec58d128bc","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    def _create_and_attach_ephemeral_disk(self, instance, vm_ref, vi):"},{"line_number":428,"context_line":"        size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":429,"context_line":"        path \u003d str(ds_util.DatastorePath(vi.datastore.name, instance.uuid,"},{"line_number":430,"context_line":"                                         \u0027ephemeral_disk.vmdk\u0027))"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        disk_type \u003d (constants.DISK_TYPE_PREALLOCATED"},{"line_number":433,"context_line":"                     if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aa7fdbe_a9491ed2","line":430,"updated":"2014-10-21 09:20:49.000000000","message":"This breaks if you have more than 1 ephemeral disk.","commit_id":"088eb051c0be6d0b95ec5f93ac6ec492620f5edc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"145188d5d9b3e7e61af89252943d40a6cc6bf078","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    def _create_and_attach_ephemeral_disk(self, instance, vm_ref, vi):"},{"line_number":428,"context_line":"        size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":429,"context_line":"        path \u003d str(ds_util.DatastorePath(vi.datastore.name, instance.uuid,"},{"line_number":430,"context_line":"                                         \u0027ephemeral_disk.vmdk\u0027))"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        disk_type \u003d (constants.DISK_TYPE_PREALLOCATED"},{"line_number":433,"context_line":"                     if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aa7fdbe_a745c218","line":430,"in_reply_to":"9aa7fdbe_a9491ed2","updated":"2014-10-21 13:34:35.000000000","message":"This is not correct. The specific support for this is from the flavor. Not from anything else.","commit_id":"088eb051c0be6d0b95ec5f93ac6ec492620f5edc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"721440657315e4591bd124395951d24dc773572d","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                                         \u0027ephemeral_disk.vmdk\u0027))"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        disk_type \u003d (constants.DISK_TYPE_PREALLOCATED"},{"line_number":433,"context_line":"                     if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE"},{"line_number":434,"context_line":"                     else vi.ii.disk_type)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vm_util.create_virtual_disk("}],"source_content_type":"text/x-python","patch_set":14,"id":"9aa7fdbe_46b5ef2f","line":433,"updated":"2014-10-21 18:55:04.000000000","message":"Is this reversed? If the disk is NOT sparse then it is preallocated, right? I don\u0027t see anywhere in the tests that this is checked. Something should validate that we call create_virtual_disk() with disk_type \u003d\u003d $what_we_expect right? Did I miss it?","commit_id":"21b815038f20b947d616f7175312928b0341e90b"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"d1ff92736ac13456fa7fd8141a1e2da5bfb177ba","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                                         \u0027ephemeral_disk.vmdk\u0027))"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        disk_type \u003d (constants.DISK_TYPE_PREALLOCATED"},{"line_number":433,"context_line":"                     if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE"},{"line_number":434,"context_line":"                     else vi.ii.disk_type)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vm_util.create_virtual_disk("}],"source_content_type":"text/x-python","patch_set":14,"id":"9aa7fdbe_86ac2037","line":433,"in_reply_to":"9aa7fdbe_46b5ef2f","updated":"2014-10-22 11:06:37.000000000","message":"It is not reversed. The sparse type is option only for disk cloning, not for disk creation, see:\n\nhttp://pubs.vmware.com/vsphere-55/index.jsp#com.vmware.wssdk.apiref.doc/vim.VirtualDiskManager.VirtualDiskType.html\n\nWe do the same for the primary disk, see _cache_sparse_image(), where we convert sparse images to preallocated.","commit_id":"21b815038f20b947d616f7175312928b0341e90b"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"30fe9bb5b8d03917707eb3804487b19bcd5fc929","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        path \u003d str(ds_util.DatastorePath(vi.datastore.name, instance.uuid,"},{"line_number":430,"context_line":"                                         filename))"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        disk_type \u003d (constants.DISK_TYPE_PREALLOCATED"},{"line_number":433,"context_line":"                     if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE"},{"line_number":434,"context_line":"                     else vi.ii.disk_type)"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_fc10944f","line":432,"updated":"2014-10-28 10:02:29.000000000","message":"I know you already answered this in a previous review comment, but this really needs a code comment. It looks like a bug, and I already can\u0027t remember what the explanation was.","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7d7f9ede31310a6ed04521399ab1ce4028473785","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        path \u003d str(ds_util.DatastorePath(vi.datastore.name, instance.uuid,"},{"line_number":430,"context_line":"                                         filename))"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        disk_type \u003d (constants.DISK_TYPE_PREALLOCATED"},{"line_number":433,"context_line":"                     if vi.ii.disk_type \u003d\u003d constants.DISK_TYPE_SPARSE"},{"line_number":434,"context_line":"                     else vi.ii.disk_type)"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_063fc3b4","line":432,"in_reply_to":"9aa7fdbe_fc10944f","updated":"2014-10-28 13:36:09.000000000","message":"Done","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"30fe9bb5b8d03917707eb3804487b19bcd5fc929","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vm_util.create_virtual_disk("},{"line_number":437,"context_line":"                self._session, vi.dc_info.ref,"},{"line_number":438,"context_line":"                vi.ii.adapter_type,"},{"line_number":439,"context_line":"                disk_type,"},{"line_number":440,"context_line":"                path,"},{"line_number":441,"context_line":"                size)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_9cf22804","line":438,"updated":"2014-10-28 10:02:29.000000000","message":"We should default adapter_type based on disk_bus from bdm if it\u0027s set.","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7d7f9ede31310a6ed04521399ab1ce4028473785","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        vm_util.create_virtual_disk("},{"line_number":437,"context_line":"                self._session, vi.dc_info.ref,"},{"line_number":438,"context_line":"                vi.ii.adapter_type,"},{"line_number":439,"context_line":"                disk_type,"},{"line_number":440,"context_line":"                path,"},{"line_number":441,"context_line":"                size)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_86881372","line":438,"in_reply_to":"9aa7fdbe_9cf22804","updated":"2014-10-28 13:36:09.000000000","message":"Done","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"30fe9bb5b8d03917707eb3804487b19bcd5fc929","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        ephemerals \u003d []"},{"line_number":450,"context_line":"        if bdi:"},{"line_number":451,"context_line":"            ephemerals \u003d driver.block_device_info_get_ephemerals(bdi)"},{"line_number":452,"context_line":"        if ephemerals:"},{"line_number":453,"context_line":"            for idx, eph in enumerate(ephemerals):"},{"line_number":454,"context_line":"                size \u003d eph[\u0027size\u0027] * units.Mi"},{"line_number":455,"context_line":"                filename \u003d \u0027ephemeral_%d_%s.vmdk\u0027 % (idx, eph[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_a8efab1c","line":452,"updated":"2014-10-28 10:02:29.000000000","message":"nit: no need to guard this as the for loop tests it implicitly anyway.\n\nIn fact, you could just do:\n\nif bdi is not None:\n  for idx, eph in enumerate(driver.block_device_info_get_ephemerals(bdi)):","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"30fe9bb5b8d03917707eb3804487b19bcd5fc929","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                filename \u003d \u0027ephemeral_%d_%s.vmdk\u0027 % (idx, eph[\u0027size\u0027])"},{"line_number":456,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":457,"context_line":"                                                       size, filename)"},{"line_number":458,"context_line":"        elif instance.ephemeral_gb:"},{"line_number":459,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":460,"context_line":"            filename \u003d \u0027ephemeral_disk.vmdk\u0027"},{"line_number":461,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_e8b293e3","line":458,"updated":"2014-10-28 10:02:29.000000000","message":"Libvirt puts this first. Hyper-V and Xen don\u0027t handle ephemerals in BDMs.\n\nI think this should go first.","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7d7f9ede31310a6ed04521399ab1ce4028473785","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                filename \u003d \u0027ephemeral_%d_%s.vmdk\u0027 % (idx, eph[\u0027size\u0027])"},{"line_number":456,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":457,"context_line":"                                                       size, filename)"},{"line_number":458,"context_line":"        elif instance.ephemeral_gb:"},{"line_number":459,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":460,"context_line":"            filename \u003d \u0027ephemeral_disk.vmdk\u0027"},{"line_number":461,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_c6adbb9c","line":458,"in_reply_to":"9aa7fdbe_e8b293e3","updated":"2014-10-28 13:36:09.000000000","message":"in libvirt the creation is first but that is only when there are no bdms configured. please look at:\n1. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2990\n2. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L540\n3. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L462","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"30fe9bb5b8d03917707eb3804487b19bcd5fc929","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                                                       size, filename)"},{"line_number":458,"context_line":"        elif instance.ephemeral_gb:"},{"line_number":459,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":460,"context_line":"            filename \u003d \u0027ephemeral_disk.vmdk\u0027"},{"line_number":461,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":462,"context_line":"                                                   size, filename)"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_08751763","line":460,"updated":"2014-10-28 10:02:29.000000000","message":"nit: I\u0027d name this consistently with the other disks.","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7d7f9ede31310a6ed04521399ab1ce4028473785","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                                                       size, filename)"},{"line_number":458,"context_line":"        elif instance.ephemeral_gb:"},{"line_number":459,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":460,"context_line":"            filename \u003d \u0027ephemeral_disk.vmdk\u0027"},{"line_number":461,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":462,"context_line":"                                                   size, filename)"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_e6df1f67","line":460,"in_reply_to":"9aa7fdbe_08751763","updated":"2014-10-28 13:36:09.000000000","message":"Done","commit_id":"51f3ba27c294312d35e272c82e95e8ed23db70c1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"39cf9553df99144c57a4488f6e3c0b9c2f0bc6f4","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                path, size, False)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _create_ephemeral(self, bdi, instance, vm_ref, vi):"},{"line_number":449,"context_line":"        ephemerals \u003d []"},{"line_number":450,"context_line":"        if bdi is not None:"},{"line_number":451,"context_line":"            ephemerals \u003d driver.block_device_info_get_ephemerals(bdi)"},{"line_number":452,"context_line":"            for idx, eph in enumerate(ephemerals):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_a7a3354e","line":449,"updated":"2014-10-29 12:05:50.000000000","message":"This isn\u0027t actually used.","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fddc3f8ea6bc0f594516ef8733d32de47ad8b86","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                path, size, False)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _create_ephemeral(self, bdi, instance, vm_ref, vi):"},{"line_number":449,"context_line":"        ephemerals \u003d []"},{"line_number":450,"context_line":"        if bdi is not None:"},{"line_number":451,"context_line":"            ephemerals \u003d driver.block_device_info_get_ephemerals(bdi)"},{"line_number":452,"context_line":"            for idx, eph in enumerate(ephemerals):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_fdef8ae7","line":449,"in_reply_to":"9aa7fdbe_a7a3354e","updated":"2014-10-29 12:32:03.000000000","message":"Done","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"39cf9553df99144c57a4488f6e3c0b9c2f0bc6f4","unresolved":false,"context_lines":[{"line_number":461,"context_line":"            filename \u003d \u0027ephemeral_0_%d.vmdk\u0027 % instance.ephemeral_gb"},{"line_number":462,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":463,"context_line":"                                                   size, vi.ii.adapter_type,"},{"line_number":464,"context_line":"                                                   filename)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def spawn(self, context, instance, image_meta, injected_files,"},{"line_number":467,"context_line":"              admin_password, network_info, block_device_info\u003dNone,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_274ae5ac","line":464,"updated":"2014-10-29 12:05:50.000000000","message":"Contrary to what I said before, after discussion with ndipanov and johnthetubaguy I think this is in fact the correct behaviour. The libvirt (in _create_image) is either broken, or not doing what I think. Sorry about that.","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fddc3f8ea6bc0f594516ef8733d32de47ad8b86","unresolved":false,"context_lines":[{"line_number":461,"context_line":"            filename \u003d \u0027ephemeral_0_%d.vmdk\u0027 % instance.ephemeral_gb"},{"line_number":462,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":463,"context_line":"                                                   size, vi.ii.adapter_type,"},{"line_number":464,"context_line":"                                                   filename)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def spawn(self, context, instance, image_meta, injected_files,"},{"line_number":467,"context_line":"              admin_password, network_info, block_device_info\u003dNone,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_9daf5e94","line":464,"in_reply_to":"9aa7fdbe_274ae5ac","updated":"2014-10-29 12:32:03.000000000","message":"np. this is why i was really concerned about adding the code. the whole logic in other drivers is convoluted","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"39cf9553df99144c57a4488f6e3c0b9c2f0bc6f4","unresolved":false,"context_lines":[{"line_number":529,"context_line":"                self._use_disk_image_as_full_clone(vm_ref, vi)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        # Create ephemeral disks"},{"line_number":532,"context_line":"        if instance.ephemeral_gb or block_device_info:"},{"line_number":533,"context_line":"            self._create_ephemeral(block_device_info, instance, vm_ref, vi)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        if configdrive.required_by(instance):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_a7ec1591","line":532,"updated":"2014-10-29 12:05:50.000000000","message":"nit: the guard is duplicated in _create_ephemeral. You could just call _create_ephemeral unconditionally.","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fddc3f8ea6bc0f594516ef8733d32de47ad8b86","unresolved":false,"context_lines":[{"line_number":529,"context_line":"                self._use_disk_image_as_full_clone(vm_ref, vi)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"        # Create ephemeral disks"},{"line_number":532,"context_line":"        if instance.ephemeral_gb or block_device_info:"},{"line_number":533,"context_line":"            self._create_ephemeral(block_device_info, instance, vm_ref, vi)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        if configdrive.required_by(instance):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_5dbed6d5","line":532,"in_reply_to":"9aa7fdbe_a7ec1591","updated":"2014-10-29 12:32:03.000000000","message":"i will remove this. in general i do not like to call a function and then check within the function. but maybe those optimizations can be dropped","commit_id":"79d08bba64430624a29822bf80ede331900698b2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bd852fb75c8af6099894ad33d69c395449798a14","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            for idx, eph in enumerate(ephemerals):"},{"line_number":452,"context_line":"                size \u003d eph[\u0027size\u0027] * units.Mi"},{"line_number":453,"context_line":"                adapter_type \u003d eph.get(\u0027disk_bus\u0027, vi.ii.adapter_type)"},{"line_number":454,"context_line":"                filename \u003d \u0027ephemeral_%d_%s.vmdk\u0027 % (idx, eph[\u0027size\u0027])"},{"line_number":455,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":456,"context_line":"                                                       size, adapter_type,"},{"line_number":457,"context_line":"                                                       filename)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a890539_22860666","line":454,"updated":"2014-11-12 16:04:03.000000000","message":"Why put the size in the filename? That seems overly complicated and potentially hard to predict later. Isn\u0027t the index enough for disambiguation?","commit_id":"8a5665fc23433c2005ee2459d4690a2b871dacfa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b65e5170cc56be2170ba5127ea40a744a2bca3fa","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            for idx, eph in enumerate(ephemerals):"},{"line_number":452,"context_line":"                size \u003d eph[\u0027size\u0027] * units.Mi"},{"line_number":453,"context_line":"                adapter_type \u003d eph.get(\u0027disk_bus\u0027, vi.ii.adapter_type)"},{"line_number":454,"context_line":"                filename \u003d \u0027ephemeral_%d_%s.vmdk\u0027 % (idx, eph[\u0027size\u0027])"},{"line_number":455,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":456,"context_line":"                                                       size, adapter_type,"},{"line_number":457,"context_line":"                                                       filename)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a890539_3ea7f10d","line":454,"in_reply_to":"5a890539_22860666","updated":"2014-11-13 06:48:56.000000000","message":"this is what libvirt does so we did it for consistency: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3059","commit_id":"8a5665fc23433c2005ee2459d4690a2b871dacfa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4e1a9df28c4d093ea5e04fd6d293ae364ff90481","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":452,"context_line":"                                                       size, adapter_type,"},{"line_number":453,"context_line":"                                                       filename)"},{"line_number":454,"context_line":"        elif instance.ephemeral_gb:"},{"line_number":455,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":456,"context_line":"            filename \u003d \u0027ephemeral_0_%d.vmdk\u0027 % instance.ephemeral_gb"},{"line_number":457,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a890539_669ddd09","line":454,"updated":"2014-11-26 13:23:33.000000000","message":"Not sure if this is correct.\n\nI think its if the ephemerals is empty, you want to do this if, not just if bdi is empty.\n\nYou might have a volume to attach, but no ephemerals to attach, I guess.","commit_id":"392c44ade6dcefd7a2afe794ef3b31d2600f2a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"afd3ce9812eb17a19e6adeb261c0b14e455ce1a7","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":452,"context_line":"                                                       size, adapter_type,"},{"line_number":453,"context_line":"                                                       filename)"},{"line_number":454,"context_line":"        elif instance.ephemeral_gb:"},{"line_number":455,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":456,"context_line":"            filename \u003d \u0027ephemeral_0_%d.vmdk\u0027 % instance.ephemeral_gb"},{"line_number":457,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a890539_c4d92984","line":454,"in_reply_to":"5a890539_4930f255","updated":"2014-11-26 14:03:08.000000000","message":"Done","commit_id":"392c44ade6dcefd7a2afe794ef3b31d2600f2a76"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6d3d9d9e0b8034c6860d803dccad9d1dd08b0d1e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":452,"context_line":"                                                       size, adapter_type,"},{"line_number":453,"context_line":"                                                       filename)"},{"line_number":454,"context_line":"        elif instance.ephemeral_gb:"},{"line_number":455,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":456,"context_line":"            filename \u003d \u0027ephemeral_0_%d.vmdk\u0027 % instance.ephemeral_gb"},{"line_number":457,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a890539_4930f255","line":454,"in_reply_to":"5a890539_49bf12d0","updated":"2014-11-26 13:43:51.000000000","message":"Maybe libvirt is wrong.\n\nYou can boot from volume, but still need to attach the ephemeral disk if there are no ephemerals inside the BDMs.","commit_id":"392c44ade6dcefd7a2afe794ef3b31d2600f2a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ab63d722ab89cb2b0549f9e3c31c2896b69337cf","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":452,"context_line":"                                                       size, adapter_type,"},{"line_number":453,"context_line":"                                                       filename)"},{"line_number":454,"context_line":"        elif instance.ephemeral_gb:"},{"line_number":455,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":456,"context_line":"            filename \u003d \u0027ephemeral_0_%d.vmdk\u0027 % instance.ephemeral_gb"},{"line_number":457,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a890539_49bf12d0","line":454,"in_reply_to":"5a890539_669ddd09","updated":"2014-11-26 13:38:35.000000000","message":"There are two cases. Either the ephemeral is received via the BDMS or it is to use the flavor configuration.\nThis is what is done in libvirt.","commit_id":"392c44ade6dcefd7a2afe794ef3b31d2600f2a76"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"31675e9c13e858463a74625290d32ed267ea78d1","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            for idx, eph in enumerate(ephemerals):"},{"line_number":449,"context_line":"                size \u003d eph[\u0027size\u0027] * units.Mi"},{"line_number":450,"context_line":"                adapter_type \u003d eph.get(\u0027disk_bus\u0027, vi.ii.adapter_type)"},{"line_number":451,"context_line":"                filename \u003d \u0027ephemeral_%d_%s.vmdk\u0027 % (idx, eph[\u0027size\u0027])"},{"line_number":452,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":453,"context_line":"                                                       size, adapter_type,"},{"line_number":454,"context_line":"                                                       filename)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a890539_7f3c80e1","line":451,"updated":"2014-11-26 14:47:26.000000000","message":"Just want to check, does this filename not have to be unique to this instance? or is that already covered by something else?","commit_id":"11ba6c8847bfdd30900ebdc6db3b734cb978feaf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e9201497133d5e53ef4222be2e58147259371bed","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            for idx, eph in enumerate(ephemerals):"},{"line_number":449,"context_line":"                size \u003d eph[\u0027size\u0027] * units.Mi"},{"line_number":450,"context_line":"                adapter_type \u003d eph.get(\u0027disk_bus\u0027, vi.ii.adapter_type)"},{"line_number":451,"context_line":"                filename \u003d \u0027ephemeral_%d_%s.vmdk\u0027 % (idx, eph[\u0027size\u0027])"},{"line_number":452,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":453,"context_line":"                                                       size, adapter_type,"},{"line_number":454,"context_line":"                                                       filename)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a890539_7a42ce0f","line":451,"in_reply_to":"5a890539_7f3c80e1","updated":"2014-11-26 14:55:12.000000000","message":"Apparently, this is unique to the instance already. So we should be fine.","commit_id":"11ba6c8847bfdd30900ebdc6db3b734cb978feaf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"31675e9c13e858463a74625290d32ed267ea78d1","unresolved":false,"context_lines":[{"line_number":459,"context_line":"            filename \u003d \u0027ephemeral_0_%d.vmdk\u0027 % instance.ephemeral_gb"},{"line_number":460,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":461,"context_line":"                                                   size, vi.ii.adapter_type,"},{"line_number":462,"context_line":"                                                   filename)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def spawn(self, context, instance, image_meta, injected_files,"},{"line_number":465,"context_line":"              admin_password, network_info, block_device_info\u003dNone,"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a890539_1f653c1d","line":462,"updated":"2014-11-26 14:47:26.000000000","message":"That looks good now.","commit_id":"11ba6c8847bfdd30900ebdc6db3b734cb978feaf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ad14d283800e3a8a8ea57752b37fb9ef8339bea","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                LOG.debug(\"Cleaning up location %s\", str(tmp_dir_loc))"},{"line_number":425,"context_line":"                self._delete_datastore_file(str(tmp_dir_loc), vi.dc_info.ref)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def _create_and_attach_ephemeral_disk(self, instance, vm_ref, vi, size,"},{"line_number":428,"context_line":"                                          adapter_type, filename):"},{"line_number":429,"context_line":"        path \u003d str(ds_util.DatastorePath(vi.datastore.name, instance.uuid,"},{"line_number":430,"context_line":"                                         filename))"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_5cf18900","line":427,"updated":"2014-11-26 17:34:16.000000000","message":"I would love to see a unit tests for this.","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aff4f8dd3c61a55ae759ed30ff4adea15d557ba0","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                LOG.debug(\"Cleaning up location %s\", str(tmp_dir_loc))"},{"line_number":425,"context_line":"                self._delete_datastore_file(str(tmp_dir_loc), vi.dc_info.ref)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def _create_and_attach_ephemeral_disk(self, instance, vm_ref, vi, size,"},{"line_number":428,"context_line":"                                          adapter_type, filename):"},{"line_number":429,"context_line":"        path \u003d str(ds_util.DatastorePath(vi.datastore.name, instance.uuid,"},{"line_number":430,"context_line":"                                         filename))"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_fc523534","line":427,"in_reply_to":"5a890539_5cf18900","updated":"2014-11-26 17:51:24.000000000","message":"this is tested - check out https://review.openstack.org/#/c/109432/27/nova/tests/unit/virt/vmwareapi/test_driver_api.py,cm line 665 etc.\nthey check all of the file names.","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ad14d283800e3a8a8ea57752b37fb9ef8339bea","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                vi.ii.adapter_type, disk_type,"},{"line_number":442,"context_line":"                path, size, False)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _get_ephemeral_name(self, id, size):"},{"line_number":445,"context_line":"        return \u0027ephemeral_%d_%s.vmdk\u0027 % (id, size)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def _create_ephemeral(self, bdi, instance, vm_ref, vi):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_fce1552b","line":444,"updated":"2014-11-26 17:34:16.000000000","message":"unit test for this?","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aff4f8dd3c61a55ae759ed30ff4adea15d557ba0","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                vi.ii.adapter_type, disk_type,"},{"line_number":442,"context_line":"                path, size, False)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _get_ephemeral_name(self, id, size):"},{"line_number":445,"context_line":"        return \u0027ephemeral_%d_%s.vmdk\u0027 % (id, size)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def _create_ephemeral(self, bdi, instance, vm_ref, vi):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_5c3989f1","line":444,"in_reply_to":"5a890539_fce1552b","updated":"2014-11-26 17:51:24.000000000","message":"ditto","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ad14d283800e3a8a8ea57752b37fb9ef8339bea","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    def _get_ephemeral_name(self, id, size):"},{"line_number":445,"context_line":"        return \u0027ephemeral_%d_%s.vmdk\u0027 % (id, size)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def _create_ephemeral(self, bdi, instance, vm_ref, vi):"},{"line_number":448,"context_line":"        ephemerals \u003d None"},{"line_number":449,"context_line":"        if bdi is not None:"},{"line_number":450,"context_line":"            ephemerals \u003d driver.block_device_info_get_ephemerals(bdi)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_3cd3dd60","line":447,"updated":"2014-11-26 17:34:16.000000000","message":"can we see a unit test for just this, that tests all the cases where _create_and_attach_ephemeral_disk is called?","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aff4f8dd3c61a55ae759ed30ff4adea15d557ba0","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    def _get_ephemeral_name(self, id, size):"},{"line_number":445,"context_line":"        return \u0027ephemeral_%d_%s.vmdk\u0027 % (id, size)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def _create_ephemeral(self, bdi, instance, vm_ref, vi):"},{"line_number":448,"context_line":"        ephemerals \u003d None"},{"line_number":449,"context_line":"        if bdi is not None:"},{"line_number":450,"context_line":"            ephemerals \u003d driver.block_device_info_get_ephemerals(bdi)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_3c1bdd81","line":447,"in_reply_to":"5a890539_3cd3dd60","updated":"2014-11-26 17:51:24.000000000","message":"there are same place as above","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ad14d283800e3a8a8ea57752b37fb9ef8339bea","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            for idx, eph in enumerate(ephemerals):"},{"line_number":452,"context_line":"                size \u003d eph[\u0027size\u0027] * units.Mi"},{"line_number":453,"context_line":"                adapter_type \u003d eph.get(\u0027disk_bus\u0027, vi.ii.adapter_type)"},{"line_number":454,"context_line":"                filename \u003d self. _get_ephemeral_name(idx, eph[\u0027size\u0027])"},{"line_number":455,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":456,"context_line":"                                                       size, adapter_type,"},{"line_number":457,"context_line":"                                                       filename)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_fcb3154b","line":454,"updated":"2014-11-26 17:34:16.000000000","message":"don\u0027t think you want the extra space here?","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aff4f8dd3c61a55ae759ed30ff4adea15d557ba0","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            for idx, eph in enumerate(ephemerals):"},{"line_number":452,"context_line":"                size \u003d eph[\u0027size\u0027] * units.Mi"},{"line_number":453,"context_line":"                adapter_type \u003d eph.get(\u0027disk_bus\u0027, vi.ii.adapter_type)"},{"line_number":454,"context_line":"                filename \u003d self. _get_ephemeral_name(idx, eph[\u0027size\u0027])"},{"line_number":455,"context_line":"                self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":456,"context_line":"                                                       size, adapter_type,"},{"line_number":457,"context_line":"                                                       filename)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_5c10a959","line":454,"in_reply_to":"5a890539_fcb3154b","updated":"2014-11-26 17:51:24.000000000","message":"Done","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ad14d283800e3a8a8ea57752b37fb9ef8339bea","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        # we need to allocate a ephemeral disk if required"},{"line_number":460,"context_line":"        if not ephemerals and instance.ephemeral_gb:"},{"line_number":461,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":462,"context_line":"            filename \u003d self. _get_ephemeral_name(0, instance.ephemeral_gb)"},{"line_number":463,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":464,"context_line":"                                                   size, vi.ii.adapter_type,"},{"line_number":465,"context_line":"                                                   filename)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_1c80e148","line":462,"updated":"2014-11-26 17:34:16.000000000","message":"and here?","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aff4f8dd3c61a55ae759ed30ff4adea15d557ba0","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        # we need to allocate a ephemeral disk if required"},{"line_number":460,"context_line":"        if not ephemerals and instance.ephemeral_gb:"},{"line_number":461,"context_line":"            size \u003d instance.ephemeral_gb * units.Mi"},{"line_number":462,"context_line":"            filename \u003d self. _get_ephemeral_name(0, instance.ephemeral_gb)"},{"line_number":463,"context_line":"            self._create_and_attach_ephemeral_disk(instance, vm_ref, vi,"},{"line_number":464,"context_line":"                                                   size, vi.ii.adapter_type,"},{"line_number":465,"context_line":"                                                   filename)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a890539_bc06ed1f","line":462,"in_reply_to":"5a890539_1c80e148","updated":"2014-11-26 17:51:24.000000000","message":"Done","commit_id":"11532c515c88733d0cade82a5d14421da19b4c8c"}]}
