)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1850d0bcce4b4c259b37e5c02ef938e81d71d606","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                    context.elevated(), instance[\u0027host\u0027])"},{"line_number":913,"context_line":"            is_up \u003d False"},{"line_number":914,"context_line":"            bdms \u003d self.db.block_device_mapping_get_all_by_instance("},{"line_number":915,"context_line":"                context, instance[\"uuid\"])"},{"line_number":916,"context_line":"            #Note(jogo): db allows for multiple compute services per host"},{"line_number":917,"context_line":"            for service in services:"},{"line_number":918,"context_line":"                if utils.service_is_up(service):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FKmk%3D","line":915,"updated":"2012-10-09 22:07:13.000000000","message":"This caught my eye as something I thought pep8 would complain about.  I thought this had to be at least 8 spaces indented.  If pep8 isn\u0027t complaining, oh well, fine with me I suppose.  But if you update this for some other reason, I guess you could change it.","commit_id":"d12f7838fa83207497fa5691e3e99e1e605477ce"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8f8b7686fcd5c3d7689c0344c0b1f8810d3bba7f","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                    context.elevated(), instance[\u0027host\u0027])"},{"line_number":913,"context_line":"            is_up \u003d False"},{"line_number":914,"context_line":"            bdms \u003d self.db.block_device_mapping_get_all_by_instance("},{"line_number":915,"context_line":"                context, instance[\"uuid\"])"},{"line_number":916,"context_line":"            #Note(jogo): db allows for multiple compute services per host"},{"line_number":917,"context_line":"            for service in services:"},{"line_number":918,"context_line":"                if utils.service_is_up(service):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FKH0%3D","line":915,"in_reply_to":"AAAALH%2F%2FKKo%3D","updated":"2012-10-10 15:13:33.000000000","message":"The most recent pep8 does seem to conflict with how Emacs\u0027 Python mode does some indentation.  That said, however, even the most recent pep8 accepts what you have here.\n\nWhere pep8 seems to complain is constructs like this:\n\n    foo \u003d bar([\n            \u0027element\u0027,\n            ])\n\n(Indented as Emacs would indent.)  Here pep8 will complain about the line containing \u0027element\u0027 being over-indented (it wants 4 spaces instead of 8) and about the line containing \u0027])\u0027 being over-indented (it wants that aligned with \u0027foo\u0027), i.e., the most recent pep8 wants:\n\n    foo \u003d bar([\n        \u0027element\u0027,\n    ])","commit_id":"d12f7838fa83207497fa5691e3e99e1e605477ce"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6a6fc88e1c2245591578cf49a3c3f55275501f3a","unresolved":false,"context_lines":[{"line_number":912,"context_line":"                    context.elevated(), instance[\u0027host\u0027])"},{"line_number":913,"context_line":"            is_up \u003d False"},{"line_number":914,"context_line":"            bdms \u003d self.db.block_device_mapping_get_all_by_instance("},{"line_number":915,"context_line":"                context, instance[\"uuid\"])"},{"line_number":916,"context_line":"            #Note(jogo): db allows for multiple compute services per host"},{"line_number":917,"context_line":"            for service in services:"},{"line_number":918,"context_line":"                if utils.service_is_up(service):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FKKo%3D","line":915,"in_reply_to":"AAAALH%2F%2FKmk%3D","updated":"2012-10-10 13:55:02.000000000","message":"It doesn\u0027t seem to complain about it to me. This is where Emacs\u0027 Python mode puts it, FWIW.","commit_id":"d12f7838fa83207497fa5691e3e99e1e605477ce"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1850d0bcce4b4c259b37e5c02ef938e81d71d606","unresolved":false,"context_lines":[{"line_number":925,"context_line":"                LOG.warning(_(\u0027host for instance is down, deleting from \u0027"},{"line_number":926,"context_line":"                        \u0027database\u0027), instance\u003dinstance)"},{"line_number":927,"context_line":"                self.db.instance_destroy(context, instance[\u0027uuid\u0027])"},{"line_number":928,"context_line":"            self.compute_rpcapi.terminate_instance(context, instance, bdms)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"            if reservations:"},{"line_number":931,"context_line":"                QUOTAS.commit(context, reservations)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FKmc%3D","line":928,"updated":"2012-10-09 22:07:13.000000000","message":"Why is this new terminate_instance() added here?","commit_id":"d12f7838fa83207497fa5691e3e99e1e605477ce"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c5b110338f43e114b3d3da4dbab13e8c9d961f58","unresolved":false,"context_lines":[{"line_number":925,"context_line":"                LOG.warning(_(\u0027host for instance is down, deleting from \u0027"},{"line_number":926,"context_line":"                        \u0027database\u0027), instance\u003dinstance)"},{"line_number":927,"context_line":"                self.db.instance_destroy(context, instance[\u0027uuid\u0027])"},{"line_number":928,"context_line":"            self.compute_rpcapi.terminate_instance(context, instance, bdms)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"            if reservations:"},{"line_number":931,"context_line":"                QUOTAS.commit(context, reservations)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FJac%3D","line":928,"in_reply_to":"AAAALH%2F%2FJ7k%3D","updated":"2012-10-11 13:10:02.000000000","message":"Yeah, sounds good.  Thanks.","commit_id":"d12f7838fa83207497fa5691e3e99e1e605477ce"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f79e474d71bf819ffdc9eca70e2eba4cc21b63a","unresolved":false,"context_lines":[{"line_number":925,"context_line":"                LOG.warning(_(\u0027host for instance is down, deleting from \u0027"},{"line_number":926,"context_line":"                        \u0027database\u0027), instance\u003dinstance)"},{"line_number":927,"context_line":"                self.db.instance_destroy(context, instance[\u0027uuid\u0027])"},{"line_number":928,"context_line":"            self.compute_rpcapi.terminate_instance(context, instance, bdms)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"            if reservations:"},{"line_number":931,"context_line":"                QUOTAS.commit(context, reservations)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FJ7k%3D","line":928,"in_reply_to":"AAAALH%2F%2FKKk%3D","updated":"2012-10-10 17:57:22.000000000","message":"Ah, yeah, this was mis-merged because of commit 77dd6a0b which addressed the bug of not being able to delete instances when their host node was down. For now, I propose leaving the \"if down, delete from DB\" logic in place, adding a comment about removing/converting it when nova-sink is available, and of course, cleaning up the extra terminate_instance() call.\n\nSound okay?","commit_id":"d12f7838fa83207497fa5691e3e99e1e605477ce"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6a6fc88e1c2245591578cf49a3c3f55275501f3a","unresolved":false,"context_lines":[{"line_number":925,"context_line":"                LOG.warning(_(\u0027host for instance is down, deleting from \u0027"},{"line_number":926,"context_line":"                        \u0027database\u0027), instance\u003dinstance)"},{"line_number":927,"context_line":"                self.db.instance_destroy(context, instance[\u0027uuid\u0027])"},{"line_number":928,"context_line":"            self.compute_rpcapi.terminate_instance(context, instance, bdms)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"            if reservations:"},{"line_number":931,"context_line":"                QUOTAS.commit(context, reservations)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FKKk%3D","line":928,"in_reply_to":"AAAALH%2F%2FKmc%3D","updated":"2012-10-10 13:55:02.000000000","message":"Hrm. Rebasing this to resubmit a week or so ago tore it up pretty badly, so I guess maybe it\u0027s fallout from that. I\u0027ll take a lookski.","commit_id":"d12f7838fa83207497fa5691e3e99e1e605477ce"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"3e6dca3c35eaaa9ea41e7360280652c88327d0f9","unresolved":false,"context_lines":[{"line_number":924,"context_line":"                # If compute node isn\u0027t up, just delete from DB"},{"line_number":925,"context_line":"                # NOTE(danms): This needs to be removed and forwarded"},{"line_number":926,"context_line":"                # to the dedicated database worker service, once it"},{"line_number":927,"context_line":"                # exists"},{"line_number":928,"context_line":"                LOG.warning(_(\u0027host for instance is down, deleting from \u0027"},{"line_number":929,"context_line":"                        \u0027database\u0027), instance\u003dinstance)"},{"line_number":930,"context_line":"                self.db.instance_destroy(context, instance[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAALH%2F%2FHzI%3D","line":927,"updated":"2012-10-15 00:16:43.000000000","message":"Actually, why would this get removed?  Is this code called by nova-compute?  Since it\u0027s in api.py my guess is that it\u0027s not.  I think getting rid of db access from nova-api isn\u0027t really going to be practical.","commit_id":"57453131551081106210f653c82351be8ccd6909"}],"nova/compute/manager.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fff3fcc7c7c250267bebbc639b2b83d44d438a3c","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        if not bdms:"},{"line_number":911,"context_line":"            bdms \u003d self._get_instance_volume_bdms(context, instance[\"uuid\"])"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        @utils.synchronized(instance_uuid)"},{"line_number":914,"context_line":"        def do_terminate_instance(instance, bdms):"},{"line_number":915,"context_line":"            try:"},{"line_number":916,"context_line":"                self._delete_instance(context, instance, bdms)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FzRg%3D","line":913,"updated":"2012-08-10 21:40:20.000000000","message":"This should be changed back to instance[\u0027uuid\u0027].  instance_uuid is most likely None here.  instance will always be set.","commit_id":"8ece30d15f81bd635bc7e5e28b139e9436703039"}]}