)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"3268d7bfc12bd8909d0d4eb90ab10a29a59bbf3e","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"    def _upsize_quota_delta(context, new_instance_type, old_instance_type):"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"        return API._resize_quota_delta(context, new_instance_type,"},{"line_number":1416,"context_line":"                                       old_instance_type, 1, 1)"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    @staticmethod"},{"line_number":1419,"context_line":"    def _reserve_quota_delta(context, deltas):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALH%2F%2Fx3w%3D","line":1416,"updated":"2012-08-13 13:53:23.000000000","message":"I\u0027m really struggling to keep the semantics of these two methods in my head. They really need some docs.\n\nHere\u0027s how I\u0027m thinking it throug:\n\n@compare \u003d\u003d 1 means only apply a positive delta\n\n@compare \u003d\u003d -1 means only apply a negative delta\n\n@sense \u003d\u003d 1 means apply new-old delta\n\n@sense \u003d\u003d -1 means apply old-new delta\n\nresize -\u003e @compare\u003d1, sense\u003d1 : only apply positive new-old delta\n\ndelete/confirm -\u003e @compare\u003d-1, sense\u003d1 : only apply negative new-old delta\n\nrevert -\u003e @compare\u003d-1, sense\u003d-1 : only apply negative old-new delta\n\nhow about calling the methods _positive_new_old_delta(), _negative_new_old_delta() and _negative_old_new_delta() ?","commit_id":"161cc777af5399a01db9908a0ebdfc411a04202e"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"862edf4d195eca7045362df419c101f6a0cfb331","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"    def _upsize_quota_delta(context, new_instance_type, old_instance_type):"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"        return API._resize_quota_delta(context, new_instance_type,"},{"line_number":1416,"context_line":"                                       old_instance_type, 1, 1)"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    @staticmethod"},{"line_number":1419,"context_line":"    def _reserve_quota_delta(context, deltas):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALH%2F%2Fxlo%3D","line":1416,"in_reply_to":"AAAALH%2F%2Fx3w%3D","updated":"2012-08-13 17:50:44.000000000","message":"I think I see the main point of potential confusion, the downsize method being used both to calculate the downsize delta and also to revert an upsize delta.\n\nSee if you like the latest version any better.","commit_id":"161cc777af5399a01db9908a0ebdfc411a04202e"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"3268d7bfc12bd8909d0d4eb90ab10a29a59bbf3e","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"        self.assertEqual(instance[\u0027vm_state\u0027], vm_states.ERROR)"},{"line_number":1193,"context_line":"        self.compute.terminate_instance(self.context,"},{"line_number":1194,"context_line":"                instance\u003djsonutils.to_primitive(instance))"},{"line_number":1195,"context_line":"        #self.assertTrue(False)"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"    def test_rebuild_instance_notification(self):"},{"line_number":1198,"context_line":"        \"\"\"Ensure notifications on instance migrate/resize\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALH%2F%2Fx4I%3D","line":1195,"updated":"2012-08-13 13:53:23.000000000","message":"spurious debug","commit_id":"161cc777af5399a01db9908a0ebdfc411a04202e"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"862edf4d195eca7045362df419c101f6a0cfb331","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"        self.assertEqual(instance[\u0027vm_state\u0027], vm_states.ERROR)"},{"line_number":1193,"context_line":"        self.compute.terminate_instance(self.context,"},{"line_number":1194,"context_line":"                instance\u003djsonutils.to_primitive(instance))"},{"line_number":1195,"context_line":"        #self.assertTrue(False)"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"    def test_rebuild_instance_notification(self):"},{"line_number":1198,"context_line":"        \"\"\"Ensure notifications on instance migrate/resize\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALH%2F%2FxmM%3D","line":1195,"in_reply_to":"AAAALH%2F%2Fx4I%3D","updated":"2012-08-13 17:50:44.000000000","message":"Good spot, fixed.","commit_id":"161cc777af5399a01db9908a0ebdfc411a04202e"}]}