)]}'
{"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"6726131c4a370c7f71c21310a31ca56067591c66","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    \"\"\"Represents a fixed ip for an instance.\"\"\""},{"line_number":669,"context_line":"    __tablename__ \u003d \u0027fixed_ips\u0027"},{"line_number":670,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":671,"context_line":"    address \u003d Column(String(255), unique\u003dTrue)"},{"line_number":672,"context_line":"    network_id \u003d Column(Integer, ForeignKey(\u0027networks.id\u0027), nullable\u003dTrue)"},{"line_number":673,"context_line":"    network \u003d relationship(Network, backref\u003dbackref(\u0027fixed_ips\u0027))"},{"line_number":674,"context_line":"    virtual_interface_id \u003d Column(Integer, ForeignKey(\u0027virtual_interfaces.id\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6nI%3D","line":671,"updated":"2011-10-26 14:23:17.000000000","message":"This should really be a composite constraint of (network_id, address) because more than one network could share the same 1918 address space.","commit_id":"f9face76ef242c50679e15c8c123fd01bb592f64"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"44a5d0c42d995c08f83ecf04f913ff14bf7dd124","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    \"\"\"Represents a fixed ip for an instance.\"\"\""},{"line_number":669,"context_line":"    __tablename__ \u003d \u0027fixed_ips\u0027"},{"line_number":670,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":671,"context_line":"    address \u003d Column(String(255), unique\u003dTrue)"},{"line_number":672,"context_line":"    network_id \u003d Column(Integer, ForeignKey(\u0027networks.id\u0027), nullable\u003dTrue)"},{"line_number":673,"context_line":"    network \u003d relationship(Network, backref\u003dbackref(\u0027fixed_ips\u0027))"},{"line_number":674,"context_line":"    virtual_interface_id \u003d Column(Integer, ForeignKey(\u0027virtual_interfaces.id\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6oU%3D","line":671,"updated":"2011-10-26 12:09:22.000000000","message":"While this will help to eliminate duplicates within the table, it will not guarantee duplicates across a deployment that contains multiple zones unless you can ensure that zones do not have overlapping cidrs available.","commit_id":"f9face76ef242c50679e15c8c123fd01bb592f64"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b2458db854713872889a4926a115891c0dcf5a52","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    \"\"\"Represents a fixed ip for an instance.\"\"\""},{"line_number":669,"context_line":"    __tablename__ \u003d \u0027fixed_ips\u0027"},{"line_number":670,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":671,"context_line":"    address \u003d Column(String(255), unique\u003dTrue)"},{"line_number":672,"context_line":"    network_id \u003d Column(Integer, ForeignKey(\u0027networks.id\u0027), nullable\u003dTrue)"},{"line_number":673,"context_line":"    network \u003d relationship(Network, backref\u003dbackref(\u0027fixed_ips\u0027))"},{"line_number":674,"context_line":"    virtual_interface_id \u003d Column(Integer, ForeignKey(\u0027virtual_interfaces.id\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6oM%3D","line":671,"in_reply_to":"AAAACX%2F%2F6oU%3D","updated":"2011-10-26 12:24:55.000000000","message":"I agree, but having duplicate addresses in the table currently makes Nova raise.\n\nSo it might be not enough, but it is at least the minimum.","commit_id":"f9face76ef242c50679e15c8c123fd01bb592f64"}]}