)]}'
{"nova/api/openstack/contrib/multinic.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"2a10220694b484460e6a45ed5cf771baf32fe73c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            address \u003d input_dict[\u0027removeFixedIp\u0027][\u0027address\u0027]"},{"line_number":97,"context_line":"            self.compute_api.remove_fixed_ip(req.environ[\u0027nova.context\u0027], id,"},{"line_number":98,"context_line":"                                             address)"},{"line_number":99,"context_line":"        except Exception, e:"},{"line_number":100,"context_line":"            LOG.exception(_(\"Error in removeFixedIp %s\"), e)"},{"line_number":101,"context_line":"            return faults.Fault(exc.HTTPBadRequest())"},{"line_number":102,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6RQ%3D","side":"PARENT","line":99,"updated":"2011-10-27 14:40:05.000000000","message":"What was the rationale behind removing the exception wrapping from the compute_api calls here?","commit_id":"1b7fba648aa3eb4cdda345237c9f77dc0b229329"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"dfebdf3ea2bb91716ae85c39b823aeffb7af4de2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            address \u003d input_dict[\u0027removeFixedIp\u0027][\u0027address\u0027]"},{"line_number":97,"context_line":"            self.compute_api.remove_fixed_ip(req.environ[\u0027nova.context\u0027], id,"},{"line_number":98,"context_line":"                                             address)"},{"line_number":99,"context_line":"        except Exception, e:"},{"line_number":100,"context_line":"            LOG.exception(_(\"Error in removeFixedIp %s\"), e)"},{"line_number":101,"context_line":"            return faults.Fault(exc.HTTPBadRequest())"},{"line_number":102,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6KQ%3D","side":"PARENT","line":99,"in_reply_to":"AAAACX%2F%2F6LM%3D","updated":"2011-10-27 17:26:15.000000000","message":"I do have a serious problem with it converting any exception into a BadRequest error. We should not be returning a 4xx error for all problems, even internal errors that should return a 5xx.\n\nThat said, there\u0027s the possibility that remove_fixed_ip fails in a way that legitimately should result in a BadRequest exception. Looking at the code, it might be possible to get a FixedIpNotFoundForSpecificInstance exception. It might be more appropriate to change the code to catch that when calling remove_fixed_ip and then raise BadRequest.\n\nI\u0027ll make that change and look at add_fixed_ip as well.","commit_id":"1b7fba648aa3eb4cdda345237c9f77dc0b229329"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ee75a880f278f90e6f575212422cad23c6eaa66c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            address \u003d input_dict[\u0027removeFixedIp\u0027][\u0027address\u0027]"},{"line_number":97,"context_line":"            self.compute_api.remove_fixed_ip(req.environ[\u0027nova.context\u0027], id,"},{"line_number":98,"context_line":"                                             address)"},{"line_number":99,"context_line":"        except Exception, e:"},{"line_number":100,"context_line":"            LOG.exception(_(\"Error in removeFixedIp %s\"), e)"},{"line_number":101,"context_line":"            return faults.Fault(exc.HTTPBadRequest())"},{"line_number":102,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6LM%3D","side":"PARENT","line":99,"in_reply_to":"AAAACX%2F%2F6Qk%3D","updated":"2011-10-27 16:56:59.000000000","message":"I\u0027m more concerned about any errors coming out of remove_fixed_ip. I\u0027m all for moving the HTTPUnprocessableEntity out.","commit_id":"1b7fba648aa3eb4cdda345237c9f77dc0b229329"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"71e62f13c500573439963c616e9d1125d1ce9a99","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            address \u003d input_dict[\u0027removeFixedIp\u0027][\u0027address\u0027]"},{"line_number":97,"context_line":"            self.compute_api.remove_fixed_ip(req.environ[\u0027nova.context\u0027], id,"},{"line_number":98,"context_line":"                                             address)"},{"line_number":99,"context_line":"        except Exception, e:"},{"line_number":100,"context_line":"            LOG.exception(_(\"Error in removeFixedIp %s\"), e)"},{"line_number":101,"context_line":"            return faults.Fault(exc.HTTPBadRequest())"},{"line_number":102,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6Qk%3D","side":"PARENT","line":99,"in_reply_to":"AAAACX%2F%2F6RQ%3D","updated":"2011-10-27 16:21:07.000000000","message":"Because it raises an exception, immediately catches and it and then raises a different exception. The correct exception to raise here is HTTPUnprocessableEntity, not HTTPBadRequest.","commit_id":"1b7fba648aa3eb4cdda345237c9f77dc0b229329"}]}