)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"274a3e26cfb324600f0150e04b297320fba5a4f2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"compute nodes to use the same cache folder on the backend datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"NOTE: this can only be done when the compute nodes are running on the"},{"line_number":13,"context_line":"same host or the compute nodes have a shared file system."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"   New variable - cache_prefix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_8b78ea2c","line":13,"updated":"2014-08-26 10:00:47.000000000","message":"Can we please have a little more detail on WHY thats the case here?\n(given we have no blueprint to store that info.)\n\nSeems like we need to talk about how the lock works on a single host, so you can share a single directory.\n\nSeems like we also mention, if we use a shared file system (with certain atomic operations, like file create/delete) then you can make those locks work between multiple hosts, give you save the nova lock files into that shared file system, etc.\n\nwithout that, its hard to understand the use cases here.","commit_id":"01e7719f40b6acc77ec6b0cf0c4536ff6708390a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"705db706c0bd2b144c3e98d76bcacd9d72942d59","unresolved":false,"context_lines":[{"line_number":10,"context_line":"compute nodes to use the same cache folder on the backend datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"NOTE: this can only be done when the compute nodes are running on the"},{"line_number":13,"context_line":"same host or the compute nodes have a shared file system."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"   New variable - cache_prefix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_1c78708e","line":13,"in_reply_to":"1abeadc6_8b78ea2c","updated":"2014-08-27 09:14:25.000000000","message":"Done","commit_id":"01e7719f40b6acc77ec6b0cf0c4536ff6708390a"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4f4ad46660207122aacbcc359191f5f2a7d87d45","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                    CONF.image_cache_subdirectory_name)"},{"line_number":116,"context_line":"        # Ensure that the base folder is unique per compute node"},{"line_number":117,"context_line":"        elif CONF.remove_unused_base_images:"},{"line_number":118,"context_line":"            base_folder \u003d \u0027%s%s\u0027 % (CONF.my_ip,"},{"line_number":119,"context_line":"                                    CONF.image_cache_subdirectory_name)"},{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            # Aging disable ensures backward compatibility"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_e817a452","line":118,"updated":"2014-08-26 09:41:53.000000000","message":"Surely if you had used CONF.host here, this would work when you run multiple computes on the same node?\n\nAdding an extra config for this case seems bad to me.","commit_id":"01e7719f40b6acc77ec6b0cf0c4536ff6708390a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9f5f03661903627fa6ef382c45a5c8649b6fc047","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                    CONF.image_cache_subdirectory_name)"},{"line_number":116,"context_line":"        # Ensure that the base folder is unique per compute node"},{"line_number":117,"context_line":"        elif CONF.remove_unused_base_images:"},{"line_number":118,"context_line":"            base_folder \u003d \u0027%s%s\u0027 % (CONF.my_ip,"},{"line_number":119,"context_line":"                                    CONF.image_cache_subdirectory_name)"},{"line_number":120,"context_line":"        else:"},{"line_number":121,"context_line":"            # Aging disable ensures backward compatibility"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_068db131","line":118,"in_reply_to":"1abeadc6_e817a452","updated":"2014-08-26 10:17:49.000000000","message":"hang on, thats rubbish, ignore that idea.\n\nI kinda think if we want CONF.image_cache_subdirectory_name to mean the same for vmware and libvirt, if possible.\n\nIf we added a CONF.vmware.make_cache_folder_unique that controlled if you add the my_ip to the CONF.image_cache_subdirectory_name, it would be much simpler.\n\nAdmins that want to share the folder, then just set CONF.vmware.make_cache_folder_unique\u003dFalse, then they configure the cache directly, just like libvirt folks, by configuring CONF.image_cache_subdirectory_name","commit_id":"01e7719f40b6acc77ec6b0cf0c4536ff6708390a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"afe50d10f2f4619a657767bf707732cc69128c4c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Enable more than one compute node to run on the same host"},{"line_number":110,"context_line":"        if CONF.vmware.cache_prefix:"},{"line_number":111,"context_line":"            base_folder \u003d \u0027%s%s\u0027 % (CONF.vmware.cache_prefix,"},{"line_number":112,"context_line":"                                    CONF.image_cache_subdirectory_name)"},{"line_number":113,"context_line":"        # Ensure that the base folder is unique per compute node"},{"line_number":114,"context_line":"        elif CONF.remove_unused_base_images:"},{"line_number":115,"context_line":"            base_folder \u003d \u0027%s%s\u0027 % (CONF.my_ip,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_ed3780ae","line":112,"updated":"2014-08-27 10:30:21.000000000","message":"I am not a fan of how complex this makes describing what CONF.image_cache_subdirectory_name really means.","commit_id":"44177a91659063b9a5ac174e3b6ce7952f521fc9"}]}