)]}'
{"nova/api/openstack/volume/volumes.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"f39ab44140bd19b9500016672158119d905a9988","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                return s"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # NOTE(eglynn): we\u0027re tolerant of non-int sizes here, as type"},{"line_number":229,"context_line":"        # integrity is enforced later in the creation codepath"},{"line_number":230,"context_line":"        size \u003d as_int(volume[\u0027size\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        LOG.audit(_(\"Create volume of %s GB\"), size, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FwJg%3D","line":229,"updated":"2012-08-14 18:36:34.000000000","message":"don\u0027t understand the value of this? Why not just fail here if it can\u0027t be converted? Maybe i missed some earlier conversation here...","commit_id":"3b6207976a51d33ee2ec701d21fa2a0cc6eca2e8"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"a02dcb580842df447a2371e1706110365e03bb9e","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                return s"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # NOTE(eglynn): we\u0027re tolerant of non-int sizes here, as type"},{"line_number":229,"context_line":"        # integrity is enforced later in the creation codepath"},{"line_number":230,"context_line":"        size \u003d as_int(volume[\u0027size\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        LOG.audit(_(\"Create volume of %s GB\"), size, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FwIQ%3D","line":229,"in_reply_to":"AAAALH%2F%2FwJg%3D","updated":"2012-08-14 18:49:17.000000000","message":"You\u0027re right, Duncan Thomas made a similar point in the original review:\n\n  https://review.openstack.org/10540\n\nSince an identical patch has already landed in cinder, the intention was to simply get nova-vol lined up with cinder and then address the location of the validation logic in a subsequent patch applied to both code-bases.","commit_id":"3b6207976a51d33ee2ec701d21fa2a0cc6eca2e8"}]}