)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"13e87da01fd3c8bfb7f26915044229e22eb32741","unresolved":false,"context_lines":[{"line_number":21,"context_line":"This allows the operation to be atomic. I know this is sorta hackish that"},{"line_number":22,"context_line":"we\u0027re doing this in the api layer but we do this in a few other places"},{"line_number":23,"context_line":"too fwiw."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I53b0c9d949404288e8687b304361a74b53d69ef3"},{"line_number":26,"context_line":"Closes-bug: 1356157"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_e419b825","line":24,"updated":"2014-08-13 02:35:40.000000000","message":"mean\u0027t to also say this patch adds additional code coverage for nova-network in delete floatingip too but meh.","commit_id":"fd45217025ffcb7ed8606d9d2b8c579d78945423"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd97cb56fe95d7abcf9a708d66e9354bc741d028","unresolved":false,"context_lines":[{"line_number":20,"context_line":"rather than putting the logic in the api layer to do something differently"},{"line_number":21,"context_line":"if one is using neutron."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch also adds additional code coverage for nova-network in the"},{"line_number":24,"context_line":"delete floatingip case."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-bug: 1356157"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7ac7a964_d6a9e425","line":23,"updated":"2014-08-13 21:37:25.000000000","message":"Is this the new 403 exception handling? If so, is that needed to fix the bug because if it\u0027s not, let\u0027s do that separately (since it should also be tested).","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17c960e39ff93cc77680c4896ca385673d6e46b1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"rather than putting the logic in the api layer to do something differently"},{"line_number":21,"context_line":"if one is using neutron."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch also adds additional code coverage for nova-network in the"},{"line_number":24,"context_line":"delete floatingip case."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-bug: 1356157"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7ac7a964_958d777e","line":23,"in_reply_to":"7ac7a964_d6a9e425","updated":"2014-08-14 17:50:38.000000000","message":"Nevermind.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"}],"nova/api/openstack/compute/contrib/floating_ips.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"430588a3b54cb720fa64d9251966c82002bb3ee4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # If using nova-network disassociate if associated. Neutron allows"},{"line_number":195,"context_line":"        # us to delete floating ips even if they are associated. We do this"},{"line_number":196,"context_line":"        # because it allows us to do this atomically"},{"line_number":197,"context_line":"        if not utils.is_neutron() and floating_ip.get(\u0027fixed_ip_id\u0027):"},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                disassociate_floating_ip(self, context, instance, address)"},{"line_number":200,"context_line":"            except exception.FloatingIpNotAssociated:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_9745829d","line":197,"updated":"2014-08-13 09:03:51.000000000","message":"this is fine, but it leads to a situation where release_floating_ip has different semantics with or without neutron (see comment on nova/network/neutronv2/api.py).\n\nI tend to think we could be better off by simplifying this method skipping the disassociate part and calling something like\n\nself.network_api.release_floating_ip(context, address, disassociate\u003dTrue)","commit_id":"f264b561d9b36e6fcd22e8799367041528a15ab3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d7d3433c6a7b03689f42149eae59c0a46c8343e9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # If using nova-network disassociate if associated. Neutron allows"},{"line_number":195,"context_line":"        # us to delete floating ips even if they are associated. We do this"},{"line_number":196,"context_line":"        # because it allows us to do this atomically"},{"line_number":197,"context_line":"        if not utils.is_neutron() and floating_ip.get(\u0027fixed_ip_id\u0027):"},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                disassociate_floating_ip(self, context, instance, address)"},{"line_number":200,"context_line":"            except exception.FloatingIpNotAssociated:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ab29df4_005f8c0f","line":197,"in_reply_to":"9ab29df4_40042415","updated":"2014-08-13 19:47:30.000000000","message":"Caveat would be backporting the fix, base_api is new in Juno so we can\u0027t backport that.  Maybe we have to do this one-off and then do a base_api long-term fix in Juno after this.","commit_id":"f264b561d9b36e6fcd22e8799367041528a15ab3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ba387ad6788640d7b550126bbac52083232f8d0b","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # If using nova-network disassociate if associated. Neutron allows"},{"line_number":195,"context_line":"        # us to delete floating ips even if they are associated. We do this"},{"line_number":196,"context_line":"        # because it allows us to do this atomically"},{"line_number":197,"context_line":"        if not utils.is_neutron() and floating_ip.get(\u0027fixed_ip_id\u0027):"},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                disassociate_floating_ip(self, context, instance, address)"},{"line_number":200,"context_line":"            except exception.FloatingIpNotAssociated:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_a6c24152","line":197,"in_reply_to":"baada198_5012fb61","updated":"2014-08-13 18:13:36.000000000","message":"So, how about we add a new network_api method called \"disassocite_and_delete()\". For nova-network, it will just call these two things in order like we do today. For neutron, it will do only the second thing. That way we keep the same level of abstraction of it being a network api method we expect to be atomic from the POV of this code.\n\nThoughts?","commit_id":"f264b561d9b36e6fcd22e8799367041528a15ab3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"d96b2dd3c9ed8cb0333d73804f55804b82eaa3f1","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # If using nova-network disassociate if associated. Neutron allows"},{"line_number":195,"context_line":"        # us to delete floating ips even if they are associated. We do this"},{"line_number":196,"context_line":"        # because it allows us to do this atomically"},{"line_number":197,"context_line":"        if not utils.is_neutron() and floating_ip.get(\u0027fixed_ip_id\u0027):"},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                disassociate_floating_ip(self, context, instance, address)"},{"line_number":200,"context_line":"            except exception.FloatingIpNotAssociated:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_5012fb61","line":197,"in_reply_to":"baada198_9745829d","updated":"2014-08-13 17:43:09.000000000","message":"I agree we could do something like that but i\u0027m hesitant to want to add this extra argument because we\u0027ll need to figure out how to implement this in one atomic operation for nova-network which i rather not do.","commit_id":"f264b561d9b36e6fcd22e8799367041528a15ab3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2dde94992c5cd5bfa43211eae29d200227631f12","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # If using nova-network disassociate if associated. Neutron allows"},{"line_number":195,"context_line":"        # us to delete floating ips even if they are associated. We do this"},{"line_number":196,"context_line":"        # because it allows us to do this atomically"},{"line_number":197,"context_line":"        if not utils.is_neutron() and floating_ip.get(\u0027fixed_ip_id\u0027):"},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                disassociate_floating_ip(self, context, instance, address)"},{"line_number":200,"context_line":"            except exception.FloatingIpNotAssociated:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ab29df4_40042415","line":197,"in_reply_to":"baada198_a6c24152","updated":"2014-08-13 19:45:41.000000000","message":"Agree, we don\u0027t want is_neutron branch logic in the compute API code.\n\nThis is why we have nova.network.base_api now.","commit_id":"f264b561d9b36e6fcd22e8799367041528a15ab3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd97cb56fe95d7abcf9a708d66e9354bc741d028","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        try:"},{"line_number":193,"context_line":"            self.network_api.disassocate_and_delete(context, instance,"},{"line_number":194,"context_line":"                                                    floating_ip)"},{"line_number":195,"context_line":"        except exception.Forbidden:"},{"line_number":196,"context_line":"            raise webob.exc.HTTPForbidden()"},{"line_number":197,"context_line":"        except exception.CannotDisassociateAutoAssignedFloatingIP:"},{"line_number":198,"context_line":"            msg \u003d _(\u0027Cannot disassociate auto assigned floating ip\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_5635d444","line":195,"updated":"2014-08-13 21:37:25.000000000","message":"The new exception handling here is not relevant to the bug fix, right?","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b1e39fbe5c8e2eb2a0b3ee35f1e1ba3ec54df499","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        try:"},{"line_number":193,"context_line":"            self.network_api.disassocate_and_delete(context, instance,"},{"line_number":194,"context_line":"                                                    floating_ip)"},{"line_number":195,"context_line":"        except exception.Forbidden:"},{"line_number":196,"context_line":"            raise webob.exc.HTTPForbidden()"},{"line_number":197,"context_line":"        except exception.CannotDisassociateAutoAssignedFloatingIP:"},{"line_number":198,"context_line":"            msg \u003d _(\u0027Cannot disassociate auto assigned floating ip\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_99407f37","line":195,"in_reply_to":"7ac7a964_5635d444","updated":"2014-08-13 21:45:04.000000000","message":"This exception handling was done previously in disassociate_floating_ip() line 91 above. Now that  self.network_api.disassociate_floating_ip(context, instance, address) is called in         self.network_api.disassocate_and_delete() we need to move the exception handing. \n\nI can\u0027t delete  disassociate_floating_ip() as other code in this file are still using this method.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17c960e39ff93cc77680c4896ca385673d6e46b1","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        try:"},{"line_number":193,"context_line":"            self.network_api.disassocate_and_delete(context, instance,"},{"line_number":194,"context_line":"                                                    floating_ip)"},{"line_number":195,"context_line":"        except exception.Forbidden:"},{"line_number":196,"context_line":"            raise webob.exc.HTTPForbidden()"},{"line_number":197,"context_line":"        except exception.CannotDisassociateAutoAssignedFloatingIP:"},{"line_number":198,"context_line":"            msg \u003d _(\u0027Cannot disassociate auto assigned floating ip\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_1582474f","line":195,"in_reply_to":"7ac7a964_99407f37","updated":"2014-08-14 17:50:38.000000000","message":"Ah right, good call.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd97cb56fe95d7abcf9a708d66e9354bc741d028","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                                                    floating_ip)"},{"line_number":195,"context_line":"        except exception.Forbidden:"},{"line_number":196,"context_line":"            raise webob.exc.HTTPForbidden()"},{"line_number":197,"context_line":"        except exception.CannotDisassociateAutoAssignedFloatingIP:"},{"line_number":198,"context_line":"            msg \u003d _(\u0027Cannot disassociate auto assigned floating ip\u0027)"},{"line_number":199,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003dmsg)"},{"line_number":200,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_763ad037","line":197,"updated":"2014-08-13 21:37:25.000000000","message":"ditto","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"afc4feb439c1a0bab4154bae5a918cc76769d69a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return self.compute_api.get(context, instance_id)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def disassociate_floating_ip(self, context, instance, address):"},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        self.network_api.disassociate_floating_ip(context, instance, address)"},{"line_number":95,"context_line":"    except exception.Forbidden:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_b38986cc","line":92,"updated":"2014-08-19 14:17:51.000000000","message":"I think you can delete this function now, right? Does anything else use it?","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"826e993342f5584116643341620b35f64be46172","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return self.compute_api.get(context, instance_id)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def disassociate_floating_ip(self, context, instance, address):"},{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        self.network_api.disassociate_floating_ip(context, instance, address)"},{"line_number":95,"context_line":"    except exception.Forbidden:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_ae0d39ea","line":92,"in_reply_to":"1abeadc6_b38986cc","updated":"2014-08-21 21:45:14.000000000","message":"see matts comment below.","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8765c5c1d7149e5105ed9540aab493612176ae7b","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            (uuidutils.is_uuid_like(id) and"},{"line_number":305,"context_line":"             [instance[\u0027uuid\u0027] \u003d\u003d id] or"},{"line_number":306,"context_line":"             [instance[\u0027id\u0027] \u003d\u003d id])[0]):"},{"line_number":307,"context_line":"            try:"},{"line_number":308,"context_line":"                disassociate_floating_ip(self, context, instance, address)"},{"line_number":309,"context_line":"            except exception.FloatingIpNotAssociated:"},{"line_number":310,"context_line":"                msg \u003d _(\u0027Floating ip is not associated\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_3c30e39d","line":307,"updated":"2014-08-19 14:58:20.000000000","message":"@Dan, yeah it\u0027s used here.","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"826e993342f5584116643341620b35f64be46172","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            (uuidutils.is_uuid_like(id) and"},{"line_number":305,"context_line":"             [instance[\u0027uuid\u0027] \u003d\u003d id] or"},{"line_number":306,"context_line":"             [instance[\u0027id\u0027] \u003d\u003d id])[0]):"},{"line_number":307,"context_line":"            try:"},{"line_number":308,"context_line":"                disassociate_floating_ip(self, context, instance, address)"},{"line_number":309,"context_line":"            except exception.FloatingIpNotAssociated:"},{"line_number":310,"context_line":"                msg \u003d _(\u0027Floating ip is not associated\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_2e6a0981","line":307,"in_reply_to":"1abeadc6_3c30e39d","updated":"2014-08-21 21:45:14.000000000","message":"yup","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"}],"nova/network/api.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6ed99bd75d08364b1b211cd873613dbcdc99b253","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        return self.floating_manager.deallocate_floating_ip(context, address,"},{"line_number":176,"context_line":"                 affect_auto_assigned)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def disassocate_and_delete_floating_ip(self, context, instance,"},{"line_number":179,"context_line":"                                           floating_ip):"},{"line_number":180,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip."},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_0eb028f3","line":178,"updated":"2014-08-20 11:17:33.000000000","message":"I\u0027ve found my pedant note for you:\n\nFor consistency this method should be called disassociate_and_release_floating_ip","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"826e993342f5584116643341620b35f64be46172","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        return self.floating_manager.deallocate_floating_ip(context, address,"},{"line_number":176,"context_line":"                 affect_auto_assigned)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def disassocate_and_delete_floating_ip(self, context, instance,"},{"line_number":179,"context_line":"                                           floating_ip):"},{"line_number":180,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip."},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_4eeca5f3","line":178,"in_reply_to":"1abeadc6_0eb028f3","updated":"2014-08-21 21:45:14.000000000","message":"find . -name \"*.py\" -print | xargs sed -i \u0027s/disassocate_and_delete_floating_ip/disassociate_and_release_floating_ip/g\u0027\n \nBOOM","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"}],"nova/network/base_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17c960e39ff93cc77680c4896ca385673d6e46b1","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        \"\"\"Removes (deallocates) a floating ip with address from a project.\"\"\""},{"line_number":154,"context_line":"        raise NotImplementedError()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":157,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":158,"context_line":"        raise NotImplementedError()"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_55f67fd8","line":156,"updated":"2014-08-14 17:50:38.000000000","message":"We should probably name this method \u0027disassociate_and_delete_floating_ip\u0027 to be consistent with disassociate_floating_ip and release_floating_ip methods.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f05d6fb5b267c8bcf07304fa9f549404936861d3","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        \"\"\"Removes (deallocates) a floating ip with address from a project.\"\"\""},{"line_number":154,"context_line":"        raise NotImplementedError()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":157,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":158,"context_line":"        raise NotImplementedError()"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_02df360e","line":156,"in_reply_to":"7ac7a964_229b5573","updated":"2014-08-15 21:08:36.000000000","message":"Done","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"66d301e5f4b758d37d55f82701db2884ffae7dd8","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        \"\"\"Removes (deallocates) a floating ip with address from a project.\"\"\""},{"line_number":154,"context_line":"        raise NotImplementedError()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":157,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":158,"context_line":"        raise NotImplementedError()"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_229b5573","line":156,"in_reply_to":"7ac7a964_55f67fd8","updated":"2014-08-15 19:29:28.000000000","message":"Yeah, because we have disassociate() which is for networks.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17c960e39ff93cc77680c4896ca385673d6e46b1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        raise NotImplementedError()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":157,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":158,"context_line":"        raise NotImplementedError()"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def associate_floating_ip(self, context, instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_b5a193ab","line":157,"updated":"2014-08-14 17:50:38.000000000","message":"Should we add something to the docstring that explains why/when you\u0027d use this over just calling disassociate and then release, i.e. this is an atomic operation and the others aren\u0027t.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f05d6fb5b267c8bcf07304fa9f549404936861d3","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        raise NotImplementedError()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":157,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":158,"context_line":"        raise NotImplementedError()"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def associate_floating_ip(self, context, instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_42004e67","line":157,"in_reply_to":"7ac7a964_b5a193ab","updated":"2014-08-15 21:08:36.000000000","message":"Done","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f6035ae481f47cef2836318bba63c2ff2c55e3f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                                           floating_ip):"},{"line_number":158,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        This api call was added to allow this to be done in one operation"},{"line_number":161,"context_line":"        if using neutron."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_7c17ad51","line":160,"updated":"2014-08-16 01:19:52.000000000","message":"I won\u0027t -1 over this, but in the base class it seems wrong to mention one of the concrete implementations (neutron) as the reason for this, it should be enough just to say this is for the atomic disassociate and release/delete of the floating IP.","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6ed99bd75d08364b1b211cd873613dbcdc99b253","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                                           floating_ip):"},{"line_number":158,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        This api call was added to allow this to be done in one operation"},{"line_number":161,"context_line":"        if using neutron."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_2efa44bd","line":160,"in_reply_to":"1abeadc6_537d92e6","updated":"2014-08-20 11:17:33.000000000","message":"double meh ;)","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"826e993342f5584116643341620b35f64be46172","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                                           floating_ip):"},{"line_number":158,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        This api call was added to allow this to be done in one operation"},{"line_number":161,"context_line":"        if using neutron."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_6b5e2e47","line":160,"in_reply_to":"7ac7a964_7c17ad51","updated":"2014-08-21 21:45:14.000000000","message":"Done","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"afc4feb439c1a0bab4154bae5a918cc76769d69a","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                                           floating_ip):"},{"line_number":158,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        This api call was added to allow this to be done in one operation"},{"line_number":161,"context_line":"        if using neutron."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_537d92e6","line":160,"in_reply_to":"7ac7a964_7c17ad51","updated":"2014-08-19 14:17:51.000000000","message":"Meh :)","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"430588a3b54cb720fa64d9251966c82002bb3ee4","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"        client \u003d neutronv2.get_client(context)"},{"line_number":1080,"context_line":"        fip \u003d self._get_floating_ip_by_address(client, address)"},{"line_number":1081,"context_line":"        if fip[\u0027port_id\u0027]:"},{"line_number":1082,"context_line":"            raise exception.FloatingIpAssociated(address\u003daddress)"},{"line_number":1083,"context_line":"        client.delete_floatingip(fip[\u0027id\u0027])"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    @base_api.refresh_cache"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_97d2e2fb","side":"PARENT","line":1082,"updated":"2014-08-13 09:03:51.000000000","message":"This might be the only contentious point in this patch.\n\nThis change indeed is causing the behaviour of release_floating_ip to differ in nova.network.api and nova.network.neutronv2.api\n\nThe former will raise is the floatingip has an associated fixed ip","commit_id":"f585fd6e7023bf965cc1256183efcb1e8ecd2758"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"d96b2dd3c9ed8cb0333d73804f55804b82eaa3f1","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"        client \u003d neutronv2.get_client(context)"},{"line_number":1080,"context_line":"        fip \u003d self._get_floating_ip_by_address(client, address)"},{"line_number":1081,"context_line":"        if fip[\u0027port_id\u0027]:"},{"line_number":1082,"context_line":"            raise exception.FloatingIpAssociated(address\u003daddress)"},{"line_number":1083,"context_line":"        client.delete_floatingip(fip[\u0027id\u0027])"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    @base_api.refresh_cache"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_306827f4","side":"PARENT","line":1082,"in_reply_to":"baada198_97d2e2fb","updated":"2014-08-13 17:43:09.000000000","message":"I do agree this is a little weird per say though  from a nova api perspective they have an api call to delete a floating_ip which is able to do that if a floating ip is associated. Internally they release it first then delete it. If using neutron we don\u0027t have to release it first and can just delete it. It sucks because it takes multiple calls to neutron to achieve the same thing which is gets us in this mess if something fails. Lets see what others thing. I\u0027m not really sure of an alternative approach to fix this call to make sure we don\u0027t put the system in a bad state though do you?","commit_id":"f585fd6e7023bf965cc1256183efcb1e8ecd2758"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd97cb56fe95d7abcf9a708d66e9354bc741d028","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"            raise exception.FloatingIpAssociated(address\u003daddress)"},{"line_number":1083,"context_line":"        client.delete_floatingip(fip[\u0027id\u0027])"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":1086,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":1087,"context_line":"        client \u003d neutronv2.get_client(context)"},{"line_number":1088,"context_line":"        fip \u003d self._get_floating_ip_by_address(client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_f68fc0ca","line":1085,"updated":"2014-08-13 21:37:25.000000000","message":"This is very similar to release_floating_ip above, can that be re-used?  Or does the fip[\u0027port_id\u0027] check get in the way?","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f05d6fb5b267c8bcf07304fa9f549404936861d3","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"            raise exception.FloatingIpAssociated(address\u003daddress)"},{"line_number":1083,"context_line":"        client.delete_floatingip(fip[\u0027id\u0027])"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":1086,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":1087,"context_line":"        client \u003d neutronv2.get_client(context)"},{"line_number":1088,"context_line":"        fip \u003d self._get_floating_ip_by_address(client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_2236f203","line":1085,"in_reply_to":"7ac7a964_55791f2e","updated":"2014-08-15 21:08:36.000000000","message":"Done","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17c960e39ff93cc77680c4896ca385673d6e46b1","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"            raise exception.FloatingIpAssociated(address\u003daddress)"},{"line_number":1083,"context_line":"        client.delete_floatingip(fip[\u0027id\u0027])"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":1086,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":1087,"context_line":"        client \u003d neutronv2.get_client(context)"},{"line_number":1088,"context_line":"        fip \u003d self._get_floating_ip_by_address(client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_55791f2e","line":1085,"in_reply_to":"7ac7a964_d9e67744","updated":"2014-08-14 17:50:38.000000000","message":"I was thinking more along with the get_client and _get_floating_ip_by_address calls.\n\nLike have a private _release_floating_ip method which takes a boolean to check fip[\u0027port_id\u0027] or not (in this case we don\u0027t care, we just delete.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b1e39fbe5c8e2eb2a0b3ee35f1e1ba3ec54df499","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"            raise exception.FloatingIpAssociated(address\u003daddress)"},{"line_number":1083,"context_line":"        client.delete_floatingip(fip[\u0027id\u0027])"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def disassocate_and_delete(self, context, instance, floating_ip):"},{"line_number":1086,"context_line":"        \"\"\"Removes (deallocates) and deletes the floating ip.\"\"\""},{"line_number":1087,"context_line":"        client \u003d neutronv2.get_client(context)"},{"line_number":1088,"context_line":"        fip \u003d self._get_floating_ip_by_address(client,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_d9e67744","line":1085,"in_reply_to":"7ac7a964_f68fc0ca","updated":"2014-08-13 21:45:04.000000000","message":"I could add a helper method that does:\n\ndef _delete_floating_ip(self, client, fip_id):\n     client.delete_floatingip(fip[\u0027id\u0027])\n\nbut that only saves us one line so i don\u0027t thinks its worth it personally.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5f00e8039b0e0e8d68035c008dbc87adbdcdf45c","unresolved":false,"context_lines":[{"line_number":1090,"context_line":"        This api call was added to allow this to be done in one operation"},{"line_number":1091,"context_line":"        if using neutron."},{"line_number":1092,"context_line":"        \"\"\""},{"line_number":1093,"context_line":"        self._release_floating_ip(context, floating_ip[\u0027address\u0027], False)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    def _release_floating_ip(self, context, address,"},{"line_number":1096,"context_line":"                             raise_if_associated\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_44912199","line":1093,"updated":"2014-08-27 16:08:08.000000000","message":"nit: I\u0027d prefer that we call _release_floating_ip with raise_if_associated\u003dFalse for clarity.","commit_id":"8167c48799a4750cb743d1e25ee052031ccbe2d9"}],"nova/tests/api/openstack/compute/contrib/test_floating_ips.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd97cb56fe95d7abcf9a708d66e9354bc741d028","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self.controller.delete(req, 1)"},{"line_number":132,"context_line":"            self.assertFalse(disoc_fip.called)"},{"line_number":133,"context_line":"            self.assertFalse(rel_fip.called)"},{"line_number":134,"context_line":"            # Only disassocate_and_delete is called if using neutron"},{"line_number":135,"context_line":"            self.assertTrue(dis_and_del.called)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_768810e8","line":134,"updated":"2014-08-13 21:37:25.000000000","message":"Is this true?","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"66d301e5f4b758d37d55f82701db2884ffae7dd8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self.controller.delete(req, 1)"},{"line_number":132,"context_line":"            self.assertFalse(disoc_fip.called)"},{"line_number":133,"context_line":"            self.assertFalse(rel_fip.called)"},{"line_number":134,"context_line":"            # Only disassocate_and_delete is called if using neutron"},{"line_number":135,"context_line":"            self.assertTrue(dis_and_del.called)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_42b771d8","line":134,"in_reply_to":"7ac7a964_35a3c39f","updated":"2014-08-15 19:29:28.000000000","message":"Yeah, this looks like maybe leftover from the previous way of doing this.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f05d6fb5b267c8bcf07304fa9f549404936861d3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self.controller.delete(req, 1)"},{"line_number":132,"context_line":"            self.assertFalse(disoc_fip.called)"},{"line_number":133,"context_line":"            self.assertFalse(rel_fip.called)"},{"line_number":134,"context_line":"            # Only disassocate_and_delete is called if using neutron"},{"line_number":135,"context_line":"            self.assertTrue(dis_and_del.called)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_e22b1a92","line":134,"in_reply_to":"7ac7a964_42b771d8","updated":"2014-08-15 21:08:36.000000000","message":"@Matt - Right that\u0027s why this class is just testing neutron and is called FloatingIpTestNeutron see nova test below.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b1e39fbe5c8e2eb2a0b3ee35f1e1ba3ec54df499","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self.controller.delete(req, 1)"},{"line_number":132,"context_line":"            self.assertFalse(disoc_fip.called)"},{"line_number":133,"context_line":"            self.assertFalse(rel_fip.called)"},{"line_number":134,"context_line":"            # Only disassocate_and_delete is called if using neutron"},{"line_number":135,"context_line":"            self.assertTrue(dis_and_del.called)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_f95173d9","line":134,"in_reply_to":"7ac7a964_768810e8","updated":"2014-08-13 21:45:04.000000000","message":"We\u0027ll see if the test passes :) \n\nYup, it\u0027s true. If using neutron we only call: disassocate_and_delete() the other api calls are not called if using neutron. I figured keeping these asserts in here just to make sure we don\u0027t call those in the future by mistake.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17c960e39ff93cc77680c4896ca385673d6e46b1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self.controller.delete(req, 1)"},{"line_number":132,"context_line":"            self.assertFalse(disoc_fip.called)"},{"line_number":133,"context_line":"            self.assertFalse(rel_fip.called)"},{"line_number":134,"context_line":"            # Only disassocate_and_delete is called if using neutron"},{"line_number":135,"context_line":"            self.assertTrue(dis_and_del.called)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_35a3c39f","line":134,"in_reply_to":"7ac7a964_f95173d9","updated":"2014-08-14 17:50:38.000000000","message":"What I meant was the comment is misleading since we also call disassociate_and_delete in the nova-network case.","commit_id":"ab64a9213ab377776d0a4ca615ab4ada7935bc68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f6035ae481f47cef2836318bba63c2ff2c55e3f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    return None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class FloatingIpTestNeutron(test.TestCase):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def setUp(self):"},{"line_number":110,"context_line":"        super(FloatingIpTestNeutron, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_fc02dd09","line":107,"updated":"2014-08-16 01:19:52.000000000","message":"nit: couldn\u0027t this be a NoDbTestCase?","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0defdf9c8a168ae725e3747e7c0c382633b5903","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    return None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class FloatingIpTestNeutron(test.TestCase):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def setUp(self):"},{"line_number":110,"context_line":"        super(FloatingIpTestNeutron, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_e4094d2d","line":107,"in_reply_to":"1abeadc6_8b5b8a53","updated":"2014-08-27 16:05:44.000000000","message":"Maybe they don\u0027t need to be either and no one has cleaned it up, it\u0027s not a reason to leave this as able to access the database if it doesn\u0027t need to since we want new unit tests to not touch the DB if possible (which I think is the case here).","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"826e993342f5584116643341620b35f64be46172","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    return None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class FloatingIpTestNeutron(test.TestCase):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def setUp(self):"},{"line_number":110,"context_line":"        super(FloatingIpTestNeutron, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_8b5b8a53","line":107,"in_reply_to":"7ac7a964_fc02dd09","updated":"2014-08-21 21:45:14.000000000","message":"the tests below aren\u0027t.","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5f00e8039b0e0e8d68035c008dbc87adbdcdf45c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    return None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class FloatingIpTestNeutron(test.TestCase):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def setUp(self):"},{"line_number":110,"context_line":"        super(FloatingIpTestNeutron, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_04f729f6","line":107,"updated":"2014-08-27 16:08:08.000000000","message":"Still think this should be NoDbTestCase, but will pull it down to verify if that works.","commit_id":"8167c48799a4750cb743d1e25ee052031ccbe2d9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"10177385f35770d24e8d06656c5f5875db70a467","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    return None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class FloatingIpTestNeutron(test.TestCase):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def setUp(self):"},{"line_number":110,"context_line":"        super(FloatingIpTestNeutron, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_7f714443","line":107,"in_reply_to":"1abeadc6_04f729f6","updated":"2014-08-27 16:39:26.000000000","message":"Verified that this works as a no-db test case, so we should do it that way.  I can push the trivial update myself.","commit_id":"8167c48799a4750cb743d1e25ee052031ccbe2d9"}],"nova/tests/network/test_neutronv2.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f6035ae481f47cef2836318bba63c2ff2c55e3f","unresolved":false,"context_lines":[{"line_number":1967,"context_line":""},{"line_number":1968,"context_line":"    def test_disassocate_and_delete_floating_ip(self):"},{"line_number":1969,"context_line":"        api \u003d neutronapi.API()"},{"line_number":1970,"context_line":"        address \u003d self.fip_unassociated[\u0027floating_ip_address\u0027]"},{"line_number":1971,"context_line":"        fip_id \u003d self.fip_unassociated[\u0027id\u0027]"},{"line_number":1972,"context_line":"        floating_ip \u003d {\u0027address\u0027: address}"},{"line_number":1973,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_372b8e83","line":1970,"updated":"2014-08-16 01:19:52.000000000","message":"This would probably be a more robust test if it were modeled after test_release_floating_ip_associated where the floating IP is associated with a port, but we wouldn\u0027t raise an exception in that case.","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"826e993342f5584116643341620b35f64be46172","unresolved":false,"context_lines":[{"line_number":1967,"context_line":""},{"line_number":1968,"context_line":"    def test_disassocate_and_delete_floating_ip(self):"},{"line_number":1969,"context_line":"        api \u003d neutronapi.API()"},{"line_number":1970,"context_line":"        address \u003d self.fip_unassociated[\u0027floating_ip_address\u0027]"},{"line_number":1971,"context_line":"        fip_id \u003d self.fip_unassociated[\u0027id\u0027]"},{"line_number":1972,"context_line":"        floating_ip \u003d {\u0027address\u0027: address}"},{"line_number":1973,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_c76ed32e","line":1970,"in_reply_to":"7ac7a964_372b8e83","updated":"2014-08-21 21:45:14.000000000","message":"I think we still have the same amount of code coverage either way.","commit_id":"de78de8659b53461b2bb07dba57244eec58353a2"}]}
