)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"6124a1ab87290ae5e3da4c82b489e5647b743ac7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ourselves to the vSphere behaviour. We can\u0027t guarantee that this is"},{"line_number":19,"context_line":"the reason the RPC call failed, or that it is the only reason the RPC"},{"line_number":20,"context_line":"call failed."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1357263"},{"line_number":23,"context_line":"Change-Id: I10e0982c6c450facdeea41c7f1d266e20a924d08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa98f980_1c7d086f","line":21,"updated":"2014-09-01 19:00:11.000000000","message":"I would like to see a DocImpact tag in this commit message:\n\nhttps://wiki.openstack.org/wiki/Documentation/DocImpact\n\nWe need to make this list visible from the relevant section of the configuration reference guide.","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"c1dd5ca44c7f3db6335698c301386689bee05003","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ourselves to the vSphere behaviour. We can\u0027t guarantee that this is"},{"line_number":19,"context_line":"the reason the RPC call failed, or that it is the only reason the RPC"},{"line_number":20,"context_line":"call failed."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1357263"},{"line_number":23,"context_line":"Change-Id: I10e0982c6c450facdeea41c7f1d266e20a924d08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa98f980_696f10c6","line":21,"in_reply_to":"fa98f980_1c7d086f","updated":"2014-09-02 08:35:43.000000000","message":"Are you sure we want to document this? IMHO, the documentation should say that vmware_ostype must be a valid vSphere guestId, or guest creation will fail. Putting the actual list in the docs seems like compounding the layering violation: we would have an unconventionally compiled list which we\u0027d have to maintain in 2 locations rather than 1.\n\nAlso, the list is heuristic. I extracted it from vSphere 5.5, but if somebody is running against vSphere 5.1 there will be \u0027known good\u0027 values in this list which would result in an error. On the release of vSphere 6, there will be good values which aren\u0027t in the list.\n\nProviding this list is really VMware\u0027s responsibility, to be updated with each vSphere release. Their docs are normally pretty good, so I was disappointed to find that they haven\u0027t documented it. However, I think we should pause before deciding to maintain it ourselves.\n\nPerhaps a wiki page somewhere with a warning that this is only a best effort, and we could link to the wiki from the configuration reference guide.","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"},{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"23f552649faa987294ff05b0031c6abb37f09425","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ourselves to the vSphere behaviour. We can\u0027t guarantee that this is"},{"line_number":19,"context_line":"the reason the RPC call failed, or that it is the only reason the RPC"},{"line_number":20,"context_line":"call failed."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1357263"},{"line_number":23,"context_line":"Change-Id: I10e0982c6c450facdeea41c7f1d266e20a924d08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa98f980_473910a3","line":21,"in_reply_to":"fa98f980_696f10c6","updated":"2014-09-03 17:25:04.000000000","message":"I still think we need a DocImpact bug to track this rather than just forget it about it again, this is not very discoverable.","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"}],"nova/tests/virt/vmwareapi/fake.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"3906e5ab230a37f0889f42df58d57fd4f5fbb28b","unresolved":false,"context_lines":[{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1178,"context_line":"            ex \u003d vexc.VMwareDriverException(\u0027A specified parameter was \u0027"},{"line_number":1179,"context_line":"                                                  \u0027not correct.\u0027)"},{"line_number":1180,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        pool \u003d kwargs.get(\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_a3321bf0","line":1179,"updated":"2014-09-18 00:44:07.000000000","message":"The indenting is off, \u0027not\u0027 should line up under \u0027A\u0027.","commit_id":"c3c0e4b1468ea8b2835439ccce8f0936eda52abc"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"46c6f4483dce628ec91dcc630ee9617dcc6fc06b","unresolved":false,"context_lines":[{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1178,"context_line":"            ex \u003d vexc.VMwareDriverException(\u0027A specified parameter was \u0027"},{"line_number":1179,"context_line":"                                                  \u0027not correct.\u0027)"},{"line_number":1180,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        pool \u003d kwargs.get(\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_cf00c4ad","line":1179,"in_reply_to":"fa98f980_a3321bf0","updated":"2014-10-15 14:52:14.000000000","message":"Done","commit_id":"c3c0e4b1468ea8b2835439ccce8f0936eda52abc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bed7f04486b8d213c199dd141a52fdf7b4fc6fd8","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1179,"context_line":"            ex \u003d vexc.VMwareDriverException(\u0027A specified parameter was \u0027"},{"line_number":1180,"context_line":"                                            \u0027not correct.\u0027)"},{"line_number":1181,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        pool \u003d kwargs.get(\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_f966b0ed","line":1180,"updated":"2014-10-29 19:37:37.000000000","message":"umm... shouldn\u0027t there be actually a message saying that the guest id isn\u0027t valid?","commit_id":"a98dcc636104283d3089f02e5b0fc2b045046ce7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a62e721ebe87f072154e157a7d3e13f3fbddd770","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1179,"context_line":"            ex \u003d vexc.VMwareDriverException(\u0027A specified parameter was \u0027"},{"line_number":1180,"context_line":"                                            \u0027not correct.\u0027)"},{"line_number":1181,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        pool \u003d kwargs.get(\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_900f46e1","line":1180,"in_reply_to":"7a8c0949_2eb63cdd","updated":"2014-10-30 14:52:48.000000000","message":"At some point I thought the pyvmomi or oslo.vmware stuff at some point would have error codes associated with errors so we could key off that instead?","commit_id":"a98dcc636104283d3089f02e5b0fc2b045046ce7"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"6701f314556ff600f53e3d4d8d4dd453d2385294","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1179,"context_line":"            ex \u003d vexc.VMwareDriverException(\u0027A specified parameter was \u0027"},{"line_number":1180,"context_line":"                                            \u0027not correct.\u0027)"},{"line_number":1181,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        pool \u003d kwargs.get(\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_0b9fa760","line":1180,"in_reply_to":"7a8c0949_900f46e1","updated":"2014-10-30 15:28:16.000000000","message":"Yeah, we\u0027ve had that for a while now: the errors we return are typed according to the error metadata returned by vSphere. Unfortunately this one is really bad. The information here is literally everything we get back. I even dumped the contents of the SOAP body to check :/","commit_id":"a98dcc636104283d3089f02e5b0fc2b045046ce7"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"fbdc25bbd8cf4a5b9116a66110585152cc71830c","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"        if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1179,"context_line":"            ex \u003d vexc.VMwareDriverException(\u0027A specified parameter was \u0027"},{"line_number":1180,"context_line":"                                            \u0027not correct.\u0027)"},{"line_number":1181,"context_line":"            return create_task(method, \"error\", error_fault\u003dex).obj"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        pool \u003d kwargs.get(\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_2eb63cdd","line":1180,"in_reply_to":"9aa7fdbe_f966b0ed","updated":"2014-10-30 09:45:23.000000000","message":"Well I obviously think so :) However, what vSphere actually emits is \u0027A specified parameter was not correct\u0027. This isn\u0027t a terribly useful error message, hence this patch.\n\nIt\u0027s the job of fake to copy vSphere, warts and all, so improving the error message here wouldn\u0027t be appropriate.","commit_id":"a98dcc636104283d3089f02e5b0fc2b045046ce7"}],"nova/tests/virt/vmwareapi/test_vm_util.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"171a8be8e4300707290fb745ccb073abed9c4612","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        unrecognised guestId"},{"line_number":612,"context_line":"        \"\"\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        found \u003d [False]"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        def fake_log_warn(msg, values):"},{"line_number":617,"context_line":"            if not isinstance(values, dict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_37683eba","line":614,"updated":"2014-09-01 11:40:29.000000000","message":"No need to define a list ... found can be a boolean","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"5302602d079f60c60dd5ef5030fd121274f7e2f5","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        unrecognised guestId"},{"line_number":612,"context_line":"        \"\"\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        found \u003d [False]"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        def fake_log_warn(msg, values):"},{"line_number":617,"context_line":"            if not isinstance(values, dict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_d3218dfd","line":614,"in_reply_to":"fa98f980_37683eba","updated":"2014-09-02 08:06:11.000000000","message":"Unfortunately not, because we modify it in fake_log_warn() below. Enclosed variables are immutable in python, so \u0027found \u003d True\u0027 below would be an error. However, the object pointed to by an immutable variable is not immutable, so we can modify the contents of an array.\n\nThis is a common workaround for a bug in python.","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"}],"nova/virt/vmwareapi/constants.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8939f9d890194a27ccc107e67cfa9b9041df4f8d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# searching for the string \u0027otherGuest\u0027 in the uncompressed contents of that"},{"line_number":31,"context_line":"# file, copying out the full list less the \u0027family\u0027 ids at the end, and sorting"},{"line_number":32,"context_line":"# it. The contents of this list should be updated whenever there is a new"},{"line_number":33,"context_line":"# release of ESX."},{"line_number":34,"context_line":"VALID_GUESTIDS \u003d set(["},{"line_number":35,"context_line":"    \u0027asianux3_64Guest\u0027,"},{"line_number":36,"context_line":"    \u0027asianux3Guest\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_aac02ce1","line":33,"updated":"2014-08-15 13:51:11.000000000","message":"i think that this may be problematic - i think that when we move to pyvmomi that this data will be embedded. it is worth checking with the guys who are more familiar with it.","commit_id":"428141da4a71dde260c9696381e562d4a7f25dff"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"cacf4239c5a8cf86b0354500b4906c72440569c4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# searching for the string \u0027otherGuest\u0027 in the uncompressed contents of that"},{"line_number":31,"context_line":"# file, copying out the full list less the \u0027family\u0027 ids at the end, and sorting"},{"line_number":32,"context_line":"# it. The contents of this list should be updated whenever there is a new"},{"line_number":33,"context_line":"# release of ESX."},{"line_number":34,"context_line":"VALID_GUESTIDS \u003d set(["},{"line_number":35,"context_line":"    \u0027asianux3_64Guest\u0027,"},{"line_number":36,"context_line":"    \u0027asianux3Guest\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_6cde3141","line":33,"in_reply_to":"7ac7a964_aac02ce1","updated":"2014-08-15 14:18:40.000000000","message":"I don\u0027t think that\u0027s problematic. This information is in pyvmomi, but lots of things will have to change when me make that move. Removing this list will be trivial. Until then it\u0027s useful.","commit_id":"428141da4a71dde260c9696381e562d4a7f25dff"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8939f9d890194a27ccc107e67cfa9b9041df4f8d","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1252,"context_line":"    try:"},{"line_number":1253,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1254,"context_line":"    except error_util.VMwareDriverException:"},{"line_number":1255,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1256,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."},{"line_number":1257,"context_line":"        # As guestId is user-editable, we try to help the user out with some"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_2a697c25","line":1254,"updated":"2014-08-15 13:51:11.000000000","message":"Can you please use with excutils.save_and_reraise_exception():","commit_id":"428141da4a71dde260c9696381e562d4a7f25dff"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"cacf4239c5a8cf86b0354500b4906c72440569c4","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"        config\u003dconfig_spec, pool\u003dres_pool_ref)"},{"line_number":1252,"context_line":"    try:"},{"line_number":1253,"context_line":"        task_info \u003d session._wait_for_task(vm_create_task)"},{"line_number":1254,"context_line":"    except error_util.VMwareDriverException:"},{"line_number":1255,"context_line":"        # An invalid guestId will result in an error with no specific fault"},{"line_number":1256,"context_line":"        # type and the generic error \u0027A specified parameter was not correct\u0027."},{"line_number":1257,"context_line":"        # As guestId is user-editable, we try to help the user out with some"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_6c9ab164","line":1254,"in_reply_to":"7ac7a964_2a697c25","updated":"2014-08-15 14:18:40.000000000","message":"Done","commit_id":"428141da4a71dde260c9696381e562d4a7f25dff"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8939f9d890194a27ccc107e67cfa9b9041df4f8d","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"        # We don\u0027t check this in advance or do anything more than warn because"},{"line_number":1261,"context_line":"        # we can\u0027t guarantee that our list of known-good guestIds is complete."},{"line_number":1262,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1263,"context_line":"        if config_spec.guestId not in constants.VALID_GUESTIDS:"},{"line_number":1264,"context_line":"            LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1265,"context_line":"                         \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type will cause \u0027"},{"line_number":1266,"context_line":"                         \u0027instance creation to fail\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_6aee14b6","line":1263,"updated":"2014-08-15 13:51:11.000000000","message":"this could lead to a false positive if some other error occurs, but it may be useful in helping an admin debug.\nonly concern is that the list may change from one version to another.\nmaybe you can just mention that the user should check the value (but that may be half baked)","commit_id":"428141da4a71dde260c9696381e562d4a7f25dff"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"cacf4239c5a8cf86b0354500b4906c72440569c4","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"        # We don\u0027t check this in advance or do anything more than warn because"},{"line_number":1261,"context_line":"        # we can\u0027t guarantee that our list of known-good guestIds is complete."},{"line_number":1262,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1263,"context_line":"        if config_spec.guestId not in constants.VALID_GUESTIDS:"},{"line_number":1264,"context_line":"            LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1265,"context_line":"                         \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type will cause \u0027"},{"line_number":1266,"context_line":"                         \u0027instance creation to fail\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_8caf0d94","line":1263,"in_reply_to":"7ac7a964_6aee14b6","updated":"2014-08-15 14:18:40.000000000","message":"I\u0027ll make the vagueness of this warning a bit more explicit :)","commit_id":"428141da4a71dde260c9696381e562d4a7f25dff"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"255cd1b65dc784ca53da316adbf025e6a1e9647a","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1267,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1268,"context_line":"                             \u0027cause of this instance creation failure\u0027),"},{"line_number":1269,"context_line":"                         {\u0027ostype\u0027: config_spec.guestId})"},{"line_number":1270,"context_line":"    LOG.debug(\"Created VM on the ESX host\", instance\u003dinstance)"},{"line_number":1271,"context_line":"    return task_info.result"},{"line_number":1272,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_8f9e2db7","line":1269,"updated":"2014-08-26 13:30:26.000000000","message":"Maybe it is worth considering validating the ostype after:\n        image_info \u003d vmware_images.VMwareImage.from_image(instance.image_ref,\n                                                          image_meta)\n\nAnd then doing a LOG warning.\nBut that may be an overkill. We certainly do not want to prevent the creation of a VM with a valid type that is currently not listed in the contants","commit_id":"af0ceb8457f85f9a7f1fa35a10b96ff20b6b86fb"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"6acff3759f14fcacbdcfb318d6faba1fa4104fdd","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1267,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1268,"context_line":"                             \u0027cause of this instance creation failure\u0027),"},{"line_number":1269,"context_line":"                         {\u0027ostype\u0027: config_spec.guestId})"},{"line_number":1270,"context_line":"    LOG.debug(\"Created VM on the ESX host\", instance\u003dinstance)"},{"line_number":1271,"context_line":"    return task_info.result"},{"line_number":1272,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_6621cafb","line":1269,"in_reply_to":"1abeadc6_8f9e2db7","updated":"2014-08-27 13:52:02.000000000","message":"Yeah, I considered that. The advantage of doing it here is that you only get a warning if it actually failed. i.e. If your unrecognised os type works fine it won\u0027t bother telling you about it, which seemed preferrable to me.","commit_id":"af0ceb8457f85f9a7f1fa35a10b96ff20b6b86fb"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"5a02834e4152561425f57154ba21783cbb0bbdd0","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"        # we can\u0027t guarantee that our list of known-good guestIds is complete."},{"line_number":1264,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1265,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1266,"context_line":"            if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1267,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1268,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1269,"context_line":"                             \u0027cause of this instance creation failure\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_ebb96aea","line":1266,"updated":"2014-09-01 14:13:14.000000000","message":"How about not repeating the \"Guest\" in the constants and doing:\n\n    if not config_spec.guestid.endswith(\"Guest\") or config_spec.guestid[:-5] not in constants.VALID_OS_TYPES:","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"8f58abaee9a66a9a37d29a2804bf00d59c06138f","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"        # we can\u0027t guarantee that our list of known-good guestIds is complete."},{"line_number":1264,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1265,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1266,"context_line":"            if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1267,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1268,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1269,"context_line":"                             \u0027cause of this instance creation failure\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_3319f988","line":1266,"in_reply_to":"fa98f980_ebb96aea","updated":"2014-09-02 08:13:55.000000000","message":"I prefer the full list, tbh. It\u0027s not as if I typed them in by hand, so if I made this change I\u0027d have an additional processing step to do. Also, I don\u0027t have to worry about them breaking the naming convention.","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b8c8a855af55a524b0c9904b080864d8b6f7a2e0","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1265,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1266,"context_line":"            if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1267,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1268,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1269,"context_line":"                             \u0027cause of this instance creation failure\u0027),"},{"line_number":1270,"context_line":"                         {\u0027ostype\u0027: config_spec.guestId})"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_14967f4c","line":1267,"updated":"2014-09-02 20:30:57.000000000","message":"Total NIT, but brings up a good question.  Is the translation key (the English string) supposed to be in US English or UK English or doesn\u0027t matter?","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"258adb50bf6790179ea2c40e2d2a402c08d36851","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1265,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1266,"context_line":"            if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1267,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1268,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1269,"context_line":"                             \u0027cause of this instance creation failure\u0027),"},{"line_number":1270,"context_line":"                         {\u0027ostype\u0027: config_spec.guestId})"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_654ecc39","line":1267,"in_reply_to":"fa98f980_14967f4c","updated":"2014-09-15 14:24:35.000000000","message":"I don\u0027t know but if there is an edict I\u0027d (regretfully ;)) expect it to be US English. I had to read this several times to get what you were aiming at, but I\u0027m guessing you\u0027d have a z (pronounced zed) in \u0027recognised\u0027 on the other side of the pond?\n\nIn the absence of a firm edict I\u0027m going to leave this alone because I will make these \u0027mistakes\u0027 all the time! Also, I\u0027d die a little inside every time I had to intentionally misspell something ;) However, I\u0027ll suck it up if we have a documented policy.\n\nNow, if you don\u0027t mind I\u0027ll be off to seethe about cultural imperialism or some such. I\u0027d start an independence movement, but you beat us to it :P","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"2297144a4c211f1f56cee88f0c72509fb6cb3a63","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1265,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1266,"context_line":"            if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1267,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1268,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1269,"context_line":"                             \u0027cause of this instance creation failure\u0027),"},{"line_number":1270,"context_line":"                         {\u0027ostype\u0027: config_spec.guestId})"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_d3c65448","line":1267,"in_reply_to":"fa98f980_654ecc39","updated":"2014-09-15 23:34:46.000000000","message":":) yep, recognised -\u003e recognized.  I wouldn\u0027t care for general comments and such, but for messages that get translated, should be consistent.  But that\u0027s a wider issue than this patch.  But I got a nice laugh reading your response, :)","commit_id":"af1623cd3254f997cf147013d5068dd5fe210c15"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"0250be306f0a51d9f3e3cc648d6dba9ad5750311","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1277,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1278,"context_line":"            if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1279,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1280,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1281,"context_line":"                             \u0027cause of this instance creation failure\u0027),"},{"line_number":1282,"context_line":"                         {\u0027ostype\u0027: config_spec.guestId})"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_33e152d1","line":1279,"range":{"start_line":1279,"start_character":20,"end_line":1279,"end_character":24},"updated":"2014-10-09 11:32:51.000000000","message":"Please use here `LOG.warning`","commit_id":"c3c0e4b1468ea8b2835439ccce8f0936eda52abc"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"46c6f4483dce628ec91dcc630ee9617dcc6fc06b","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"        # Consequently, a value which we don\u0027t recognise may in fact be valid."},{"line_number":1277,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1278,"context_line":"            if config_spec.guestId not in constants.VALID_OS_TYPES:"},{"line_number":1279,"context_line":"                LOG.warn(_LW(\u0027vmware_ostype from image is not recognised: \u0027"},{"line_number":1280,"context_line":"                             \u0027\\\u0027%(ostype)s\\\u0027. An invalid os type may be one \u0027"},{"line_number":1281,"context_line":"                             \u0027cause of this instance creation failure\u0027),"},{"line_number":1282,"context_line":"                         {\u0027ostype\u0027: config_spec.guestId})"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_92a41fa7","line":1279,"in_reply_to":"baa201ad_33e152d1","updated":"2014-10-15 14:52:14.000000000","message":"Done","commit_id":"c3c0e4b1468ea8b2835439ccce8f0936eda52abc"}]}