)]}'
{"id":"openstack%2Fnova~11517","triplet_id":"openstack%2Fnova~master~I613926e4288442e79df50ea5f5bd8f9eafdfe7e7","project":"openstack/nova","branch":"master","topic":"bug/1035426","hashtags":[],"change_id":"I613926e4288442e79df50ea5f5bd8f9eafdfe7e7","subject":"Makes sure tests don\u0027t leave lockfiles around","status":"MERGED","created":"2012-08-16 23:54:18.000000000","updated":"2012-08-17 18:24:22.000000000","submitted":"2012-08-17 18:24:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a963212ae4b6799beb940def30f41f7130776641","_number":11517,"virtual_id_number":11517,"owner":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":1,"date":"2012-08-17 17:52:14.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2012-08-17 18:24:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":2,"date":"2012-08-17 17:50:17.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":2,"date":"2012-08-17 17:37:42.000000000","_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2012-08-17 18:04:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":1,"date":"2012-08-17 17:50:17.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2012-08-17 17:37:42.000000000","_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2012-08-17 18:04:44.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-08-17 17:37:42.000000000","updated_by":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"reviewer":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"state":"REVIEWER"},{"updated":"2012-08-17 17:50:17.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2012-08-17 17:52:14.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-08-17 18:04:44.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-08-17 18:24:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d57cedad3ce927f330176dede3ffd36c74d72a68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 00:25:14.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- https://jenkins.openstack.org/job/gate-nova-merge/7302/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-docs/3109/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-pep8/8421/consoleFull : FAILURE\n- https://jenkins.openstack.org/job/gate-nova-python26/4576/consoleFull : FAILURE\n- https://jenkins.openstack.org/job/gate-nova-python27/4631/consoleFull : FAILURE\n- https://jenkins.openstack.org/job/gate-tempest-devstack-vm/8256/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"f91c138192159412c5fd07e122c2097fb599a67f","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-08-17 01:09:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"125c338c76c2ff0513e47a7e553177573d0f4884","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 01:41:10.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed\n\n- https://jenkins.openstack.org/job/gate-nova-merge/7306/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-docs/3113/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-pep8/8425/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python26/4580/consoleFull : FAILURE\n- https://jenkins.openstack.org/job/gate-nova-python27/4635/consoleFull : FAILURE\n- https://jenkins.openstack.org/job/gate-tempest-devstack-vm/8266/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"2ec434db8172ab02adf92ec637d77bb2276dd727","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-08-17 15:08:56.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"3d8ae81f3897a98480d820fc8a741d317c1ed68b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-08-17 15:12:35.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nAssuming the tests stop timing out, this looks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"7bdd22fe99c1250096a2266f57677659e3a0a32e","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-08-17 15:39:52.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nIt looks like we could just stub this out completely.  This patch turns the locking into a no-op, but it at least still allows this code to run for coverage purposes.\n\nThe only potential problem with this would be if we were running tests in parallel and needed these locks to prevent breakage, but we can revisit this if that becomes an issue.","accounts_in_message":[],"_revision_number":2},{"id":"b724122645d981be0be334eb77534cbc3ef0a9cd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 15:40:00.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"11a48b39dbd279a8abcbbb3c299139c0080924d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 15:44:08.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed\n\n- https://jenkins.openstack.org/job/gate-nova-merge/7342/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-docs/3149/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-pep8/8461/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python26/4616/consoleFull : FAILURE\n- https://jenkins.openstack.org/job/gate-nova-python27/4671/consoleFull : FAILURE\n- https://jenkins.openstack.org/job/gate-tempest-devstack-vm/8327/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"6a7ca98e81df406145af25543afc66a2d7616275","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-08-17 15:52:34.000000000","message":"Patch Set 2:\n\nLooks like both unit test gates hung at the same spot, but I can\u0027t reproduce locally.  I\u0027ll kick it to see if it happens again ...","accounts_in_message":[],"_revision_number":2},{"id":"0cb6980adc44d56cb57fb6aaf4f4e32be94c5079","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-08-17 15:52:51.000000000","message":"Patch Set 2:\n\nreverify","accounts_in_message":[],"_revision_number":2},{"id":"08a40ce7ee210f7339cd2f647bca18f0cd23b843","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-08-17 16:18:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8ef7a8ca83e75baffc7e67db5570761a611276a8","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-08-17 16:25:23.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"151159afe5fede5cf2d57824980a24e77c1029c4","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-08-17 16:34:00.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nWould like to see this pass on jenkins before hitting approve again :)\n\nOn IRC, sounds like we may not have gotten to the root cause of the earlier failure since it has been difficult to reproduce consistently.","accounts_in_message":[],"_revision_number":3},{"id":"ffd941ab3cd8afe03b0c9d7ba6662ad1e2472c7b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 16:36:56.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-nova-merge/7358/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-docs/3165/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-pep8/8477/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python26/4632/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python27/4687/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-tempest-devstack-vm/8354/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"93f31aae292417d579b167a1ec0e658be305a8a9","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-08-17 16:52:22.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/30308\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/30306\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/30307\n","accounts_in_message":[],"_revision_number":3},{"id":"16a57e90dfde1016da762c1890d748dc1db7498f","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-08-17 17:24:51.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"b2ef55e6c7787451d0b0d12ece63e3a65f9f6450","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-08-17 17:26:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"2462b76d6e13847edbc3b8847c0641bc63695e9b","author":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"date":"2012-08-17 17:37:42.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"aa368f3ec505cbd885ad273529f407f6bd393e8d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 17:43:16.000000000","message":"Patch Set 4: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-nova-merge/7363/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-docs/3170/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-pep8/8482/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python26/4637/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python27/4692/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-tempest-devstack-vm/8361/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"fe97c285cdcc0ee48ddf1cc11365b426bd9b79bf","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-08-17 17:50:17.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\nIt looks like Jenkins and Smokestack and both happy with the unit tests now.  Perhaps the test_misc tests didn\u0027t fail cleanly earlier and hosed things up.  We\u0027ll just have to watch for hangs on other tests in the near future to see if this comes back after this goes in.","accounts_in_message":[],"_revision_number":4},{"id":"deffedc6fea0bf6314343ed8730b80d2ef95184a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 17:50:19.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"590e70a46489c13909de394d89fb8328e116c50b","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-08-17 17:52:14.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/30317\n\tLibvirt (Fedora 17) Running: http://smokestack.openstack.org/?go\u003d/jobs/30315\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/30316\n","accounts_in_message":[],"_revision_number":4},{"id":"3721ce1a5a9618ac40066ffdea835735bb9ecc09","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 18:03:34.000000000","message":"Patch Set 4: Fails\n\nBuild failed\n\n- https://jenkins.openstack.org/job/gate-nova-merge/7365/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-docs/3172/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-pep8/8484/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python26/4639/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python27/4694/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-tempest-devstack-vm/8365/consoleFull : FAILURE\n","accounts_in_message":[],"_revision_number":4},{"id":"54cb9ef3848b7fd8fa5cf24534edb518a1d9f348","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-08-17 18:04:44.000000000","message":"Patch Set 4:\n\nreverify","accounts_in_message":[],"_revision_number":4},{"id":"387c6afc2a2a4e32795db7edefd9c64d4c144425","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 18:04:45.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"11af6aaf05c05f24faa1c05c0eaa25a439dd132f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-08-17 18:05:12.000000000","message":"Patch Set 4:\n\n(definitely some kind of transient issue on the devstack gate)","accounts_in_message":[],"_revision_number":4},{"id":"283608e38504f1e2346c6ca0ebe9d1ddb7d96905","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 18:24:21.000000000","message":"Patch Set 4: Verified\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-nova-merge/7368/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-docs/3175/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-pep8/8487/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python26/4642/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-nova-python27/4697/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-tempest-devstack-vm/8368/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"f41204090e464f0c1c479b30eb2e96e3921a3eff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-17 18:24:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"10e25db4befe1173af516a053ac01f0f7b6dac56","revisions":{"61fb97791379f1517128d8eedeaba4b1dbb7d364":{"kind":"REWORK","_number":1,"created":"2012-08-16 23:54:18.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/17/11517/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/17/11517/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/17/11517/1"}}},"commit":{"parents":[{"commit":"9b531087710241bee2cfc9e3862fb5dbe650beeb","subject":"Sync changes from openstack common","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b531087710241bee2cfc9e3862fb5dbe650beeb"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-08-16 23:51:04.000000000","tz":-420},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-08-16 23:51:04.000000000","tz":-420},"subject":"Makes sure tests don\u0027t leave lockfiles around","message":"Makes sure tests don\u0027t leave lockfiles around\n\nOur new lockfile code works fine if the locks already exist, but\nit is annoying to pollute the source tree with lockfiles in the\ntests.\n\nThis modifies the lockfile code slightly to use a tempdir if\nlock_path is none. Note that a tempdir will not work in production\nbut it is fine for testing. We set the lock_path to None in the\ntesting flags.\n\nAlso removes the explicit cleanup in run_tests.sh. The new solution\nworks with tox and will work even if we add new locks.\n\nFixes bug 1035426\n\nChange-Id: I613926e4288442e79df50ea5f5bd8f9eafdfe7e7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/61fb97791379f1517128d8eedeaba4b1dbb7d364"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/61fb97791379f1517128d8eedeaba4b1dbb7d364"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9b531087710241bee2cfc9e3862fb5dbe650beeb","is_merged_in_target_branch":false,"change_id":"Ica7a2e51ea38f37b315be2ff382d4a615dd67207","change_number":11515,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"c2282a2a211156eb5c7d860f4d6dce1599202101":{"kind":"REWORK","_number":2,"created":"2012-08-17 01:09:58.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/17/11517/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/17/11517/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/17/11517/2"}}},"commit":{"parents":[{"commit":"49428ad47f0c01a2dcc079975823f7b856fb165e","subject":"Sync changes from openstack common","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/49428ad47f0c01a2dcc079975823f7b856fb165e"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-08-16 23:51:04.000000000","tz":-420},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-08-17 01:09:46.000000000","tz":-420},"subject":"Makes sure tests don\u0027t leave lockfiles around","message":"Makes sure tests don\u0027t leave lockfiles around\n\nOur new lockfile code works fine if the locks already exist, but\nit is annoying to pollute the source tree with lockfiles in the\ntests.\n\nThis modifies the lockfile code slightly to use a tempdir if\nlock_path is none. Note that a tempdir will not work in production\nbut it is fine for testing. We set the lock_path to None in the\ntesting flags.\n\nAlso removes the explicit cleanup in run_tests.sh. The new solution\nworks with tox and will work even if we add new locks.\n\nFixes bug 1035426\n\nChange-Id: I613926e4288442e79df50ea5f5bd8f9eafdfe7e7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c2282a2a211156eb5c7d860f4d6dce1599202101"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c2282a2a211156eb5c7d860f4d6dce1599202101"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"49428ad47f0c01a2dcc079975823f7b856fb165e","is_merged_in_target_branch":true,"change_id":"Ica7a2e51ea38f37b315be2ff382d4a615dd67207","change_number":11515,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"00acbe57d62394d184dc3bf0cebc0f0e38659d1a":{"kind":"REWORK","_number":3,"created":"2012-08-17 16:18:35.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/17/11517/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/17/11517/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/17/11517/3"}}},"commit":{"parents":[{"commit":"72c7b866ed92d638bf8f5563ff7ea2568548764a","subject":"Merge \"Revert per-user-quotas\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/72c7b866ed92d638bf8f5563ff7ea2568548764a"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-08-16 23:51:04.000000000","tz":-420},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-08-17 16:18:33.000000000","tz":0},"subject":"Makes sure tests don\u0027t leave lockfiles around","message":"Makes sure tests don\u0027t leave lockfiles around\n\nOur new lockfile code works fine if the locks already exist, but\nit is annoying to pollute the source tree with lockfiles in the\ntests.\n\nThis modifies the lockfile code slightly to use a tempdir if\nlock_path is none. Note that a tempdir will not work in production\nbut it is fine for testing. We set the lock_path to None in the\ntesting flags.\n\nAlso removes the explicit cleanup in run_tests.sh. The new solution\nworks with tox and will work even if we add new locks.\n\nFixes bug 1035426\n\nChange-Id: I613926e4288442e79df50ea5f5bd8f9eafdfe7e7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/00acbe57d62394d184dc3bf0cebc0f0e38659d1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/00acbe57d62394d184dc3bf0cebc0f0e38659d1a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"72c7b866ed92d638bf8f5563ff7ea2568548764a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"10e25db4befe1173af516a053ac01f0f7b6dac56":{"kind":"REWORK","_number":4,"created":"2012-08-17 17:26:46.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/17/11517/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/17/11517/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/11517/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/17/11517/4"}}},"commit":{"parents":[{"commit":"740ebdce965d4d2ebe1050fe4de2b84d7726922f","subject":"Merge \"Remove unused imports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/740ebdce965d4d2ebe1050fe4de2b84d7726922f"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-08-16 23:51:04.000000000","tz":-420},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-08-17 17:26:42.000000000","tz":0},"subject":"Makes sure tests don\u0027t leave lockfiles around","message":"Makes sure tests don\u0027t leave lockfiles around\n\nOur new lockfile code works fine if the locks already exist, but\nit is annoying to pollute the source tree with lockfiles in the\ntests.\n\nThis modifies the lockfile code slightly to use a tempdir if\nlock_path is none. Note that a tempdir will not work in production\nbut it is fine for testing. We set the lock_path to None in the\ntesting flags.\n\nAlso removes the explicit cleanup in run_tests.sh. The new solution\nworks with tox and will work even if we add new locks.\n\nFixes bug 1035426\n\nChange-Id: I613926e4288442e79df50ea5f5bd8f9eafdfe7e7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/10e25db4befe1173af516a053ac01f0f7b6dac56"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/10e25db4befe1173af516a053ac01f0f7b6dac56"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"740ebdce965d4d2ebe1050fe4de2b84d7726922f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}