)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4885c97610ed8be13e5fa924adfa119e0322df6c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the ability to inject routes in interfaces.template"},{"line_number":10,"context_line":"by injecting them in the template engine."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic22c8af721d539c8180b5caa7ba348e834ddbb56"},{"line_number":13,"context_line":"Blueprint: network-template-routes-injection"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a961159_0f803345","line":11,"updated":"2014-12-18 16:14:59.000000000","message":"Needs the DocImpact tag according to this:\n\nhttp://docs.openstack.org/developer/nova/devref/kilo.blueprints.html#kilo\n\nAnd needs a nice detailed description of the feature for doc writers with the DocImpact tag since there is probably not going to be a spec for this.","commit_id":"e397ce07ba4c367531d9c73d0b1563d5de9e24ce"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"b8c99b2a1c6d4a7aa4e4ad97ae5862ff19f6e288","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the ability to inject routes in interfaces.template"},{"line_number":10,"context_line":"by injecting them in the template engine."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic22c8af721d539c8180b5caa7ba348e834ddbb56"},{"line_number":13,"context_line":"Blueprint: network-template-routes-injection"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a961159_6231c2ec","line":11,"in_reply_to":"3a961159_0f803345","updated":"2014-12-18 21:16:42.000000000","message":"Done. Let me know if I need to add more details to new commit message or format it in an other way.","commit_id":"e397ce07ba4c367531d9c73d0b1563d5de9e24ce"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8d565dec224ee2f5e01c0e2fb0e2cbf4af976eaa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"such as dhcp, l3, etc."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"See nova/tests/network/interfaces-override.template for an example"},{"line_number":25,"context_line":"on how to interact with the new interface \u0027routes\u0027 attribute."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Blueprint: network-template-routes-injection"},{"line_number":28,"context_line":"DocImpact: Routes are now available in the network template engine."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da86d52c_e1bdd304","line":25,"updated":"2015-02-16 20:32:26.000000000","message":"Can you actually just document the required additions in this commit message for sake of clarity","commit_id":"388f54515ac95755e3ccbb49c11baf5c57674300"}],"nova/tests/unit/network/test_network_info.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f6d3d196fc554307a652fd9c337027280a2b54b4","unresolved":false,"context_lines":[{"line_number":638,"context_line":"    def test_injection_static_overriden_template(self):"},{"line_number":639,"context_line":"        cfg.CONF.set_override("},{"line_number":640,"context_line":"            \u0027injected_network_template\u0027,"},{"line_number":641,"context_line":"            \u0027nova/tests/unit/network/interfaces-override.template\u0027)"},{"line_number":642,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":643,"context_line":"# Injected by Nova on instance boot"},{"line_number":644,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_0cdf6e3c","line":641,"updated":"2015-02-03 14:29:43.000000000","message":"Why do you need a different template here? can\u0027t we change the default so it works correctly?","commit_id":"ae28fcdffecef55f334d45861edfacc09d84ebf9"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"7ae08c5fce22b37d0eae13e09ee4be21edb0161d","unresolved":false,"context_lines":[{"line_number":638,"context_line":"    def test_injection_static_overriden_template(self):"},{"line_number":639,"context_line":"        cfg.CONF.set_override("},{"line_number":640,"context_line":"            \u0027injected_network_template\u0027,"},{"line_number":641,"context_line":"            \u0027nova/tests/unit/network/interfaces-override.template\u0027)"},{"line_number":642,"context_line":"        expected \u003d \"\"\"\\"},{"line_number":643,"context_line":"# Injected by Nova on instance boot"},{"line_number":644,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_a3f0ecfe","line":641,"in_reply_to":"da86d52c_0cdf6e3c","updated":"2015-02-04 21:35:07.000000000","message":"Should we forcefully inject the routes into the template? I don\u0027t feel I\u0027m the one that could make such call, I don\u0027t know the impact. My use case does not involve any dhcp, l3 agent, etc.","commit_id":"ae28fcdffecef55f334d45861edfacc09d84ebf9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f6d3d196fc554307a652fd9c337027280a2b54b4","unresolved":false,"context_lines":[{"line_number":780,"context_line":"    gateway 10.10.0.1"},{"line_number":781,"context_line":"    dns-nameservers 1.2.3.4 2.3.4.5"},{"line_number":782,"context_line":"    post-up ip -6 addr add 1234:567::2/48 dev ${IFACE}"},{"line_number":783,"context_line":"    post-up ip -6 route add default via 1234:567::1 dev ${IFACE}"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"auto eth1"},{"line_number":786,"context_line":"iface eth1 inet static"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_ac1662ef","line":783,"updated":"2015-02-03 14:29:43.000000000","message":"I am trying to figure out how these got here, and why you need a new template, and can\u0027t just update the existing one?","commit_id":"ae28fcdffecef55f334d45861edfacc09d84ebf9"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"7ae08c5fce22b37d0eae13e09ee4be21edb0161d","unresolved":false,"context_lines":[{"line_number":780,"context_line":"    gateway 10.10.0.1"},{"line_number":781,"context_line":"    dns-nameservers 1.2.3.4 2.3.4.5"},{"line_number":782,"context_line":"    post-up ip -6 addr add 1234:567::2/48 dev ${IFACE}"},{"line_number":783,"context_line":"    post-up ip -6 route add default via 1234:567::1 dev ${IFACE}"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"auto eth1"},{"line_number":786,"context_line":"iface eth1 inet static"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_a3d70c4a","line":783,"in_reply_to":"da86d52c_ac1662ef","updated":"2015-02-04 21:35:07.000000000","message":"Same comment and answer as above.","commit_id":"ae28fcdffecef55f334d45861edfacc09d84ebf9"}]}