)]}'
{"bin/nova-all":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"83ed0a164f9311a8c4770d4a2915844d9813486c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":25,"id":"AAAAOH%2F%2Fxro%3D","line":1,"updated":"2013-03-27 22:13:38.000000000","message":"You lost the she-bang line…","commit_id":"e7f9578f91111ad2595ecb013af41a7b1f9344ab"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cff63a6342ca464676608addac0a5d001f0989cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":25,"id":"AAAAOH%2F%2Fsvw%3D","line":1,"in_reply_to":"AAAAOH%2F%2FtS4%3D","updated":"2013-04-02 15:01:38.000000000","message":"Indeed, it\u0027s not.  However, the tests are clearly running these not-scripts directly, as is obvious from the error message—clearly an error from having the shell try to interpret a python script.  Since it was those tests that these were added back to address, I suggest either fixing those tests or adding the she-bang back…","commit_id":"e7f9578f91111ad2595ecb013af41a7b1f9344ab"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"5080a4b6a5e77692bf1da4b211d92ed18efdb7f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":25,"id":"AAAAOH%2F%2FtS4%3D","line":1,"in_reply_to":"AAAAOH%2F%2Fxro%3D","updated":"2013-04-02 04:26:18.000000000","message":"I did not lose the she-bang line. I deleted it on purpose. This is not supposed to be a script.","commit_id":"e7f9578f91111ad2595ecb013af41a7b1f9344ab"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"83ed0a164f9311a8c4770d4a2915844d9813486c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Temporary shim to do a devstack transition"},{"line_number":17,"context_line":"from nova.cmd import all"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"all.main()"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"AAAAOH%2F%2Fxrk%3D","line":17,"updated":"2013-03-27 22:13:38.000000000","message":"I would think you might need to restore the possible_topdir/sys.path.insert() logic in order for this to work properly…","commit_id":"e7f9578f91111ad2595ecb013af41a7b1f9344ab"}],"nova/cmd/baremetal_manage.py":[{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"6dc259feb3674b2fdbbca4d7ddce7635121ac143","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        cliutils.validate_args(fn, *fn_args, **fn_kwargs)"},{"line_number":198,"context_line":"    except cliutils.MissingArgs as e:"},{"line_number":199,"context_line":"        print(fn.__doc__)"},{"line_number":200,"context_line":"        parser.print_help()"},{"line_number":201,"context_line":"        print(e)"},{"line_number":202,"context_line":"        return(1)"},{"line_number":203,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAOH%2F%2Fso0%3D","line":200,"updated":"2013-04-02 15:53:53.000000000","message":"parser is undefined.","commit_id":"836533554c1be15535d21b297049784755e2cb03"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"765edb2c654c17d48342f58700f7c7794b7ad0a7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        cliutils.validate_args(fn, *fn_args, **fn_kwargs)"},{"line_number":198,"context_line":"    except cliutils.MissingArgs as e:"},{"line_number":199,"context_line":"        print(fn.__doc__)"},{"line_number":200,"context_line":"        parser.print_help()"},{"line_number":201,"context_line":"        print(e)"},{"line_number":202,"context_line":"        return(1)"},{"line_number":203,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAOX%2F%2F%2F3g%3D","line":200,"in_reply_to":"AAAAOH%2F%2Fso0%3D","updated":"2013-04-03 03:00:36.000000000","message":"This is also incorrect in the pre-entrypoints version of this code.","commit_id":"836533554c1be15535d21b297049784755e2cb03"}],"nova/cmd/manage.py":[{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"6dc259feb3674b2fdbbca4d7ddce7635121ac143","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            if host is None:"},{"line_number":272,"context_line":"                fixed_ips \u003d db.fixed_ip_get_all(ctxt)"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                fixed_ips \u003d db.fixed_ip_get_all_by_instance_host(ctxt, host)"},{"line_number":275,"context_line":"        except exception.NotFound as ex:"},{"line_number":276,"context_line":"            print _(\"error: %s\") % ex"},{"line_number":277,"context_line":"            return(2)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAOH%2F%2Fsos%3D","line":274,"updated":"2013-04-02 15:53:53.000000000","message":"fixed_ip_get_all_by_instance_host is no longer available.","commit_id":"836533554c1be15535d21b297049784755e2cb03"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"765edb2c654c17d48342f58700f7c7794b7ad0a7","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            if host is None:"},{"line_number":272,"context_line":"                fixed_ips \u003d db.fixed_ip_get_all(ctxt)"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                fixed_ips \u003d db.fixed_ip_get_all_by_instance_host(ctxt, host)"},{"line_number":275,"context_line":"        except exception.NotFound as ex:"},{"line_number":276,"context_line":"            print _(\"error: %s\") % ex"},{"line_number":277,"context_line":"            return(2)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAOX%2F%2F%2F3k%3D","line":274,"in_reply_to":"AAAAOH%2F%2Fsos%3D","updated":"2013-04-03 03:00:36.000000000","message":"This is true of the pre-entrypoints version of nova manage. It seems to be an error introduced with change bb867ce3948ddc23cf928ca3dda100a1a977896a quite some time ago. I have filed bug 1163660 to track this.","commit_id":"836533554c1be15535d21b297049784755e2cb03"}],"nova/cmd/nova_all.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"95ec91048fdd540039b173c88c022f94ba54fb8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"AAAAMX%2F%2F9FA%3D","side":"PARENT","line":31,"updated":"2012-12-05 06:44:28.000000000","message":"This was done early for a reason:\n\n  http://eventlet.net/doc/patching.html\n\n  It is important to call monkey_patch() as early in the lifetime of the application as possible. Try to do it as one of the first lines in the main module. The reason for this is that sometimes there is a class that inherits from a class that needs to be greened – e.g. a class that inherits from socket.socket – and inheritance is done at import time, so therefore the monkeypatching should happen before the derived class is defined. \n\n\nSo, why the change?","commit_id":"2b7583bc4d1b5673b89e1613e39dba1245f62778"}],"nova/cmd/nova_manage.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"61fb3d91ecd103f0b7c700adfb3c24547f04f178","unresolved":false,"context_lines":[{"line_number":796,"context_line":"    @args(\u0027--rxtx_factor\u0027, dest\u003d\u0027rxtx_factor\u0027, metavar\u003d\u0027\u003crxtx_factor\u003e\u0027,"},{"line_number":797,"context_line":"            help\u003d\u0027rxtx_factor\u0027)"},{"line_number":798,"context_line":"    @args(\u0027--is_public\u0027, dest\u003d\"is_public\", metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":799,"context_line":"            help\u003d\u0027Make flavor accessible to the public\u0027)"},{"line_number":800,"context_line":"    def create(self, name, memory, vcpus, root_gb, ephemeral_gb\u003d0, flavorid\u003dNone,"},{"line_number":801,"context_line":"               swap\u003d0, rxtx_factor\u003d1, is_public\u003dTrue):"},{"line_number":802,"context_line":"        \"\"\"Creates instance types / flavors\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F58Q%3D","line":799,"updated":"2012-10-29 17:18:46.000000000","message":"PEP8: over 80 columns","commit_id":"b0b95ca059e302744d166f43142b1bfcd1555e70"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"61fb3d91ecd103f0b7c700adfb3c24547f04f178","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"                        error_found +\u003d 1"},{"line_number":1125,"context_line":"                        if print_name \u003d\u003d 0:"},{"line_number":1126,"context_line":"                            print log_file + \":-\""},{"line_number":1127,"context_line":"                            print_name \u003d 1"},{"line_number":1128,"context_line":"                        print _(\u0027Line %d : %s\u0027) % (len(lines) - index, line)"},{"line_number":1129,"context_line":"        if error_found \u003d\u003d 0:"},{"line_number":1130,"context_line":"            print _(\u0027No errors in logfiles!\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F58E%3D","line":1127,"updated":"2012-10-29 17:18:46.000000000","message":"PEP8 (er, HACKING.rst): Need to use place-holders:\n\n    lno \u003d len(lines) - index\n    print _(\u0027Line %(lno)d : %(line)s\u0027) % locals()","commit_id":"b0b95ca059e302744d166f43142b1bfcd1555e70"}],"nova/cmd/nova_novncproxy.py":[{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"eb3c0df2e4253d13a4ce32fbd7f185c7f07e49d8","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def main():"},{"line_number":133,"context_line":"    if CONF.ssl_only and not os.path.exists(CONF.cert):"},{"line_number":134,"context_line":"        parser.error(\"SSL only and %s not found\" % CONF.cert)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    # Setup flags"},{"line_number":137,"context_line":"    config.parse_args(sys.argv)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAM3%2F%2Fzao%3D","line":134,"updated":"2013-01-04 16:01:30.000000000","message":"parser is not defined?","commit_id":"c149c6baa10c11fe5d088c6ffd9443442d157708"}],"nova/cmd/novncproxy.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cde1fd55df91474a53d17b170c0850aaaf5ead26","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    config.parse_args(sys.argv)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if CONF.ssl_only and not os.path.exists(CONF.cert):"},{"line_number":73,"context_line":"        parser.error(\"SSL only and %s not found\" % CONF.cert)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # Check to see if novnc html/js/css files are present"},{"line_number":76,"context_line":"    if not os.path.exists(CONF.web):"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAOH%2F%2Fxp4%3D","line":73,"updated":"2013-03-27 22:41:17.000000000","message":"The variable parser seems to have become orphaned.  This isn\u0027t due to this patch; I suspect it happened during the change-over to using cfg to parse the command line.  If you have an opportunity to fix it, that would probably be good.","commit_id":"e7f9578f91111ad2595ecb013af41a7b1f9344ab"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"5080a4b6a5e77692bf1da4b211d92ed18efdb7f0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    config.parse_args(sys.argv)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if CONF.ssl_only and not os.path.exists(CONF.cert):"},{"line_number":73,"context_line":"        parser.error(\"SSL only and %s not found\" % CONF.cert)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # Check to see if novnc html/js/css files are present"},{"line_number":76,"context_line":"    if not os.path.exists(CONF.web):"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAOH%2F%2FtSk%3D","line":73,"in_reply_to":"AAAAOH%2F%2Fxp4%3D","updated":"2013-04-02 04:26:18.000000000","message":"Gotcha.","commit_id":"e7f9578f91111ad2595ecb013af41a7b1f9344ab"}],"nova/service.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"95ec91048fdd540039b173c88c022f94ba54fb8b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova import version"},{"line_number":45,"context_line":"from nova import wsgi"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"gettext.install(\u0027nova\u0027, unicode\u003d1)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAMX%2F%2F9Fc%3D","line":47,"updated":"2012-12-05 06:44:28.000000000","message":"Why is this needed?","commit_id":"70455e742b791e80e61ddd93d3b0dfcf651c3959"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"95ec91048fdd540039b173c88c022f94ba54fb8b","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        :param periodic_fuzzy_delay: defaults to CONF.periodic_fuzzy_delay"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        \"\"\""},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        if not host:"},{"line_number":481,"context_line":"            host \u003d CONF.host"},{"line_number":482,"context_line":"        if not binary:"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAMX%2F%2F9FY%3D","line":479,"updated":"2012-12-05 06:44:28.000000000","message":"Spurious","commit_id":"70455e742b791e80e61ddd93d3b0dfcf651c3959"}],"nova/tests/test_nova_manage.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"95ec91048fdd540039b173c88c022f94ba54fb8b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"sys.dont_write_bytecode \u003d True"},{"line_number":37,"context_line":"nova_manage \u003d imp.load_source(\u0027nova_manage\u0027, NOVA_MANAGE_PATH)"},{"line_number":38,"context_line":"sys.dont_write_bytecode \u003d False"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class FixedIpCommandsTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAMX%2F%2F9FU%3D","side":"PARENT","line":38,"updated":"2012-12-05 06:44:28.000000000","message":"Nice to be getting rid of this :)","commit_id":"2b7583bc4d1b5673b89e1613e39dba1245f62778"}],"setup.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d3c65bc4e535d3fd30e66b8e260a5cb8f9667c7a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"              \u0027nova-api-metadata \u003d nova.cmd.api_metadata:main\u0027,"},{"line_number":57,"context_line":"              \u0027nova-api-os-compute \u003d nova.cmd.api_os_compute:main\u0027,"},{"line_number":58,"context_line":"              \u0027nova-baremetal-deploy-helper\u0027"},{"line_number":59,"context_line":"              \u0027 \u003d nova.cmd.baremetal_deploy_helper:main\u0027,"},{"line_number":60,"context_line":"              \u0027nova-baremetal-manage \u003d nova.cmd.baremetal_manage:main\u0027,"},{"line_number":61,"context_line":"              \u0027nova-rpc-zmq-receiver \u003d nova.cmd.rpc_zmq_receiver:main\u0027,"},{"line_number":62,"context_line":"              \u0027nova-cells \u003d nova.cmd.cells:main\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAOH%2F%2FySo%3D","line":59,"updated":"2013-03-27 15:50:41.000000000","message":"I slightly prefer having the \u0027\u003d\u0027 at the end of the previous line, with this line indented an extra few spaces…\n\n(attonit)","commit_id":"f1a0f1a29aef6786d311d1530b18899cfd298b44"}]}