)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"1ea3cf0ef8231af102eb87d818ce850e47d2af1b","unresolved":false,"context_lines":[{"line_number":2138,"context_line":"                LOG.exception(msg % locals(), context\u003dcontext,"},{"line_number":2139,"context_line":"                              instance\u003dinstance)"},{"line_number":2140,"context_line":"                volume \u003d self.volume_api.get(context, volume_id)"},{"line_number":2141,"context_line":"                self.volume_api.roll_detaching(context, volume)"},{"line_number":2142,"context_line":""},{"line_number":2143,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":2144,"context_line":"    @reverts_task_state"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FrQE%3D","line":2141,"updated":"2012-08-21 13:41:26.000000000","message":"It strikes me that we handle this for compute status using task_state and the @reverts_task_state decorator\n\nShould we do similar for volumes?\n\nI guess this is a longer-term question, so feel free to ignore","commit_id":"c0a9e693bedd26e1a3be6e3d36bafce7a5b905ca"}],"nova/volume/cinder.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"1ea3cf0ef8231af102eb87d818ce850e47d2af1b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        cinderclient(context).volumes.begin_detaching(volume[\u0027id\u0027])"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def roll_detaching(self, context, volume):"},{"line_number":158,"context_line":"        cinderclient(context).volumes.roll_detaching(volume[\u0027id\u0027])"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def attach(self, context, volume, instance_uuid, mountpoint):"},{"line_number":161,"context_line":"        cinderclient(context).volumes.attach(volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FrQA%3D","line":158,"updated":"2012-08-21 13:41:26.000000000","message":"These haven\u0027t been added to cinder yet, have they?","commit_id":"c0a9e693bedd26e1a3be6e3d36bafce7a5b905ca"}]}