)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"447af76a79ee4ba701f69b5f375b10bd6ac34431","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running the \"migrate\" operation and the"},{"line_number":10,"context_line":"CONF.allow_resize_to_same_host is set as \"false\","},{"line_number":11,"context_line":"the CONF.allow_migrate_to_same_host doesn\u0027t work"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4c54c7c6e0e5e37cc46c52350ba4ce2047325ef9"},{"line_number":14,"context_line":"Closes-Bug: #1364851"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_0bf30374","line":11,"updated":"2014-09-08 23:37:48.000000000","message":"I believe you should add more info to your commit message of why it does not work.  I see in your code that you added flavor_id to the if statement, please explain.","commit_id":"56b53eca2899ba44d7213e546a01268f248ca447"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6a5723e4310802ebe25327fef623e3317ad176f8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When running the \"migrate\" operation and the"},{"line_number":10,"context_line":"CONF.allow_resize_to_same_host is set as \"false\","},{"line_number":11,"context_line":"the CONF.allow_migrate_to_same_host doesn\u0027t work"},{"line_number":12,"context_line":"in the function \u0027resize\u0027 from nova\\compute\\api.py."},{"line_number":13,"context_line":"At the same time, there is no checking the"},{"line_number":14,"context_line":"CONF.allow_migrate_to_same_host in the function"},{"line_number":15,"context_line":"_prep_resize from nova/compute/manager.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"dac4157f_a8f99a4f","line":12,"updated":"2015-04-20 19:34:22.000000000","message":"It\u0027s \u0027/\u0027 not \u0027\\\u0027 (femtonit)","commit_id":"99eaa9f59286e46ab1b5f47b26e6722888a1cebe"},{"author":{"_account_id":11530,"name":"zhangtralon","email":"ztralon@hotmail.com","username":"zhangtralon"},"change_message_id":"94cf08a875b9ba7abdc1baaf0e2959f06b852af0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When running the \"migrate\" operation and the"},{"line_number":10,"context_line":"CONF.allow_resize_to_same_host is set as \"false\","},{"line_number":11,"context_line":"the CONF.allow_migrate_to_same_host doesn\u0027t work"},{"line_number":12,"context_line":"in the function \u0027resize\u0027 from nova\\compute\\api.py."},{"line_number":13,"context_line":"At the same time, there is no checking the"},{"line_number":14,"context_line":"CONF.allow_migrate_to_same_host in the function"},{"line_number":15,"context_line":"_prep_resize from nova/compute/manager.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"dac4157f_ac1764a2","line":12,"in_reply_to":"dac4157f_a8f99a4f","updated":"2015-04-21 00:48:23.000000000","message":"thanks","commit_id":"99eaa9f59286e46ab1b5f47b26e6722888a1cebe"}],"nova/compute/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7459cea255b8d86cc31a814c889e493eb355d549","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                default\u003dFalse,"},{"line_number":85,"context_line":"                help\u003d\u0027Allow destination machine to match source for resize. \u0027"},{"line_number":86,"context_line":"                     \u0027Useful when testing in single-host environments.\u0027),"},{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027allow_migrate_to_same_host\u0027,"},{"line_number":88,"context_line":"                default\u003dFalse,"},{"line_number":89,"context_line":"                help\u003d\u0027Allow migrate machine to the same host. \u0027"},{"line_number":90,"context_line":"                     \u0027Useful when testing in single-host environments.\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aa7fdbe_f4f1ee01","side":"PARENT","line":87,"updated":"2014-10-23 13:06:40.000000000","message":"the vmware driver makes use of this flag. we cannot drop this.","commit_id":"e70b2a805aab6f8ea9bc25e3c72bb3eeb8b36785"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"dfd5636d27f45ed946cc8abe7632b2ea273736c2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                default\u003dFalse,"},{"line_number":85,"context_line":"                help\u003d\u0027Allow destination machine to match source for resize. \u0027"},{"line_number":86,"context_line":"                     \u0027Useful when testing in single-host environments.\u0027),"},{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027allow_migrate_to_same_host\u0027,"},{"line_number":88,"context_line":"                default\u003dFalse,"},{"line_number":89,"context_line":"                help\u003d\u0027Allow migrate machine to the same host. \u0027"},{"line_number":90,"context_line":"                     \u0027Useful when testing in single-host environments.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8c0949_2e300756","side":"PARENT","line":87,"updated":"2014-10-29 21:40:31.000000000","message":"Instead of dropping one of the config options all together, aren\u0027t we trying to merge them instead? Since as is you cannot really set one to True and the other to False. To do that we can rename one of the options to reflect its for both resize and migrate and leave the other but marked as DEPRECATED for a cycle.","commit_id":"e70b2a805aab6f8ea9bc25e3c72bb3eeb8b36785"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6e5907c1bb220cb3b568e7834d78f3c7b7852fca","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                default\u003dFalse,"},{"line_number":85,"context_line":"                help\u003d\u0027Allow destination machine to match source for resize. \u0027"},{"line_number":86,"context_line":"                     \u0027Useful when testing in single-host environments.\u0027),"},{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027allow_migrate_to_same_host\u0027,"},{"line_number":88,"context_line":"                default\u003dFalse,"},{"line_number":89,"context_line":"                help\u003d\u0027Allow migrate machine to the same host. \u0027"},{"line_number":90,"context_line":"                     \u0027Useful when testing in single-host environments.\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8c0949_407dc1e6","side":"PARENT","line":87,"in_reply_to":"7a8c0949_2e300756","updated":"2014-11-05 19:18:11.000000000","message":"+1","commit_id":"e70b2a805aab6f8ea9bc25e3c72bb3eeb8b36785"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6e5907c1bb220cb3b568e7834d78f3c7b7852fca","unresolved":false,"context_lines":[{"line_number":3597,"context_line":""},{"line_number":3598,"context_line":"        same_host \u003d instance[\u0027host\u0027] \u003d\u003d self.host"},{"line_number":3599,"context_line":"        # if the flavor IDs match, it\u0027s migrate; otherwise resize"},{"line_number":3600,"context_line":"        if same_host and instance_type[\u0027id\u0027] \u003d\u003d instance[\u0027instance_type_id\u0027]:"},{"line_number":3601,"context_line":"            # check driver whether support migrate to same host"},{"line_number":3602,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3603,"context_line":"                msg \u003d _(\"the compute driver does not support \""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8c0949_207a75f1","line":3600,"updated":"2014-11-05 19:18:11.000000000","message":"why not:\nif (same_host and\n    instance_type[\u0027id\u0027] \u003d\u003d instance[\u0027instance_type_id\u0027] and\n    not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]):\n    msg \u003d _(....)","commit_id":"76dcfbc155537aee8306a3d6f8c67420134fa446"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6e5907c1bb220cb3b568e7834d78f3c7b7852fca","unresolved":false,"context_lines":[{"line_number":3600,"context_line":"        if same_host and instance_type[\u0027id\u0027] \u003d\u003d instance[\u0027instance_type_id\u0027]:"},{"line_number":3601,"context_line":"            # check driver whether support migrate to same host"},{"line_number":3602,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3603,"context_line":"                msg \u003d _(\"the compute driver does not support \""},{"line_number":3604,"context_line":"                        \"migrate to same host!\")"},{"line_number":3605,"context_line":"                raise exception.MigrationError(msg)"},{"line_number":3606,"context_line":"        elif same_host and not CONF.allow_resize_to_same_host:"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8c0949_001c99c0","line":3603,"updated":"2014-11-05 19:18:11.000000000","message":"the \u003d\u003e The","commit_id":"76dcfbc155537aee8306a3d6f8c67420134fa446"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"add805d12a3cbe0d75396a218b2b6148618694cb","unresolved":false,"context_lines":[{"line_number":3652,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3653,"context_line":"                msg \u003d _(\"the compute driver does not support \""},{"line_number":3654,"context_line":"                        \"migrate to same host!\")"},{"line_number":3655,"context_line":"                raise exception.MigrationError(msg)"},{"line_number":3656,"context_line":"        elif same_host and not CONF.allow_resize_to_same_host:"},{"line_number":3657,"context_line":"            self._set_instance_error_state(context, instance)"},{"line_number":3658,"context_line":"            msg \u003d _(\u0027destination same as source!\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_d668c089","line":3655,"range":{"start_line":3655,"start_character":32,"end_line":3655,"end_character":46},"updated":"2015-02-09 12:25:01.000000000","message":"exception.MigrationError(reason\u003dmsg)","commit_id":"a448a91366c80a3ebb8aadf1cf93abb1d4dbdc05"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"fcf68a4f7e2e812f19350999053ddc00086b6a11","unresolved":false,"context_lines":[{"line_number":3689,"context_line":"        if same_host and instance_type[\u0027id\u0027] \u003d\u003d instance[\u0027instance_type_id\u0027]:"},{"line_number":3690,"context_line":"            # check driver whether support migrate to same host"},{"line_number":3691,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3692,"context_line":"                msg \u003d _(\"the compute driver does not support \""},{"line_number":3693,"context_line":"                        \"migrate to same host!\")"},{"line_number":3694,"context_line":"                raise exception.MigrationError(reason\u003dmsg)"},{"line_number":3695,"context_line":"        elif same_host and not CONF.allow_resize_to_same_host:"}],"source_content_type":"text/x-python","patch_set":16,"id":"baa041b7_7e3b1fd2","line":3692,"updated":"2015-04-03 12:49:00.000000000","message":"First word should be capitalized - s/the/The/","commit_id":"800fee0bbc8c56fa73e6c7b5745a2d7dac425b0d"},{"author":{"_account_id":11530,"name":"zhangtralon","email":"ztralon@hotmail.com","username":"zhangtralon"},"change_message_id":"cbfad742e4a50dccd669aa63676f5709a63b40d9","unresolved":false,"context_lines":[{"line_number":3689,"context_line":"        if same_host and instance_type[\u0027id\u0027] \u003d\u003d instance[\u0027instance_type_id\u0027]:"},{"line_number":3690,"context_line":"            # check driver whether support migrate to same host"},{"line_number":3691,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3692,"context_line":"                msg \u003d _(\"the compute driver does not support \""},{"line_number":3693,"context_line":"                        \"migrate to same host!\")"},{"line_number":3694,"context_line":"                raise exception.MigrationError(reason\u003dmsg)"},{"line_number":3695,"context_line":"        elif same_host and not CONF.allow_resize_to_same_host:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa53dc9_4959cb59","line":3692,"in_reply_to":"baa041b7_2e4d576c","updated":"2015-04-08 01:58:12.000000000","message":"I think that the consistency of log format is important! thanks.","commit_id":"800fee0bbc8c56fa73e6c7b5745a2d7dac425b0d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5dfaa0b71553146b72d2a555a3876bc5994eb9d3","unresolved":false,"context_lines":[{"line_number":3689,"context_line":"        if same_host and instance_type[\u0027id\u0027] \u003d\u003d instance[\u0027instance_type_id\u0027]:"},{"line_number":3690,"context_line":"            # check driver whether support migrate to same host"},{"line_number":3691,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3692,"context_line":"                msg \u003d _(\"the compute driver does not support \""},{"line_number":3693,"context_line":"                        \"migrate to same host!\")"},{"line_number":3694,"context_line":"                raise exception.MigrationError(reason\u003dmsg)"},{"line_number":3695,"context_line":"        elif same_host and not CONF.allow_resize_to_same_host:"}],"source_content_type":"text/x-python","patch_set":16,"id":"baa041b7_2e4d576c","line":3692,"in_reply_to":"baa041b7_7e3b1fd2","updated":"2015-04-03 22:29:27.000000000","message":"Actually, I believe we\u0027re in string freeze right now.  Looking at the catalog, you may be able to use the message for UnableToMigrateToSelf (exceptions.py); that message reads:\n\n    Unable to migrate instance (%(instance_id)s) to current host (%(host)s).","commit_id":"800fee0bbc8c56fa73e6c7b5745a2d7dac425b0d"},{"author":{"_account_id":11530,"name":"zhangtralon","email":"ztralon@hotmail.com","username":"zhangtralon"},"change_message_id":"cbfad742e4a50dccd669aa63676f5709a63b40d9","unresolved":false,"context_lines":[{"line_number":3689,"context_line":"        if same_host and instance_type[\u0027id\u0027] \u003d\u003d instance[\u0027instance_type_id\u0027]:"},{"line_number":3690,"context_line":"            # check driver whether support migrate to same host"},{"line_number":3691,"context_line":"            if not self.driver.capabilities[\u0027supports_migrate_to_same_host\u0027]:"},{"line_number":3692,"context_line":"                msg \u003d _(\"the compute driver does not support \""},{"line_number":3693,"context_line":"                        \"migrate to same host!\")"},{"line_number":3694,"context_line":"                raise exception.MigrationError(reason\u003dmsg)"},{"line_number":3695,"context_line":"        elif same_host and not CONF.allow_resize_to_same_host:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa53dc9_895fd340","line":3692,"in_reply_to":"baa041b7_7e3b1fd2","updated":"2015-04-08 01:58:12.000000000","message":"yeah, It\u0027s really a mistake. thanks!","commit_id":"800fee0bbc8c56fa73e6c7b5745a2d7dac425b0d"}],"nova/exception.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"6fe796aabf2c96958e25398d0b2c6a86d24814f8","unresolved":false,"context_lines":[{"line_number":459,"context_line":"class ComputeServiceInUse(NovaException):"},{"line_number":460,"context_line":"    msg_fmt \u003d _(\"Compute service of %(host)s is still in use.\")"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"class UnableToMigrateToSelf(Invalid):"},{"line_number":464,"context_line":"    msg_fmt \u003d _(\"Unable to migrate instance (%(instance_id)s) \""},{"line_number":465,"context_line":"                \"to current host (%(host)s).\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"dac4157f_38ef40b2","line":462,"updated":"2015-04-20 00:29:21.000000000","message":"defined here","commit_id":"2756147eb61734b521b244872e7b4b04009944c2"},{"author":{"_account_id":11530,"name":"zhangtralon","email":"ztralon@hotmail.com","username":"zhangtralon"},"change_message_id":"588c7ee890db98db6e231b4a2769b123c17712f3","unresolved":false,"context_lines":[{"line_number":459,"context_line":"class ComputeServiceInUse(NovaException):"},{"line_number":460,"context_line":"    msg_fmt \u003d _(\"Compute service of %(host)s is still in use.\")"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"class UnableToMigrateToSelf(Invalid):"},{"line_number":464,"context_line":"    msg_fmt \u003d _(\"Unable to migrate instance (%(instance_id)s) \""},{"line_number":465,"context_line":"                \"to current host (%(host)s).\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"dac4157f_5b766e3f","line":462,"in_reply_to":"dac4157f_38ef40b2","updated":"2015-04-20 03:04:22.000000000","message":"my God, it is really reduplicative. thanks","commit_id":"2756147eb61734b521b244872e7b4b04009944c2"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"6fe796aabf2c96958e25398d0b2c6a86d24814f8","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"    msg_fmt \u003d _(\"Migration error: %(reason)s\")"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"class UnableToMigrateToSelf(NovaException):"},{"line_number":1211,"context_line":"    msg_fmt \u003d _("},{"line_number":1212,"context_line":"        \"Unable to migrate instance %(instance_id)s to current host %(host)s\")"},{"line_number":1213,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"dac4157f_b802306e","line":1210,"updated":"2015-04-20 00:29:21.000000000","message":"redefined see line 463","commit_id":"2756147eb61734b521b244872e7b4b04009944c2"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"6fe796aabf2c96958e25398d0b2c6a86d24814f8","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"class UnableToMigrateToSelf(NovaException):"},{"line_number":1211,"context_line":"    msg_fmt \u003d _("},{"line_number":1212,"context_line":"        \"Unable to migrate instance %(instance_id)s to current host %(host)s\")"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"class MigrationPreCheckError(MigrationError):"},{"line_number":1215,"context_line":"    msg_fmt \u003d _(\"Migration pre-check error: %(reason)s\")"},{"line_number":1216,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"dac4157f_38d8601d","line":1213,"updated":"2015-04-20 00:29:21.000000000","message":"need one more blank line here","commit_id":"2756147eb61734b521b244872e7b4b04009944c2"}],"nova/tests/compute/test_compute_api.py":[{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"402e7fe7b267f963c118d7eeaaa588e17ba3faf4","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"            else:"},{"line_number":1113,"context_line":"                filter_properties \u003d {\u0027ignore_hosts\u0027: [fake_inst[\u0027host\u0027]]}"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"            if not flavor_id_passed and not allow_mig_same_host:"},{"line_number":1116,"context_line":"                filter_properties[\u0027ignore_hosts\u0027].append(fake_inst[\u0027host\u0027])"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"            expected_reservations \u003d fake_quotas.reservations"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_f7f15602","line":1115,"range":{"start_line":1115,"start_character":44,"end_line":1115,"end_character":63},"updated":"2014-09-17 09:51:59.000000000","message":"NameError: global name \u0027allow_mig_same_host\u0027 is not defined","commit_id":"792a4fda8bbd852a01d1b0fd8463ee1ff1605a8b"}]}