)]}'
{"nova/api/auth.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"5fcffbdaf0531d699e9012d67b0cb322c5844f54","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            # Fallback to deprecated role header:"},{"line_number":86,"context_line":"            roles \u003d [r.strip() for r in"},{"line_number":87,"context_line":"                     req.headers.get(\u0027X_ROLE\u0027, \u0027\u0027).split(\u0027,\u0027)]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if \u0027X_TENANT_ID\u0027 in req.headers:"},{"line_number":90,"context_line":"            # This is the new header since Keystone went to ID/Name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FnhA%3D","line":87,"updated":"2012-08-27 03:15:41.000000000","message":"I think I\u0027d prefer to see the splitting happening outside of this block. For example:\n\n  if \u0027X_ROLES\u0027 in req.headers():\n      roles \u003d req.headers[\u0027X_ROLES\u0027]\n  else:\n      roles \u003d req.headers.get(\u0027X_ROLE\u0027, \u0027\u0027)\n  roles \u003d [r.strip() for r in roles.split(\u0027,\u0027)]","commit_id":"66a611c98659e160ab6029f293fd9ebf16fee82f"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"7a4a4b964438c9bbc9d73f66e74d58f32ec92780","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def _get_roles(self, req):"},{"line_number":123,"context_line":"        \"\"\"Get the list of roles\"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        LOG.info(\"poop\")"},{"line_number":126,"context_line":"        roles \u003d \u0027\u0027"},{"line_number":127,"context_line":"        if \u0027X_ROLES\u0027 in req.headers:"},{"line_number":128,"context_line":"            roles \u003d req.headers.get(\u0027X_ROLES\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FmXs%3D","line":125,"updated":"2012-08-28 15:56:36.000000000","message":"lol","commit_id":"67983c0ca540819cb5f70290dfa9fabb29861009"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"7a4a4b964438c9bbc9d73f66e74d58f32ec92780","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \"\"\"Get the list of roles\"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        LOG.info(\"poop\")"},{"line_number":126,"context_line":"        roles \u003d \u0027\u0027"},{"line_number":127,"context_line":"        if \u0027X_ROLES\u0027 in req.headers:"},{"line_number":128,"context_line":"            roles \u003d req.headers.get(\u0027X_ROLES\u0027, \u0027\u0027)"},{"line_number":129,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FmXk%3D","line":126,"updated":"2012-08-28 15:56:36.000000000","message":"This line doesn\u0027t apear to be needed since both branches of the if/else define `roles`.","commit_id":"67983c0ca540819cb5f70290dfa9fabb29861009"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"7a4a4b964438c9bbc9d73f66e74d58f32ec92780","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        if \u0027X_ROLES\u0027 in req.headers:"},{"line_number":128,"context_line":"            roles \u003d req.headers.get(\u0027X_ROLES\u0027, \u0027\u0027)"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            # Fallback to deprecated role header:"},{"line_number":131,"context_line":"            roles \u003d req.headers.get(\u0027X_ROLE\u0027, \u0027\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        return [r.strip() for r in roles.split(\u0027,\u0027)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FmXo%3D","line":130,"updated":"2012-08-28 15:56:36.000000000","message":"Since it\u0027s deprecated, should we toss in a warning of some kind, to nudge people in the direction of using X_ROLES?","commit_id":"67983c0ca540819cb5f70290dfa9fabb29861009"}]}