)]}'
{"nova/virt/vmwareapi/vmware_images.py":[{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"149544a2f414207480ef4f51994e1a5945feb60c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            linked_clone(bool): use linked clone, or don\u0027t"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        self.image_id \u003d image_id"},{"line_number":68,"context_line":"        self.file_size \u003d int(file_size)"},{"line_number":69,"context_line":"        self.os_type \u003d os_type"},{"line_number":70,"context_line":"        self.adapter_type \u003d adapter_type"},{"line_number":71,"context_line":"        self.disk_type \u003d disk_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_8dc2a032","line":68,"updated":"2014-09-18 07:40:09.000000000","message":"The docstring says that file_size is int which means that you need to do the conversion where this constructor is being called and pass the correct types","commit_id":"8f6b671803b648d4fe7383996710b2f88d8063de"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"1aefc49063a2f68575281cdea8fee974c00429a7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            linked_clone(bool): use linked clone, or don\u0027t"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        self.image_id \u003d image_id"},{"line_number":68,"context_line":"        self.file_size \u003d int(file_size)"},{"line_number":69,"context_line":"        self.os_type \u003d os_type"},{"line_number":70,"context_line":"        self.adapter_type \u003d adapter_type"},{"line_number":71,"context_line":"        self.disk_type \u003d disk_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_60173346","line":68,"in_reply_to":"fa98f980_3433b5f7","updated":"2014-09-18 16:24:54.000000000","message":"No, it is not cleaner, it is a design mistake. We define a contract and callers should abide the contract. For example time.sleep(\u00275\u0027) is not the same as time.sleep(5), right? The former throws an error and the latter works.","commit_id":"8f6b671803b648d4fe7383996710b2f88d8063de"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"0ab499536bde076560b754eb699f21fac4a30793","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            linked_clone(bool): use linked clone, or don\u0027t"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        self.image_id \u003d image_id"},{"line_number":68,"context_line":"        self.file_size \u003d int(file_size)"},{"line_number":69,"context_line":"        self.os_type \u003d os_type"},{"line_number":70,"context_line":"        self.adapter_type \u003d adapter_type"},{"line_number":71,"context_line":"        self.disk_type \u003d disk_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_5b71440b","line":68,"in_reply_to":"fa98f980_60173346","updated":"2014-09-18 17:31:26.000000000","message":"Ok, I agree.  I will make an update.","commit_id":"8f6b671803b648d4fe7383996710b2f88d8063de"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"925ec9848225f635cbd928f1384fed4cacc17a05","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            linked_clone(bool): use linked clone, or don\u0027t"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        self.image_id \u003d image_id"},{"line_number":68,"context_line":"        self.file_size \u003d int(file_size)"},{"line_number":69,"context_line":"        self.os_type \u003d os_type"},{"line_number":70,"context_line":"        self.adapter_type \u003d adapter_type"},{"line_number":71,"context_line":"        self.disk_type \u003d disk_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_3433b5f7","line":68,"in_reply_to":"fa98f980_8dc2a032","updated":"2014-09-18 14:28:04.000000000","message":"I could change nova/virt/vmwareapi/vmops.py, but what would keep a similar problem from occurring again?  Would it not be better to make sure it is an int in this class, than to chase down multiple places where it could happen?  It is cleaner.","commit_id":"8f6b671803b648d4fe7383996710b2f88d8063de"}]}