)]}'
{"nova/hacking/checks.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"46bec1f9c57dd7670a08ea8519c5475b954aa4d5","unresolved":false,"context_lines":[{"line_number":352,"context_line":"           \"once_with to test with explicit parameters or an assertEqual with\""},{"line_number":353,"context_line":"           \" call_count.\")"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    pos \u003d logical_line.find(\u0027.assert_called_once(\u0027)"},{"line_number":356,"context_line":"    if pos !\u003d -1:"},{"line_number":357,"context_line":"        yield (pos, msg)"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_b8cb6149","line":355,"updated":"2014-09-16 11:47:56.000000000","message":"we might want to save some time scanning only lines in test files?\n\nAlso it is not uncommon to make a typo like \u0027assert_called_once_wiht()\u0027 which is just as bad and would not get caught by this check? Do we need to maybe prevent the use of any of the assert mock methods that can pass as a method call (IMHO one of the horrible design flaws of mock)","commit_id":"fd01956d392a7b72fdb0b21569332296551281a5"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"3d7101e60a0b7567f1793d7b9f3fb356bc4322a5","unresolved":false,"context_lines":[{"line_number":352,"context_line":"           \"once_with to test with explicit parameters or an assertEqual with\""},{"line_number":353,"context_line":"           \" call_count.\")"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    pos \u003d logical_line.find(\u0027.assert_called_once(\u0027)"},{"line_number":356,"context_line":"    if pos !\u003d -1:"},{"line_number":357,"context_line":"        yield (pos, msg)"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_98093d35","line":355,"in_reply_to":"fa98f980_b8cb6149","updated":"2014-09-16 11:57:29.000000000","message":"Ack. will scan only files in tests directory and below.\n\nYes, this rule does not catch the typos etc.","commit_id":"fd01956d392a7b72fdb0b21569332296551281a5"}]}