)]}'
{"nova/tests/network/test_neutronv2.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e6359e04fa8fc64cbbd882f1bc7c83cf3a62b9e6","unresolved":false,"context_lines":[{"line_number":2493,"context_line":"            if nw_info[\u0027type\u0027] \u003d\u003d model.VIF_TYPE_BRIDGE:"},{"line_number":2494,"context_line":"                self.assertEqual(nw_info[\u0027network\u0027][\u0027bridge\u0027], \u0027brqnet-id\u0027)"},{"line_number":2495,"context_line":"            self.assertEqual(nw_info[\u0027vnic_type\u0027],"},{"line_number":2496,"context_line":"                                requested_ports[index].get(\u0027binding:vnic_type\u0027,"},{"line_number":2497,"context_line":"                                    model.VNIC_TYPE_NORMAL))"},{"line_number":2498,"context_line":"            self.assertEqual(nw_info.get(\u0027details\u0027),"},{"line_number":2499,"context_line":"                             requested_ports[index].get(\u0027binding:vif_details\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_b143376b","line":2496,"updated":"2014-09-18 14:26:55.000000000","message":"nit: alignment is off here now.","commit_id":"354840aa4b1d0cf67c5cce37bac74c5526df74d5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d8cbaf34bcdee6c574d8488fc3b4a2073fd7a794","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                self.assertEqual(nw_info[\u0027network\u0027][\u0027bridge\u0027], \u0027brqnet-id\u0027)"},{"line_number":2495,"context_line":"            self.assertEqual(nw_info[\u0027vnic_type\u0027],"},{"line_number":2496,"context_line":"                                requested_ports[index].get(\u0027binding:vnic_type\u0027,"},{"line_number":2497,"context_line":"                                    model.VNIC_TYPE_NORMAL))"},{"line_number":2498,"context_line":"            self.assertEqual(nw_info.get(\u0027details\u0027),"},{"line_number":2499,"context_line":"                             requested_ports[index].get(\u0027binding:vif_details\u0027))"},{"line_number":2500,"context_line":"            self.assertEqual(nw_info.get(\u0027profile\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_f1ae9f2e","line":2497,"updated":"2014-09-18 14:23:47.000000000","message":"Hmm, do we really want that here? oh wait, I see now, makes sense.","commit_id":"354840aa4b1d0cf67c5cce37bac74c5526df74d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e6359e04fa8fc64cbbd882f1bc7c83cf3a62b9e6","unresolved":false,"context_lines":[{"line_number":2606,"context_line":"        self.assertFalse(phynet_name)"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"    @mock.patch.object(neutronv2, \u0027get_client\u0027, return_value\u003dmock.Mock())"},{"line_number":2609,"context_line":"    def test_get_port_vnic_info_3(self, mock_get_client):"},{"line_number":2610,"context_line":"        api \u003d neutronapi.API()"},{"line_number":2611,"context_line":"        self.mox.ResetAll()"},{"line_number":2612,"context_line":"        test_port \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_b4088529","line":2609,"updated":"2014-09-18 14:26:55.000000000","message":"This could have been easily combined with test_get_port_vnic_info_2 and just pass in the vnic_type (None in this case) so we wouldn\u0027t have all the copy/paste.","commit_id":"354840aa4b1d0cf67c5cce37bac74c5526df74d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e6359e04fa8fc64cbbd882f1bc7c83cf3a62b9e6","unresolved":false,"context_lines":[{"line_number":2623,"context_line":""},{"line_number":2624,"context_line":"        mock_client.show_port.assert_called_once_with(test_port[\u0027port\u0027][\u0027id\u0027],"},{"line_number":2625,"context_line":"            fields\u003d[\u0027binding:vnic_type\u0027, \u0027network_id\u0027])"},{"line_number":2626,"context_line":"        self.assertEqual(model.VNIC_TYPE_NORMAL, vnic_type)"},{"line_number":2627,"context_line":""},{"line_number":2628,"context_line":"    @mock.patch.object(neutronapi.API, \"_get_port_vnic_info\")"},{"line_number":2629,"context_line":"    @mock.patch.object(neutronv2, \u0027get_client\u0027, return_value\u003dmock.Mock())"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_d40b4922","line":2626,"updated":"2014-09-18 14:26:55.000000000","message":"Could probably also assert this:\n\nself.assertFalse(phynet_name)","commit_id":"354840aa4b1d0cf67c5cce37bac74c5526df74d5"}]}
