)]}'
{"nova/network/quantumv2/api.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"924abeaf43d93a337c50552d2c681cbdd83c85f0","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # current tenant, returned subnets may contain subnets which is not"},{"line_number":342,"context_line":"        # related to the port. To avoid this, the method returns here."},{"line_number":343,"context_line":"        if not fixed_ips:"},{"line_number":344,"context_line":"            return []"},{"line_number":345,"context_line":"        search_opts \u003d {\u0027id\u0027: [ip[\u0027subnet_id\u0027] for ip in fixed_ips]}"},{"line_number":346,"context_line":"        data \u003d quantumv2.get_client(context).list_subnets(**search_opts)"},{"line_number":347,"context_line":"        ipam_subnets \u003d data.get(\u0027subnets\u0027, [])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FaUU%3D","line":344,"updated":"2012-09-13 02:35:32.000000000","message":"This seems reasonable as a temporary work around but shouldn\u0027t we update quantumclient so that it handles the empty id\u003d[] correctly too?","commit_id":"cd6bb55a26144e19e2688600279f98a32b7f57d9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0da9202375aa9261d5b5c49f88c3ea1ffae72146","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # current tenant, returned subnets may contain subnets which is not"},{"line_number":342,"context_line":"        # related to the port. To avoid this, the method returns here."},{"line_number":343,"context_line":"        if not fixed_ips:"},{"line_number":344,"context_line":"            return []"},{"line_number":345,"context_line":"        search_opts \u003d {\u0027id\u0027: [ip[\u0027subnet_id\u0027] for ip in fixed_ips]}"},{"line_number":346,"context_line":"        data \u003d quantumv2.get_client(context).list_subnets(**search_opts)"},{"line_number":347,"context_line":"        ipam_subnets \u003d data.get(\u0027subnets\u0027, [])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FaDc%3D","line":344,"in_reply_to":"AAAALH%2F%2FaUU%3D","updated":"2012-09-13 13:37:40.000000000","message":"I am not sure quantumclient list_subnets() with empty id filter should return an empty list or a list of all subnets. Returning an empty list when id\u003d[] return an empty list can make a caller\u0027s logic simple. On the other hand, if list_*() with id\u003d[] return an empty list, the api call itself has no meaning and it  is just an overhead.","commit_id":"cd6bb55a26144e19e2688600279f98a32b7f57d9"}]}