)]}'
{"id":"openstack%2Fnova~1225","triplet_id":"openstack%2Fnova~master~Ic014c32786cb10c541f7d367573adb7a069c1a88","project":"openstack/nova","branch":"master","topic":"test-suite-speedups-1","hashtags":[],"change_id":"Ic014c32786cb10c541f7d367573adb7a069c1a88","subject":"Speed up tests a further 35 seconds","status":"MERGED","created":"2011-11-01 14:57:23.000000000","updated":"2011-11-08 22:20:41.000000000","submitted":"2011-11-08 22:20:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b679b4612df092494652dea950d2827f6ce58225","_number":1225,"virtual_id_number":1225,"owner":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"value":0,"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2011-11-08 22:20:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"all":[{"value":2,"date":"2011-11-08 22:13:20.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"value":0,"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},{"value":0,"date":"2011-11-04 18:19:54.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":1,"date":"2011-11-05 20:00:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2011-11-08 22:20:40.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"value":0,"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"value":0,"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"value":0,"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-11-02 13:58:35.000000000","updated_by":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"reviewer":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"state":"REVIEWER"},{"updated":"2011-11-04 03:38:14.000000000","updated_by":{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},"reviewer":{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},"state":"REVIEWER"},{"updated":"2011-11-05 20:00:09.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2011-11-08 22:13:20.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2011-11-08 22:20:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7bd2a82f2df70e98fcf9a70328a4220b58a1e7eb","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-11-01 21:20:40.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nAwesome work, Johannes. We should probably move those extension-specific test modules into contrib in a future patch.","accounts_in_message":[],"_revision_number":1},{"id":"5dac2a37597a05bf36eac264b24f32839ec11ea4","author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"date":"2011-11-02 13:58:35.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nPre-patch:\n\nRan 752 tests in 77.054s\nSlowest 5 tests took 4.42 secs:\n\nPost-patch:\n\nRan 748 tests in 58.844s\nSlowest 5 tests took 3.92 secs:\n\nReally appreciated :)","accounts_in_message":[],"_revision_number":1},{"id":"ab7e1fd7a154737f53539d7803104961ceeb5eff","author":{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},"date":"2011-11-04 03:38:14.000000000","message":"Patch Set 1: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"56381dc86daf4c787f3128046588822e4cbc78b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-04 03:38:18.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova/121797/ (1/3)","accounts_in_message":[],"_revision_number":1},{"id":"a2be91b0b7709ab3b02845e3a59047dc01316c0b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-04 03:41:29.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova-merge/283/ (2/3)","accounts_in_message":[],"_revision_number":1},{"id":"67aef19bda2c253a9786b49a84c4c235d0d3532a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-04 03:42:10.000000000","message":"Patch Set 1:\n\nBuild Started https://jenkins.openstack.org/job/nova-pep8/1656/ (3/3)","accounts_in_message":[],"_revision_number":1},{"id":"13f7bf8f58490b7052c6e83e2b68acead5e27a6e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-04 03:42:52.000000000","message":"Patch Set 1: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/nova/121797/ : FAILURE \nhttps://jenkins.openstack.org/job/nova-merge/283/ : This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. \nhttps://jenkins.openstack.org/job/nova-pep8/1656/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"b4ad5213ba65daac9b37d00975931c5564cd77a6","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2011-11-04 18:19:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7e019d2ef71f43f8ace5385a03bef996953d960c","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-11-05 20:00:09.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nLooks good.\n\nOne question: I notice that all of the prior tests were testing for status codes and content types.  Are we testing the status code generation and the content types separately somewhere?","accounts_in_message":[],"_revision_number":2},{"id":"3834abde079d217b79789be07acfdbfef0d62189","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2011-11-05 23:42:04.000000000","message":"Patch Set 2:\n\nSince we talk directly to the controller now, it only returns an object. If there is an error, an exception is raised with the appropriate HTTP status code.\n\nThe tests check for either success (and then checks the object) or it checks an appropriate exception is raised.\n\nSeparately the XML serialization is tested for given inputs and outputs.\n\nSo, Content-Type isn\u0027t checked anymore because only objects are returned, and status codes are checked by way of checking the appropriate exception is raised.","accounts_in_message":[],"_revision_number":2},{"id":"f2c2b739c7cb21220c4509b82ab9c20a15c6e4d3","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-11-06 00:10:22.000000000","message":"Patch Set 2:\n\nNice.  Thanks for the explanation.","accounts_in_message":[],"_revision_number":2},{"id":"7dc44f122fd32d2ad88401b60f65bf1ef96bf05a","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-11-08 22:13:20.000000000","message":"Patch Set 2: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"fe32bd547cf5fb2cff1f84ef97a156f286962167","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-08 22:20:40.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/nova/121824/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova-merge/310/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova-pep8/1683/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a7caa5e9942e8582996498ae57c985bd6b292465","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-08 22:20:41.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0d36d2bf9eba28123c172fd24780f0ebe95db10a","revisions":{"0932734468c84a006a36815f8dd53abb31797263":{"kind":"REWORK","_number":1,"created":"2011-11-01 14:57:23.000000000","uploader":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"ref":"refs/changes/25/1225/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/25/1225/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/25/1225/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/25/1225/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/25/1225/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/25/1225/1"}}},"commit":{"parents":[{"commit":"d4b0c0615f3c5d83d425619ceb400793524e5949","subject":"Merge \"Fix lp:861160 -- newly created network has no uuid\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d4b0c0615f3c5d83d425619ceb400793524e5949"}]}],"author":{"name":"Johannes Erdfelt","email":"johannes.erdfelt@rackspace.com","date":"2011-11-01 14:47:51.000000000","tz":0},"committer":{"name":"Johannes Erdfelt","email":"johannes.erdfelt@rackspace.com","date":"2011-11-01 14:57:01.000000000","tz":0},"subject":"Speed up tests a further 35 seconds","message":"Speed up tests a further 35 seconds\n\nThis changes more OSAPI tests to using their Controller directly, bypassing\nthe slow wsgi setup process.\n\nChange-Id: Ic014c32786cb10c541f7d367573adb7a069c1a88\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0932734468c84a006a36815f8dd53abb31797263"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0932734468c84a006a36815f8dd53abb31797263"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d4b0c0615f3c5d83d425619ceb400793524e5949","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"0d36d2bf9eba28123c172fd24780f0ebe95db10a":{"kind":"REWORK","_number":2,"created":"2011-11-04 18:19:54.000000000","uploader":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"ref":"refs/changes/25/1225/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/25/1225/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/25/1225/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/25/1225/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/25/1225/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/25/1225/2"}}},"commit":{"parents":[{"commit":"67a1c257f9e4be774da5acf2c1b703d196e0a2cf","subject":"Merge \"Set nova-manage to executable Fixes LP885778\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/67a1c257f9e4be774da5acf2c1b703d196e0a2cf"}]}],"author":{"name":"Johannes Erdfelt","email":"johannes.erdfelt@rackspace.com","date":"2011-11-01 14:47:51.000000000","tz":0},"committer":{"name":"Johannes Erdfelt","email":"johannes.erdfelt@rackspace.com","date":"2011-11-04 18:19:19.000000000","tz":0},"subject":"Speed up tests a further 35 seconds","message":"Speed up tests a further 35 seconds\n\nThis changes more OSAPI tests to using their Controller directly, bypassing\nthe slow wsgi setup process.\n\nChange-Id: Ic014c32786cb10c541f7d367573adb7a069c1a88\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0d36d2bf9eba28123c172fd24780f0ebe95db10a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0d36d2bf9eba28123c172fd24780f0ebe95db10a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"67a1c257f9e4be774da5acf2c1b703d196e0a2cf","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
