)]}'
{"nova/volume/driver.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"128df832024c0e7a0222a79cea530b721513b159","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def _copy_volume(self, srcstr, deststr, size_in_g):"},{"line_number":114,"context_line":"        # Use O_DIRECT to avoid thrashing the system buffer cache"},{"line_number":115,"context_line":"        direct_flags \u003d (\u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # Check whether O_DIRECT is supported"},{"line_number":118,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Ffh0%3D","line":115,"updated":"2012-09-06 14:22:34.000000000","message":"Why not cache the computed direct_flags as an instance variable, so that the additional dd command to check for O_DIRECT support is only run once?\n\n(i.e. the status of O_DIRECT support is not going to have changed after the first check, or?)","commit_id":"bd66a657b4230a6cbba46c3e5acfeecd6c4b2dd1"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"44b1ac2e12a458b7fb8a667424355abbe0a3abd3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self._execute(\u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,"},{"line_number":120,"context_line":"                          *direct_flags, run_as_root\u003dTrue)"},{"line_number":121,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":122,"context_line":"            direct_flags \u003d ()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Perform the copy"},{"line_number":125,"context_line":"        self._execute(\u0027dd\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Ffsw%3D","line":122,"updated":"2012-09-06 05:58:33.000000000","message":"Do you think its worth logging something at info level here to let people know?","commit_id":"bd66a657b4230a6cbba46c3e5acfeecd6c4b2dd1"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"cd9efeda961fb8aaeedcc5fd899bddccad1856d8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self._execute(\u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,"},{"line_number":120,"context_line":"                          *direct_flags, run_as_root\u003dTrue)"},{"line_number":121,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":122,"context_line":"            direct_flags \u003d ()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Perform the copy"},{"line_number":125,"context_line":"        self._execute(\u0027dd\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Ffms%3D","line":122,"in_reply_to":"AAAALH%2F%2Ffm8%3D","updated":"2012-09-06 10:24:07.000000000","message":"Actually another reason I didn\u0027t add a log there is because the failure might not be related to O_DIRECT and so it\u0027s awkward to give a definitive info message.","commit_id":"bd66a657b4230a6cbba46c3e5acfeecd6c4b2dd1"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"bffffc87e6cf5548be1ede052b993ace06089fa2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self._execute(\u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,"},{"line_number":120,"context_line":"                          *direct_flags, run_as_root\u003dTrue)"},{"line_number":121,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":122,"context_line":"            direct_flags \u003d ()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Perform the copy"},{"line_number":125,"context_line":"        self._execute(\u0027dd\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Ffm8%3D","line":122,"in_reply_to":"AAAALH%2F%2Ffn4%3D","updated":"2012-09-06 09:44:47.000000000","message":"In that case, I vote for adding a log message. I might help ops types debug a performance problem. Either way, I\u0027m +2 on this.","commit_id":"bd66a657b4230a6cbba46c3e5acfeecd6c4b2dd1"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"068786f2af456ce6db304df54b1fdc361b7655ad","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self._execute(\u0027dd\u0027, \u0027count\u003d0\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,"},{"line_number":120,"context_line":"                          *direct_flags, run_as_root\u003dTrue)"},{"line_number":121,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":122,"context_line":"            direct_flags \u003d ()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Perform the copy"},{"line_number":125,"context_line":"        self._execute(\u0027dd\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Ffn4%3D","line":122,"in_reply_to":"AAAALH%2F%2Ffsw%3D","updated":"2012-09-06 08:03:58.000000000","message":"I did consider, but given that this is only a performance decision,\nI erred on the side of not polluting the logs.\nI was 40:60 for adding a LOG.info().\nIf you\u0027re more than 60:40 (or if others prefer) I will add.\n\nthanks for the careful review.","commit_id":"bd66a657b4230a6cbba46c3e5acfeecd6c4b2dd1"}]}