)]}'
{"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"change_message_id":"52cce0ca632ac0d0580e1b8fd1f5dbd44fdd66b2","unresolved":false,"context_lines":[{"line_number":1469,"context_line":"            else:"},{"line_number":1470,"context_line":"                expected \u003d 1"},{"line_number":1471,"context_line":"            self.assertEqual(expected, mock_destroy.call_count)"},{"line_number":1472,"context_line":"            self.assertFalse(mock_call.called)"},{"line_number":1473,"context_line":""},{"line_number":1474,"context_line":"    def test_destroy_instance_without_vm_ref(self):"},{"line_number":1475,"context_line":"        self._destroy_instance_without_vm_ref()"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_badb4e7c","line":1472,"updated":"2014-10-09 15:19:55.000000000","message":"It seems that _call_method() should always be called, when the VM is unregistered _destroy_instance(). How can this be true?","commit_id":"d71445c7d2d2921d10a08f82330f0ab8ef4f7df2"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"5a00f256548b8a6fb6be2c4400a7fddf19e7a1be","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"                                       instance_name\u003dresize_orig_vmname)"},{"line_number":1147,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1148,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1149,"context_line":"        LOG.debug(\"Instance destroyed\", instance\u003dinstance)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def pause(self, instance):"},{"line_number":1152,"context_line":"        msg \u003d _(\"pause not supported for vmwareapi\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_77eae974","line":1149,"updated":"2014-10-09 09:22:07.000000000","message":"Sounds like a gratuitous change ?","commit_id":"14c07cb662b86b55fba86244cff2f94f15d47161"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"66abdd1bd9382d430e4b5884f0e9b4464ef1f462","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"                                       instance_name\u003dresize_orig_vmname)"},{"line_number":1147,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1148,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1149,"context_line":"        LOG.debug(\"Instance destroyed\", instance\u003dinstance)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def pause(self, instance):"},{"line_number":1152,"context_line":"        msg \u003d _(\"pause not supported for vmwareapi\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_5656c407","line":1149,"in_reply_to":"baa201ad_77eae974","updated":"2014-10-09 11:53:20.000000000","message":"I used gerrit to do the cherry pick, not sure why it includes this change.","commit_id":"14c07cb662b86b55fba86244cff2f94f15d47161"},{"author":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"change_message_id":"52cce0ca632ac0d0580e1b8fd1f5dbd44fdd66b2","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"                                       destroy_disks\u003ddestroy_disks,"},{"line_number":1146,"context_line":"                                       instance_name\u003dresize_orig_vmname)"},{"line_number":1147,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1148,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1149,"context_line":"        LOG.debug(_(\"Instance destroyed\"), instance\u003dinstance)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def pause(self, instance):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_b7cfe756","line":1148,"updated":"2014-10-09 15:19:55.000000000","message":"I could be missing something here, but in the situation you describe won\u0027t you end up calling _destroy_instance() twice for the same instance? Once in the above \"if\" clause, if vm_orig_ref is not None, and once in the main body?\n\nIn vmops it looks like _destroy_instance() will fail if get_vm_ref_from_name() fails, which presumably it will since the instance has been renamed. So it won\u0027t actually attempt to delete the instance a second time but it will log a spurious warning, which seems suboptimal.","commit_id":"d71445c7d2d2921d10a08f82330f0ab8ef4f7df2"},{"author":{"_account_id":7746,"name":"Dan Genin","email":"daniel.genin@jhuapl.edu","username":"DiG"},"change_message_id":"5e512289ff8138e2a4af70a31ac7cf3cd8d0c329","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"                                       destroy_disks\u003ddestroy_disks,"},{"line_number":1146,"context_line":"                                       instance_name\u003dresize_orig_vmname)"},{"line_number":1147,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1148,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1149,"context_line":"        LOG.debug(_(\"Instance destroyed\"), instance\u003dinstance)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def pause(self, instance):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_5a121b63","line":1148,"in_reply_to":"baa201ad_9a6c8338","updated":"2014-10-13 14:59:49.000000000","message":"Ah, I see. Thank you, garyk.","commit_id":"d71445c7d2d2921d10a08f82330f0ab8ef4f7df2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7e8e6a5bf4c9fe69bad19e3a613367c81455cc1c","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"                                       destroy_disks\u003ddestroy_disks,"},{"line_number":1146,"context_line":"                                       instance_name\u003dresize_orig_vmname)"},{"line_number":1147,"context_line":"        self._destroy_instance(instance, network_info,"},{"line_number":1148,"context_line":"                               destroy_disks\u003ddestroy_disks)"},{"line_number":1149,"context_line":"        LOG.debug(_(\"Instance destroyed\"), instance\u003dinstance)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def pause(self, instance):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_9a6c8338","line":1148,"in_reply_to":"baa201ad_b7cfe756","updated":"2014-10-13 14:49:59.000000000","message":"Dan the problem is as follows:\nWhen a resize is done a new VM is created on the back end. So prior to the resize you would have a instance called uuid. When a resize taskes place there will be a cloned VM called uuid-orig. Hence the additional delete that needs to take place.","commit_id":"d71445c7d2d2921d10a08f82330f0ab8ef4f7df2"}]}