)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13413,"name":"Jan Kundrát","email":"jkt@kde.org","username":"jkt"},"change_message_id":"6f29add1c31f817551ec895cab7c7f8ad9458a11","unresolved":false,"context_lines":[{"line_number":12,"context_line":"could inadvertently expose these passwords to a user with read access to"},{"line_number":13,"context_line":"the log files. It is therefore considered prudent to invoke"},{"line_number":14,"context_line":"strutils.mask_password() on the command, stdout and stderr in the"},{"line_number":15,"context_line":"exception. A test case has been added to ensure that all three are"},{"line_number":16,"context_line":"properly masked."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"An earlier commit (853d8f9897f8563851441108a9be26b10908c076) failed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_b67f4c65","line":15,"range":{"start_line":15,"start_character":11,"end_line":15,"end_character":37},"updated":"2014-10-06 14:29:34.000000000","message":"If this gets changed to e.g. \"A test case has been added to project foobar in commit ...\", then I think there would be no confusion.","commit_id":"b149185addd6209503332e9750118abfe9b88f79"}],"nova/openstack/common/processutils.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"975dec283e9c082840a2db4346b6ac4a38ffbb64","unresolved":false,"context_lines":[{"line_number":246,"context_line":"def ssh_execute(ssh, cmd, process_input\u003dNone,"},{"line_number":247,"context_line":"                addl_env\u003dNone, check_exit_code\u003dTrue):"},{"line_number":248,"context_line":"    sanitized_cmd \u003d strutils.mask_password(cmd)"},{"line_number":249,"context_line":"    LOG.debug(\u0027Running cmd (SSH): %s\u0027, sanitized_cmd)"},{"line_number":250,"context_line":"    if addl_env:"},{"line_number":251,"context_line":"        raise InvalidArgumentError(_(\u0027Environment not supported over SSH\u0027))"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_c3a17195","line":249,"updated":"2014-10-06 15:41:15.000000000","message":"For this line to be fixing a security problem with the logs, implies that something in Nova is passing a password in cleartext in the SSH command line arguments.  If anything is doing that, it is a serious security bug because the command line arguments are visible to any local user in \"ps\" and we need to fix that. If nothing is passing passwords on the command line then this changed code can go away.","commit_id":"8e7d6a60ff92df19aceb0972566b48992eee18b4"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"975dec283e9c082840a2db4346b6ac4a38ffbb64","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    stdout \u003d stdout_stream.read()"},{"line_number":263,"context_line":"    sanitized_stdout \u003d strutils.mask_password(stdout)"},{"line_number":264,"context_line":"    stderr \u003d stderr_stream.read()"},{"line_number":265,"context_line":"    sanitized_stderr \u003d strutils.mask_password(stderr)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    stdin_stream.close()"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_63ae0583","line":265,"updated":"2014-10-06 15:41:15.000000000","message":"This is fine though, as command output is safe from other prying eyes.","commit_id":"8e7d6a60ff92df19aceb0972566b48992eee18b4"}]}