)]}'
{"nova/network/manager.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"fe31439db267d4032abd17a3eceed637c2644053","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"                    \"vlan_start\", \"vpn_start\")"},{"line_number":1372,"context_line":"        for key in int_args:"},{"line_number":1373,"context_line":"            try:"},{"line_number":1374,"context_line":"                kwargs[key] \u003d int(kwargs[key])"},{"line_number":1375,"context_line":"            except ValueError:"},{"line_number":1376,"context_line":"                raise ValueError(_(\"%s must be an integer\") % key)"},{"line_number":1377,"context_line":"        #if value is None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fdnw%3D","line":1374,"updated":"2012-09-09 04:39:37.000000000","message":"I think I\u0027d prefer that you checked for the existence of the key here instead of catching an exception below. Is there a reason you can\u0027t do that?","commit_id":"116736a364c05d011e6fd8349fa8280e482df197"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"58ffc58c15f87c38613bd7a0739d05c0d93d3cb8","unresolved":false,"context_lines":[{"line_number":1373,"context_line":"            try:"},{"line_number":1374,"context_line":"                value \u003d kwargs[key]"},{"line_number":1375,"context_line":"                if value is None:"},{"line_number":1376,"context_line":"                    pass"},{"line_number":1377,"context_line":"                kwargs[key] \u003d int(value)"},{"line_number":1378,"context_line":"            except ValueError:"},{"line_number":1379,"context_line":"                raise ValueError(_(\"%s must be an integer\") % key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FciA%3D","line":1376,"updated":"2012-09-11 00:26:02.000000000","message":"my fault sorry. That pass is a noop, you probably want a continue here.\nAlso you can drop the KeyError since you don\u0027t want to distinguish missing and None, like:\n\n    value \u003d kwargs.get(key)\n    if value is None:\n        continue","commit_id":"e6be120ab5483eb5123197760f97b0d2334e8549"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"359dddaa742a8d398eb4eeee1c0c1e7b4d30dd6f","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"                    \"vlan_start\", \"vpn_start\")"},{"line_number":1372,"context_line":"        for key in int_args:"},{"line_number":1373,"context_line":"            try:"},{"line_number":1374,"context_line":"                value \u003d kwargs[key]"},{"line_number":1375,"context_line":"                if value is None:"},{"line_number":1376,"context_line":"                    continue"},{"line_number":1377,"context_line":"                kwargs[key] \u003d int(value)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fchc%3D","line":1374,"updated":"2012-09-11 00:40:34.000000000","message":"sorry for the churn. That needs to be:\n\n    value \u003d kwargs.get(key)\n\nOtherwise you get the keyerror","commit_id":"9f06d7b2ad5599797bc41a99dad563f288237f93"}]}