)]}'
{"nova/objects/network_request.py":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"d6b29ee37f3b18f20954c91a3365294e4d31ea0b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        elif len(net_tuple) \u003d\u003d 3:"},{"line_number":48,"context_line":"            network_id, address, port_id \u003d net_tuple"},{"line_number":49,"context_line":"            return cls(network_id\u003dnetwork_id, address\u003daddress,"},{"line_number":50,"context_line":"                       port_id\u003dport_id, pci_request_id\u003dNone)"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            network_id, address \u003d net_tuple"},{"line_number":53,"context_line":"            return cls(network_id\u003dnetwork_id, address\u003daddress)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_482d9894","line":50,"updated":"2014-10-07 18:01:06.000000000","message":"nit: pci_request_id\u003dNone is not necessary.\n\nQuestion, why is this change needed?","commit_id":"2c304ddf133b62d2d79bff938eb33aaed6005018"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b4aaa3f916cc72539907f3533614b3d19213ac07","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        elif len(net_tuple) \u003d\u003d 3:"},{"line_number":48,"context_line":"            network_id, address, port_id \u003d net_tuple"},{"line_number":49,"context_line":"            return cls(network_id\u003dnetwork_id, address\u003daddress,"},{"line_number":50,"context_line":"                       port_id\u003dport_id, pci_request_id\u003dNone)"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            network_id, address \u003d net_tuple"},{"line_number":53,"context_line":"            return cls(network_id\u003dnetwork_id, address\u003daddress)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_59e465ab","line":50,"in_reply_to":"baa201ad_482d9894","updated":"2014-10-08 02:39:00.000000000","message":"good catch, pci_request_id is not necessary, I just copy the code from previous line and change it to None :)","commit_id":"2c304ddf133b62d2d79bff938eb33aaed6005018"}],"nova/tests/compute/test_rpcapi.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10ce988a0f5fe7f856a5cdfffbc73aeff66b5e3b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                rpc_mock.return_value \u003d None"},{"line_number":101,"context_line":"            csv_mock.side_effect \u003d ("},{"line_number":102,"context_line":"                lambda v: orig_prepare(version\u003dv).can_send_version())"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            retval \u003d getattr(rpcapi, method)(ctxt, **kwargs)"},{"line_number":105,"context_line":"            self.assertEqual(retval, rpc_mock.return_value)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_334eb297","side":"PARENT","line":103,"updated":"2014-10-09 11:58:25.000000000","message":"nit: not necessary","commit_id":"41464d84957b358b2a676c1e261194656496d2cf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10ce988a0f5fe7f856a5cdfffbc73aeff66b5e3b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if \u0027expected_requested_networks\u0027 in expected_kwargs:"},{"line_number":67,"context_line":"            expected_kwargs[\u0027requested_networks\u0027] \u003d expected_kwargs.pop("},{"line_number":68,"context_line":"                \u0027expected_requested_networks\u0027)"},{"line_number":69,"context_line":"            kwargs.pop(\u0027expected_requested_networks\u0027)"},{"line_number":70,"context_line":"        if \u0027host_param\u0027 in expected_kwargs:"},{"line_number":71,"context_line":"            expected_kwargs[\u0027host\u0027] \u003d expected_kwargs.pop(\u0027host_param\u0027)"},{"line_number":72,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_16fefc05","line":69,"updated":"2014-10-09 11:58:25.000000000","message":"mmm, I don\u0027t like adding a kwarg which could override another kwarg, I would prefer something more specific :\n\nif \u0027requested_networks\u0027 in kwargs and len(kwargs[\u0027requested_networks\u0027] \u003d\u003d 4 and CONF.upgrade_levels.compute \u003d\u003d \u0027icehouse\u0027:\n  expected_kwargs[\u0027requested_networks\u0027] \u003d (a, b, c) for (a, b, c, d) in kwargs[\u0027requested_networks\u0027]","commit_id":"3a6abdd0807dcaeb089ae407daac086faa29665b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6c4a6b0813796268ce94455d89800e791e6ed345","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":464,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":465,"context_line":"                block_device_mapping\u003dNone, node\u003d\u0027node\u0027, limits\u003d[],"},{"line_number":466,"context_line":"                version\u003d\u00273.33\u0027)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    @mock.patch(\u0027nova.utils.is_neutron\u0027, return_value\u003dTrue)"},{"line_number":469,"context_line":"    def test_build_and_run_instance_icehouse_compat(self, is_neutron):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_3086a866","line":466,"updated":"2014-10-09 10:30:04.000000000","message":"tempting to add the expected_requested_networks here too?","commit_id":"3a6abdd0807dcaeb089ae407daac086faa29665b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b110e060cff2c2ad74ed8957de0baa711d8998b3","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                admin_password\u003d\u0027passwd\u0027, injected_files\u003dNone,"},{"line_number":464,"context_line":"                requested_networks\u003d[\u0027network1\u0027], security_groups\u003dNone,"},{"line_number":465,"context_line":"                block_device_mapping\u003dNone, node\u003d\u0027node\u0027, limits\u003d[],"},{"line_number":466,"context_line":"                version\u003d\u00273.33\u0027)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    @mock.patch(\u0027nova.utils.is_neutron\u0027, return_value\u003dTrue)"},{"line_number":469,"context_line":"    def test_build_and_run_instance_icehouse_compat(self, is_neutron):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_73ce7ab6","line":466,"in_reply_to":"baa201ad_3086a866","updated":"2014-10-09 11:11:56.000000000","message":"opps, yeah, thats non-sense. sorry.","commit_id":"3a6abdd0807dcaeb089ae407daac086faa29665b"}]}