)]}'
{"nova/virt/disk/mount.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"0f713aea72b360f93ceb0e9bcf284b116e3aecbf","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        if not self.mapped:"},{"line_number":117,"context_line":"            return"},{"line_number":118,"context_line":"        if self.automapped:"},{"line_number":119,"context_line":"            return"},{"line_number":120,"context_line":"        if self.partition:"},{"line_number":121,"context_line":"            utils.execute(\u0027kpartx\u0027, \u0027-d\u0027, self.device, run_as_root\u003dTrue)"},{"line_number":122,"context_line":"        self.mapped \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdyY%3D","line":119,"updated":"2012-09-08 17:50:59.000000000","message":"not sure this is a huge issue, but you will leave this method with mapped\u003dTrue here","commit_id":"3c795480fb48591ddb16dc991083ee679f7d9558"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"0f713aea72b360f93ceb0e9bcf284b116e3aecbf","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            return"},{"line_number":118,"context_line":"        if self.automapped:"},{"line_number":119,"context_line":"            return"},{"line_number":120,"context_line":"        if self.partition:"},{"line_number":121,"context_line":"            utils.execute(\u0027kpartx\u0027, \u0027-d\u0027, self.device, run_as_root\u003dTrue)"},{"line_number":122,"context_line":"        self.mapped \u003d False"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdyU%3D","line":120,"updated":"2012-09-08 17:50:59.000000000","message":"maybe instead of a new boolean we could just turn automapped_path into a method and use\nif self.partition and self.mapped_device \u003d\u003d self._get_automapped_path()","commit_id":"3c795480fb48591ddb16dc991083ee679f7d9558"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"42aeb8f6ee7df39afa9d374ed66e3b835ab1257c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            # Note auto mapping can be enabled with the \u0027max_part\u0027 option"},{"line_number":106,"context_line":"            # to the nbd or loop kernel modules. Beware of possible races"},{"line_number":107,"context_line":"            # in the partition scanning for _loop_ devices though"},{"line_number":108,"context_line":"            # (details in bug 1024586), which are currently uncatered for.            "},{"line_number":109,"context_line":"            self.mapped_device \u003d automapped_path"},{"line_number":110,"context_line":"            self.mapped \u003d True"},{"line_number":111,"context_line":"            self.automapped \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fdxs%3D","line":108,"updated":"2012-09-08 18:33:52.000000000","message":"pep8 failure is probably this trailing whitespace","commit_id":"5622d91058b9b97b5de24feb1acc2bc247a1f8d7"},{"author":{"_account_id":5434,"name":"Clemens Perz","email":"cperz@gmx.net","username":"cperz"},"change_message_id":"6265fe4a95431530c166519ff4fc7749426960f7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            # Note auto mapping can be enabled with the \u0027max_part\u0027 option"},{"line_number":106,"context_line":"            # to the nbd or loop kernel modules. Beware of possible races"},{"line_number":107,"context_line":"            # in the partition scanning for _loop_ devices though"},{"line_number":108,"context_line":"            # (details in bug 1024586), which are currently uncatered for.            "},{"line_number":109,"context_line":"            self.mapped_device \u003d automapped_path"},{"line_number":110,"context_line":"            self.mapped \u003d True"},{"line_number":111,"context_line":"            self.automapped \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fdxc%3D","line":108,"in_reply_to":"AAAALH%2F%2Fdxs%3D","updated":"2012-09-08 19:34:25.000000000","message":"jep, think so too. Removed it for the amend.","commit_id":"5622d91058b9b97b5de24feb1acc2bc247a1f8d7"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"42aeb8f6ee7df39afa9d374ed66e3b835ab1257c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        if self.automapped:"},{"line_number":123,"context_line":"            return"},{"line_number":124,"context_line":"        if self.partition:"},{"line_number":125,"context_line":"            utils.execute(\u0027kpartx\u0027, \u0027-d\u0027, self.device, run_as_root\u003dTrue)"},{"line_number":126,"context_line":"        self.mapped \u003d False"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def mnt_dev(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fdxo%3D","line":125,"updated":"2012-09-08 18:33:52.000000000","message":"Vish makes a good point that you should probably change this to:\n\n    if self.partition and not self.automapped:\n        utils.execute(\u0027kpartx\u0027, \u0027-d\u0027, self.device, run_as_root\u003dTrue)\n    self.automapped \u003d False\n    self.mapped \u003d False","commit_id":"5622d91058b9b97b5de24feb1acc2bc247a1f8d7"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"b6dc22de707ceefcbfb4afd44fcc99d0967b2050","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        if self.automapped:"},{"line_number":123,"context_line":"            return"},{"line_number":124,"context_line":"        if self.partition:"},{"line_number":125,"context_line":"            utils.execute(\u0027kpartx\u0027, \u0027-d\u0027, self.device, run_as_root\u003dTrue)"},{"line_number":126,"context_line":"        self.mapped \u003d False"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def mnt_dev(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fdso%3D","line":125,"in_reply_to":"AAAALH%2F%2Fdu0%3D","updated":"2012-09-08 21:07:50.000000000","message":"Hmm, let\u0027s cross that bridge if we come to it. Cheers.","commit_id":"5622d91058b9b97b5de24feb1acc2bc247a1f8d7"},{"author":{"_account_id":5434,"name":"Clemens Perz","email":"cperz@gmx.net","username":"cperz"},"change_message_id":"6265fe4a95431530c166519ff4fc7749426960f7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        if self.automapped:"},{"line_number":123,"context_line":"            return"},{"line_number":124,"context_line":"        if self.partition:"},{"line_number":125,"context_line":"            utils.execute(\u0027kpartx\u0027, \u0027-d\u0027, self.device, run_as_root\u003dTrue)"},{"line_number":126,"context_line":"        self.mapped \u003d False"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def mnt_dev(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fdu0%3D","line":125,"in_reply_to":"AAAALH%2F%2Fdxo%3D","updated":"2012-09-08 19:34:25.000000000","message":"hehe, exactly what I just did :) Rather than turning automapped into a method, what about using an enumration for the mapping status? Would be open for more mechanisms in the future.","commit_id":"5622d91058b9b97b5de24feb1acc2bc247a1f8d7"}]}