)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/266_update_instances_project_id_index.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"64af1e49bdfb14899b5c9cf583234b08c28901a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_37cf41b2","line":1,"updated":"2014-11-20 02:34:03.000000000","message":"nit, if you are not employed by the foundation this isn\u0027t accurate. so this line doesn\u0027t need to be here at all.","commit_id":"a33e3ebb5e7775154917a8b8eb866cf03c91a4fa"}],"nova/db/sqlalchemy/migrate_repo/versions/274_update_instances_project_id_index.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"153743f2847bc5a81690014475d93bd6dcc86e18","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Rackspace Hosting"},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_457de2b0","line":2,"updated":"2015-02-02 19:10:24.000000000","message":"Femto nit: this line means nothing","commit_id":"8251299c2bad90cec8af71de0e914fc8201579b6"}],"nova/tests/unit/db/test_migrations.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"92636ee8143be7933f5b3f78990c2a019be2aa03","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        self.assertColumnNotExists(engine, \u0027shadow_compute_nodes\u0027, \u0027host\u0027)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def _check_269(self, engine, data):"},{"line_number":568,"context_line":"        self.assertIndexMembers(engine, \u0027instances\u0027,"},{"line_number":569,"context_line":"                                \u0027instances_project_id_deleted_idx\u0027,"},{"line_number":570,"context_line":"                                [\u0027project_id\u0027, \u0027deleted\u0027])"},{"line_number":571,"context_line":"        self.assertIndexNotExists(engine, \u0027instances\u0027, \u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_1b2547ae","line":568,"updated":"2014-12-15 19:01:50.000000000","message":"It would be nice to have data in this table across the index manipulation.","commit_id":"880d31c0098353e0a7e42d3db834d3ce4be8ad54"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"9f84181829b708565695eef1892538ced7c959a9","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        self.assertColumnNotExists(engine, \u0027shadow_compute_nodes\u0027, \u0027host\u0027)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def _check_269(self, engine, data):"},{"line_number":568,"context_line":"        self.assertIndexMembers(engine, \u0027instances\u0027,"},{"line_number":569,"context_line":"                                \u0027instances_project_id_deleted_idx\u0027,"},{"line_number":570,"context_line":"                                [\u0027project_id\u0027, \u0027deleted\u0027])"},{"line_number":571,"context_line":"        self.assertIndexNotExists(engine, \u0027instances\u0027, \u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_c6f3e69d","line":568,"in_reply_to":"3a961159_1b2547ae","updated":"2014-12-15 19:57:10.000000000","message":"What kind of failure are you concerned about?\n\nThe only benefit I can think of to adding data is testing if the underlying database engine has any bugs, but that seems out-of-scope for these tests.","commit_id":"880d31c0098353e0a7e42d3db834d3ce4be8ad54"}]}
