)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"92f7233e38c2743ec0d40a976eea900eee97465a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wrong exception return in fixed_ips v2 extention"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, fixed_ips api raise HTTPNotFound if pass an invalid ip"},{"line_number":10,"context_line":"address in url, I think this is not correct. It\u0027s better to return"},{"line_number":11,"context_line":"HTTPBadRequest to end user when api except a FixedIpInvalid exception."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_caca321a","line":9,"updated":"2014-10-08 08:25:39.000000000","message":"s/raise/raises/\n\ns/pass/passing/","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"7189f896a42dabc3473593539df65c098b9e9e16","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wrong exception return in fixed_ips v2 extention"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, fixed_ips api raise HTTPNotFound if pass an invalid ip"},{"line_number":10,"context_line":"address in url, I think this is not correct. It\u0027s better to return"},{"line_number":11,"context_line":"HTTPBadRequest to end user when api except a FixedIpInvalid exception."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_c585c35a","line":9,"in_reply_to":"baa201ad_caca321a","updated":"2014-10-08 08:43:17.000000000","message":"Done","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"92f7233e38c2743ec0d40a976eea900eee97465a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, fixed_ips api raise HTTPNotFound if pass an invalid ip"},{"line_number":10,"context_line":"address in url, I think this is not correct. It\u0027s better to return"},{"line_number":11,"context_line":"HTTPBadRequest to end user when api except a FixedIpInvalid exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fix it and also the test cases."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_6ad946f2","line":11,"updated":"2014-10-08 08:25:39.000000000","message":"s/api/the  api/\n\ns/except/excepts/","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"7189f896a42dabc3473593539df65c098b9e9e16","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, fixed_ips api raise HTTPNotFound if pass an invalid ip"},{"line_number":10,"context_line":"address in url, I think this is not correct. It\u0027s better to return"},{"line_number":11,"context_line":"HTTPBadRequest to end user when api except a FixedIpInvalid exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fix it and also the test cases."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_057c2b71","line":11,"in_reply_to":"baa201ad_6ad946f2","updated":"2014-10-08 08:43:17.000000000","message":"Done","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"92f7233e38c2743ec0d40a976eea900eee97465a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"address in url, I think this is not correct. It\u0027s better to return"},{"line_number":11,"context_line":"HTTPBadRequest to end user when api except a FixedIpInvalid exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fix it and also the test cases."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7b18b76745f9092456d511ad023a9ed3a24cca84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_aadfaed4","line":13,"updated":"2014-10-08 08:25:39.000000000","message":"s/fix/fixes/","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"7189f896a42dabc3473593539df65c098b9e9e16","unresolved":false,"context_lines":[{"line_number":10,"context_line":"address in url, I think this is not correct. It\u0027s better to return"},{"line_number":11,"context_line":"HTTPBadRequest to end user when api except a FixedIpInvalid exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fix it and also the test cases."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7b18b76745f9092456d511ad023a9ed3a24cca84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_05f34b0a","line":13,"in_reply_to":"baa201ad_aadfaed4","updated":"2014-10-08 08:43:17.000000000","message":"Done","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"}],"nova/api/openstack/compute/contrib/fixed_ips.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"312113dc40df60e13ded8e985fa1ae5ba88b8ce5","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":78,"context_line":"        except exception.FixedIpInvalid:"},{"line_number":79,"context_line":"            msg \u003d _(\"Fixed IP %s not valid\") % address"},{"line_number":80,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8a482acd","line":80,"updated":"2014-10-08 08:22:26.000000000","message":"Why don\u0027t you use the message of exception.FixedIpInvalid like line 38?\n\nThe message seems enough like:\n\n 757 class FixedIpInvalid(Invalid):\n 758     msg_fmt \u003d _(\"Fixed IP address %(address)s is invalid.\")","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"df064f70ce55f66a26cf593183eb2907b8f723ac","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":78,"context_line":"        except exception.FixedIpInvalid:"},{"line_number":79,"context_line":"            msg \u003d _(\"Fixed IP %s not valid\") % address"},{"line_number":80,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_2a381e3c","line":80,"updated":"2014-10-08 08:21:02.000000000","message":"how about just write like raise webob.exc.HTTPBadRequest(explanation\u003dex.format_message())","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"7189f896a42dabc3473593539df65c098b9e9e16","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":78,"context_line":"        except exception.FixedIpInvalid:"},{"line_number":79,"context_line":"            msg \u003d _(\"Fixed IP %s not valid\") % address"},{"line_number":80,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_e5056711","line":80,"in_reply_to":"baa201ad_4a70020b","updated":"2014-10-08 08:43:17.000000000","message":"Done","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1e939429be75604a34c628db1dba8a8084844a26","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":78,"context_line":"        except exception.FixedIpInvalid:"},{"line_number":79,"context_line":"            msg \u003d _(\"Fixed IP %s not valid\") % address"},{"line_number":80,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_4a70020b","line":80,"in_reply_to":"baa201ad_8a482acd","updated":"2014-10-08 08:23:27.000000000","message":"Oops, conflict:-)\n\nagree with Alex.","commit_id":"40f23755a07b3f14acda41765dd5a4c1fc6a132d"}]}