)]}'
{"nova/compute/api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3029aae59907f8d56fe6f6b0ff88b525e9b7b86b","unresolved":false,"context_lines":[{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"        instance \u003d self.update(context, instance,"},{"line_number":1946,"context_line":"                               task_state\u003dtask_states.MIGRATING,"},{"line_number":1947,"context_line":"                               expected_task_state\u003dNone)"},{"line_number":1948,"context_line":""},{"line_number":1949,"context_line":"        self.scheduler_rpcapi.live_migration(context, block_migration,"},{"line_number":1950,"context_line":"                disk_over_commit, instance, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FcAQ%3D","line":1947,"updated":"2012-09-11 14:43:05.000000000","message":"This should be in a separate change, I think. I don\u0027t think it is relevant to this bug, if I understand the diff correctly.","commit_id":"28235302ddc62cc1fc038fa01d314019f8e66261"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"290185cf4234030d7592cee114be61898b06a6c8","unresolved":false,"context_lines":[{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"        instance \u003d self.update(context, instance,"},{"line_number":1946,"context_line":"                               task_state\u003dtask_states.MIGRATING,"},{"line_number":1947,"context_line":"                               expected_task_state\u003dNone)"},{"line_number":1948,"context_line":""},{"line_number":1949,"context_line":"        self.scheduler_rpcapi.live_migration(context, block_migration,"},{"line_number":1950,"context_line":"                disk_over_commit, instance, host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fbcg%3D","line":1947,"in_reply_to":"AAAALH%2F%2FcAQ%3D","updated":"2012-09-12 04:06:09.000000000","message":"Yes, it should be.","commit_id":"28235302ddc62cc1fc038fa01d314019f8e66261"}],"nova/scheduler/driver.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"30937535324163f342f2a3f6a64ae3197752dea8","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        (old_ref, new_instance_ref) \u003d db.instance_update_and_get_original("},{"line_number":211,"context_line":"                context, instance[\u0027uuid\u0027], values)"},{"line_number":212,"context_line":"        notifications.send_update(context, old_ref, new_instance_ref,"},{"line_number":213,"context_line":"                service\u003d\"scheduler\")"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # Perform migration"},{"line_number":216,"context_line":"        src \u003d instance[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FbWU%3D","side":"PARENT","line":213,"updated":"2012-09-12 05:59:10.000000000","message":"I don\u0027t understand how removing this is related to this patch? Seems like we still want to sed task state?","commit_id":"511807ed248fbe63cb6642c1cff6e0bd4bb8ae5d"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"e024f7e0ba31b0d42412fea34b471224dcec5e7d","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        (old_ref, new_instance_ref) \u003d db.instance_update_and_get_original("},{"line_number":211,"context_line":"                context, instance[\u0027uuid\u0027], values)"},{"line_number":212,"context_line":"        notifications.send_update(context, old_ref, new_instance_ref,"},{"line_number":213,"context_line":"                service\u003d\"scheduler\")"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # Perform migration"},{"line_number":216,"context_line":"        src \u003d instance[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FbUA%3D","side":"PARENT","line":213,"in_reply_to":"AAAALH%2F%2FbWU%3D","updated":"2012-09-12 06:09:30.000000000","message":"This should be in a separate change.","commit_id":"511807ed248fbe63cb6642c1cff6e0bd4bb8ae5d"}],"nova/tests/api/openstack/compute/contrib/test_admin_actions.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3029aae59907f8d56fe6f6b0ff88b525e9b7b86b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        def fake_update(inst, context, instance, **kwargs):"},{"line_number":144,"context_line":"            self.kwargs \u003d kwargs"},{"line_number":145,"context_line":"        self.stubs.Set(compute.API, \u0027update\u0027, fake_update)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        res \u003d req.get_response(app)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FcA4%3D","line":144,"updated":"2012-09-11 14:43:05.000000000","message":"Should we not check the correct state updates have been requested?","commit_id":"28235302ddc62cc1fc038fa01d314019f8e66261"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"290185cf4234030d7592cee114be61898b06a6c8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        def fake_update(inst, context, instance, **kwargs):"},{"line_number":144,"context_line":"            self.kwargs \u003d kwargs"},{"line_number":145,"context_line":"        self.stubs.Set(compute.API, \u0027update\u0027, fake_update)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        res \u003d req.get_response(app)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fba8%3D","line":144,"in_reply_to":"AAAALH%2F%2FcA4%3D","updated":"2012-09-12 04:06:09.000000000","message":"Yes.\nSince this test is only related to live_migrate api change, I will remove these code and maybe file another bug/feature.","commit_id":"28235302ddc62cc1fc038fa01d314019f8e66261"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3029aae59907f8d56fe6f6b0ff88b525e9b7b86b","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"                       \u0027check_can_live_migrate_source\u0027,"},{"line_number":1771,"context_line":"                       fake_driver_check_can_live_migrate_source)"},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"        dest_check_data \u003d {\"test\": \"data\", \u0027disk_over_commit\u0027: False}"},{"line_number":1774,"context_line":"        self.compute.driver.check_can_live_migrate_source(context,"},{"line_number":1775,"context_line":"                                                          inst_ref,"},{"line_number":1776,"context_line":"                                                          dest_check_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FcAo%3D","line":1773,"updated":"2012-09-11 14:43:05.000000000","message":"I don\u0027t understand why this test had to change so much.\n\nIt seems almost equivalent, except it no longer tests that the correct values get passed into the driver.","commit_id":"28235302ddc62cc1fc038fa01d314019f8e66261"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"290185cf4234030d7592cee114be61898b06a6c8","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"                       \u0027check_can_live_migrate_source\u0027,"},{"line_number":1771,"context_line":"                       fake_driver_check_can_live_migrate_source)"},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"        dest_check_data \u003d {\"test\": \"data\", \u0027disk_over_commit\u0027: False}"},{"line_number":1774,"context_line":"        self.compute.driver.check_can_live_migrate_source(context,"},{"line_number":1775,"context_line":"                                                          inst_ref,"},{"line_number":1776,"context_line":"                                                          dest_check_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FbbE%3D","line":1773,"in_reply_to":"AAAALH%2F%2FcAo%3D","updated":"2012-09-12 04:06:09.000000000","message":"You are right.\nThese code was part of my first implement.\nI forgot to update here.","commit_id":"28235302ddc62cc1fc038fa01d314019f8e66261"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7db35a8a9f9f1a8e4c61374c0374f11e58b013ac","unresolved":false,"context_lines":[{"line_number":4455,"context_line":"        self.compute.run_instance(self.context, instance\u003dinstance)"},{"line_number":4456,"context_line":""},{"line_number":4457,"context_line":"        instance \u003d db.instance_get_by_uuid(self.context, instance_uuid)"},{"line_number":4458,"context_line":"        self.assertEqual(instance[\u0027task_state\u0027], None)"},{"line_number":4459,"context_line":""},{"line_number":4460,"context_line":"        block_migration \u003d True"},{"line_number":4461,"context_line":"        disk_over_commit \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FbPQ%3D","line":4458,"updated":"2012-09-12 09:19:24.000000000","message":"This is left over from your other change. Should you not be asserting something at the end of the test here? Like make sure the driver gets called with the correct params, or something like that?","commit_id":"49ecb9ed2860e94d4a0469b764d8798853807751"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05cbcd66528a77fc5de4ca13abdc879a8f6dc135","unresolved":false,"context_lines":[{"line_number":4456,"context_line":"        self.compute_api.live_migrate(self.context, instance,"},{"line_number":4457,"context_line":"                                      block_migration\u003dTrue,"},{"line_number":4458,"context_line":"                                      disk_over_commit\u003dFalse,"},{"line_number":4459,"context_line":"                                      host\u003d\u0027fake_dest_host\u0027)"},{"line_number":4460,"context_line":""},{"line_number":4461,"context_line":"        db.instance_destroy(self.context, instance[\u0027uuid\u0027])"},{"line_number":4462,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FbOU%3D","line":4459,"updated":"2012-09-12 10:14:12.000000000","message":"I still think this test should use mox or similar to check the correct arguments are passed to the RPC layer. Or simply remove this diff and add the test as part of your other change.","commit_id":"1cb62ee5da68b1c656eb1bf4ceae2c2ce65221a4"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7db35a8a9f9f1a8e4c61374c0374f11e58b013ac","unresolved":false,"context_lines":[{"line_number":2219,"context_line":"        \"\"\""},{"line_number":2220,"context_line":"        disk_available_mb \u003d None"},{"line_number":2221,"context_line":"        if block_migration:"},{"line_number":2222,"context_line":"            disk_available_gb \u003d self._get_compute_info(ctxt,"},{"line_number":2223,"context_line":"                                    FLAGS.host)[\u0027disk_available_least\u0027]"},{"line_number":2224,"context_line":"            disk_available_mb \u003d \\"},{"line_number":2225,"context_line":"                    (disk_available_gb * 1024) - FLAGS.reserved_host_disk_mb"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FbPc%3D","line":2222,"updated":"2012-09-12 09:19:24.000000000","message":"Something tells me it would be good to pull this into its own method and lock it down with unit tests, but that might be excessive.","commit_id":"49ecb9ed2860e94d4a0469b764d8798853807751"}]}