)]}'
{"nova/compute/api.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"d4dfc490c80cb02b87df5655ad0556c6ae5d5230","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"        image \u003d self.image_service.show(context, instance[\u0027image_ref\u0027])"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"        current_memory_mb \u003d current_instance_type[\u0027memory_mb\u0027]"},{"line_number":1584,"context_line":"        new_memory_mb \u003d new_instance_type[\u0027memory_mb\u0027]"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        if same_instance_type and flavor_id:"},{"line_number":1587,"context_line":"            raise exception.CannotResizeToSameSize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fb0I%3D","line":1584,"updated":"2012-09-11 17:51:17.000000000","message":"These two variables don\u0027t appear to be used anymore after your change. They should probably be removed too","commit_id":"b7b052e130e293df7ff24206efa334776553c253"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"d4dfc490c80cb02b87df5655ad0556c6ae5d5230","unresolved":false,"context_lines":[{"line_number":1584,"context_line":"        new_memory_mb \u003d new_instance_type[\u0027memory_mb\u0027]"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        if same_instance_type and flavor_id:"},{"line_number":1587,"context_line":"            raise exception.CannotResizeToSameSize()"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"        # ensure there is sufficient headroom for upsizes"},{"line_number":1590,"context_line":"        deltas \u003d self._upsize_quota_delta(context, new_instance_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fbz8%3D","line":1587,"updated":"2012-09-11 17:51:17.000000000","message":"This exception should probably change then too. The error is that the flavor doesn\u0027t change now, not that the size doesn\u0027t change.","commit_id":"b7b052e130e293df7ff24206efa334776553c253"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"07983d02f7fe1ce41a63c7906671757f2f73e1dd","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"        image \u003d self.image_service.show(context, instance[\u0027image_ref\u0027])"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"        current_memory_mb \u003d current_instance_type[\u0027memory_mb\u0027]"},{"line_number":1584,"context_line":"        new_memory_mb \u003d new_instance_type[\u0027memory_mb\u0027]"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        if same_instance_type and flavor_id:"},{"line_number":1587,"context_line":"            raise exception.CannotResizeToSameFlavor()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FbFA%3D","line":1584,"updated":"2012-09-12 15:03:54.000000000","message":"These two variables are still unused. They should be removed","commit_id":"da404fb9a58e99c328c04640834f1c91bf816743"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"1f79a5804b03be55a2ba2e9585e2d18252ea3c02","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"        image \u003d self.image_service.show(context, instance[\u0027image_ref\u0027])"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"        current_memory_mb \u003d current_instance_type[\u0027memory_mb\u0027]"},{"line_number":1584,"context_line":"        new_memory_mb \u003d new_instance_type[\u0027memory_mb\u0027]"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        if same_instance_type and flavor_id:"},{"line_number":1587,"context_line":"            raise exception.CannotResizeToSameFlavor()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FbDo%3D","line":1584,"in_reply_to":"AAAALH%2F%2FbEM%3D","updated":"2012-09-12 15:12:23.000000000","message":"The two variables I made this comment under, current_memory_mb and new_memory_mb","commit_id":"da404fb9a58e99c328c04640834f1c91bf816743"},{"author":{"_account_id":4284,"name":"Alessandro Tagliapietra","email":"tagliapietra.alessandro@gmail.com","username":"tagliapietra.alessandro"},"change_message_id":"57f3656b4b2dd788831213f50a32c605aefe5ab5","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"        image \u003d self.image_service.show(context, instance[\u0027image_ref\u0027])"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"        current_memory_mb \u003d current_instance_type[\u0027memory_mb\u0027]"},{"line_number":1584,"context_line":"        new_memory_mb \u003d new_instance_type[\u0027memory_mb\u0027]"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        if same_instance_type and flavor_id:"},{"line_number":1587,"context_line":"            raise exception.CannotResizeToSameFlavor()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FbEM%3D","line":1584,"in_reply_to":"AAAALH%2F%2FbFA%3D","updated":"2012-09-12 15:07:42.000000000","message":"Which variables? same_instance_type and flavor_id? same_instance_type is used befor at line 1577 and flavor_id multiple times and you should check if it\u0027s not only moving and not resizing","commit_id":"da404fb9a58e99c328c04640834f1c91bf816743"}],"nova/exception.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"07983d02f7fe1ce41a63c7906671757f2f73e1dd","unresolved":false,"context_lines":[{"line_number":910,"context_line":""},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"class CannotResizeToSameSize(NovaException):"},{"line_number":913,"context_line":"    message \u003d _(\"When resizing, instances must change size!\")"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"class CannotResizeToSameFlavor(NovaException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FbE0%3D","line":913,"updated":"2012-09-12 15:03:54.000000000","message":"nova/api/openstack/compute/servers.py should be changed to use CannotResizeToSameFlavor from CannotResizeToSameSize.\n\nThis exception can then be removed","commit_id":"da404fb9a58e99c328c04640834f1c91bf816743"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":4284,"name":"Alessandro Tagliapietra","email":"tagliapietra.alessandro@gmail.com","username":"tagliapietra.alessandro"},"change_message_id":"c8c625c0087f44d5fa9143442cd37d08fd141f6c","unresolved":false,"context_lines":[{"line_number":3422,"context_line":""},{"line_number":3423,"context_line":"        self.compute.terminate_instance(context, instance\u003dinstance)"},{"line_number":3424,"context_line":""},{"line_number":3425,"context_line":"    def test_resize_same_flavor_fails(self):"},{"line_number":3426,"context_line":"        \"\"\"Ensure invalid flavors raise\"\"\""},{"line_number":3427,"context_line":"        context \u003d self.context.elevated()"},{"line_number":3428,"context_line":"        instance \u003d self._create_fake_instance()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FbRM%3D","line":3425,"updated":"2012-09-12 07:51:47.000000000","message":"I\u0027ve changed this to flavor because the check is not only in memory size but in flavor id","commit_id":"da404fb9a58e99c328c04640834f1c91bf816743"}]}