)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"25bdd69acf4ec9017fc64f76e6794666113fa1a3","unresolved":false,"context_lines":[{"line_number":891,"context_line":"                system_metadata\u003dsystem_meta)"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":894,"context_line":"    @reverts_task_state"},{"line_number":895,"context_line":"    @wrap_instance_fault"},{"line_number":896,"context_line":"    def terminate_instance(self, context, instance):"},{"line_number":897,"context_line":"        \"\"\"Terminate an instance on this host.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fa58%3D","side":"PARENT","line":894,"updated":"2012-09-12 16:58:16.000000000","message":"I\u0027d really like to see a comment explaining why reverts_task_state isn\u0027t used for terminate_instance","commit_id":"511807ed248fbe63cb6642c1cff6e0bd4bb8ae5d"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"41f0a5a9ee548b288446b4177b70364b6e07a7f2","unresolved":false,"context_lines":[{"line_number":891,"context_line":"                system_metadata\u003dsystem_meta)"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":894,"context_line":"    @reverts_task_state"},{"line_number":895,"context_line":"    @wrap_instance_fault"},{"line_number":896,"context_line":"    def terminate_instance(self, context, instance):"},{"line_number":897,"context_line":"        \"\"\"Terminate an instance on this host.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fa4o%3D","side":"PARENT","line":894,"in_reply_to":"AAAALH%2F%2Fa58%3D","updated":"2012-09-12 17:20:53.000000000","message":"Done in the latest patch set (as a regular comment now, as requested).","commit_id":"511807ed248fbe63cb6642c1cff6e0bd4bb8ae5d"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"c6ca6c00a7b01ef34ae016f708ba9452a36641b7","unresolved":false,"context_lines":[{"line_number":898,"context_line":"        because a failure during termination should leave the task state as"},{"line_number":899,"context_line":"        DELETING, as a signal to the API layer that a subsequent deletion"},{"line_number":900,"context_line":"        attempt should not result a further decrement of the quota_usages"},{"line_number":901,"context_line":"        in_use count (see bug 1046236)."},{"line_number":902,"context_line":"        \"\"\""},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"        elevated \u003d context.elevated()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fa4Y%3D","line":901,"updated":"2012-09-12 17:13:19.000000000","message":"A regular comment would seem to be more appropriate than a docstring. I don\u0027t know how useful this information is to someone reviewing generated documentation.","commit_id":"d9a1cf177bc94a46c17cebca3ae532f7e6548b4c"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"25bdd69acf4ec9017fc64f76e6794666113fa1a3","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        LOG.info(_(\"After terminating instances: %s\"), instances)"},{"line_number":510,"context_line":"        self.assertEqual(len(instances), 0)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def test_terminate_failure_leaves_task_state(self):"},{"line_number":513,"context_line":"        \"\"\"Ensure that a failure in terminate_instance does not result"},{"line_number":514,"context_line":"        in the task state being reverted from DELETING (see LP 1046236)."},{"line_number":515,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fa5s%3D","line":512,"updated":"2012-09-12 16:58:16.000000000","message":"How is this different than the terminate_instance case in test_state_revert? It looks like they are effectively the same?","commit_id":"020ec7585b51bf0c66aa82de64134b72400f29de"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"41f0a5a9ee548b288446b4177b70364b6e07a7f2","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        LOG.info(_(\"After terminating instances: %s\"), instances)"},{"line_number":510,"context_line":"        self.assertEqual(len(instances), 0)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def test_terminate_failure_leaves_task_state(self):"},{"line_number":513,"context_line":"        \"\"\"Ensure that a failure in terminate_instance does not result"},{"line_number":514,"context_line":"        in the task state being reverted from DELETING (see LP 1046236)."},{"line_number":515,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fa3Q%3D","line":512,"in_reply_to":"AAAALH%2F%2Fa5s%3D","updated":"2012-09-12 17:20:53.000000000","message":"The motivation for the extra testcase was simply to ensure that the failure occurs at a realistic point in the terminate_instance codepath, before the instance is destroyed.\n\nIn the other test, exceptions are simulated right at the very start (context.elevated) and end (_notify_about_instance_usage) which seemed a tad unrealistic.\n\nSo while I\u0027d agree that the extra testcase adds little value, I\u0027m not sure its of absolutely no value.","commit_id":"020ec7585b51bf0c66aa82de64134b72400f29de"}]}