)]}'
{"nova/tests/test_storwize_svc.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a0392103c179c3ef91105205d286c5c6a51ef4ea","unresolved":false,"context_lines":[{"line_number":932,"context_line":"        self.driver.do_setup(None)"},{"line_number":933,"context_line":"        self.driver.check_for_setup_error()"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    def _revert_flags(self):"},{"line_number":936,"context_line":"        for flag in storwize_svc.storwize_svc_opts:"},{"line_number":937,"context_line":"            setattr(storwize_svc.FLAGS, flag.name, flag.default)"},{"line_number":938,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FWZM%3D","line":935,"updated":"2012-09-19 15:48:07.000000000","message":"I think I see what you\u0027re doing with this, and this approach OK in the short term.  However, I\u0027d argue that this needs to be called in tearDown()—just consider what happens when a given test that calls _revert_flags() has a test failure!\n\nLong-term, however, this test suite needs to be updated to use the self.flags() infrastructure that test.TestCase already has in place to handle this very case.","commit_id":"82c589798c0dbe4710dc6517c7dba3f31d1cefe0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0e061e25ea3bd429c89573a008f0eaa55191b6c2","unresolved":false,"context_lines":[{"line_number":957,"context_line":"            is_volume_defined \u003d self.driver._is_volume_defined(volume[\"name\"])"},{"line_number":958,"context_line":"            self.assertEqual(is_volume_defined, True)"},{"line_number":959,"context_line":"            self.driver.delete_volume(volume)"},{"line_number":960,"context_line":"            FLAGS.reset()"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"    def test_storwize_svc_ip_connectivity(self):"},{"line_number":963,"context_line":"        # Check for missing san_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FThA%3D","line":960,"updated":"2012-09-24 15:20:35.000000000","message":"This shouldn\u0027t be necessary now that you\u0027ve switched this test class to using self.flags(); flag reset occurs in the tearDown() method, which is inherited from test.TestCase().","commit_id":"504514d294cd573bfebe4b86bc2d38b9302469ee"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0e061e25ea3bd429c89573a008f0eaa55191b6c2","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"            self.sim.error_injection(\"mkvdisk\", \"no_compression\")"},{"line_number":1273,"context_line":"            self.assertRaises(exception.ProcessExecutionError,"},{"line_number":1274,"context_line":"                    self._create_test_vol)"},{"line_number":1275,"context_line":"        FLAGS.reset()"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    def test_storwize_svc_unicode_host_and_volume_names(self):"},{"line_number":1278,"context_line":"        volume1 \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FTg0%3D","line":1275,"updated":"2012-09-24 15:20:35.000000000","message":"Again, this one isn\u0027t really necessary, because tearDown() will take care of it.","commit_id":"504514d294cd573bfebe4b86bc2d38b9302469ee"}],"nova/volume/storwize_svc.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a0392103c179c3ef91105205d286c5c6a51ef4ea","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d\u0027Enable Easy Tier for volumes\u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027storwize_svc_flashcopy_timeout\u0027,"},{"line_number":81,"context_line":"               default\u003d\u0027120\u0027,"},{"line_number":82,"context_line":"               help\u003d\u0027Maximum number of seconds to wait for FlashCopy to be\u0027"},{"line_number":83,"context_line":"                    \u0027prepared. Maximum value is 600 seconds (10 minutes).\u0027),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FWY4%3D","line":82,"updated":"2012-09-19 15:48:07.000000000","message":"I don\u0027t think you meant to remove this space; you have altered this help text to read \"beprepared\" instead of \"be prepared\".","commit_id":"82c589798c0dbe4710dc6517c7dba3f31d1cefe0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a0392103c179c3ef91105205d286c5c6a51ef4ea","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        if type(volume_easytier) !\u003d type(True):"},{"line_number":393,"context_line":"            raise exception.InvalidInput("},{"line_number":394,"context_line":"                reason\u003d_(\u0027Illegal value specified for \u0027"},{"line_number":395,"context_line":"                         \u0027storwize_svc_vol_easytier: set to either \u0027"},{"line_number":396,"context_line":"                         \u0027True or False\u0027))"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def do_setup(self, context):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FWY0%3D","line":395,"updated":"2012-09-19 15:48:07.000000000","message":"Honestly, I\u0027m not sure I understand why this original code tries to test the type of these flags; that should be handled by the configuration code to begin with (they are declared as boolean, correct?)","commit_id":"82c589798c0dbe4710dc6517c7dba3f31d1cefe0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a0392103c179c3ef91105205d286c5c6a51ef4ea","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        size \u003d int(volume[\u0027size\u0027])"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        if getattr(FLAGS, \u0027storwize_svc_vol_autoexpand\u0027) \u003d\u003d True:"},{"line_number":419,"context_line":"            autoex \u003d \u0027-autoexpand\u0027"},{"line_number":420,"context_line":"        else:"},{"line_number":421,"context_line":"            autoex \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FWYc%3D","line":418,"updated":"2012-09-19 15:48:07.000000000","message":"Why use getattr() in this way?  This isn\u0027t buying you anything at all; to access the value of the flag, just use \"FLAGS.storwize_svc_vol_autoexpand\".","commit_id":"82c589798c0dbe4710dc6517c7dba3f31d1cefe0"}]}